From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D05861D5CDD for ; Wed, 11 Jun 2025 18:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749668249; cv=none; b=hnNngjXAd90qcSR1EF2dFtVeoqBSGejBIVEFGb0evg+h3JSLC5Hi41sjWGNisAHTiHCQMZYRq3Mu/EHz6ePbIeiERXamoZEvb2kNHiSmuIv35VjYMX96o9EHNPzwcAhfRyZMdv8r5HypoEDE5bWD7vYP+0D3n3+EHmLdqfxGA4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749668249; c=relaxed/simple; bh=V+7AKa6FyLjb68uNNu+8sDkh3LsLbmL2kbRMyEaa4PE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XGmzshGZac3AdASfXmZ6B0BRq89YkzH+5+dsQtfWP9BuWdaWSSbPTsPZvzFvji7wiahvHRxbXn2HwmbBckUMgKcb0ZHLmhcAHkSFbontjc/8y/E+BuBhmbXVZYzU24ru9J2YsFfUJef7K6oevbUGWAClQ9iyUf29YcMBeYN/2eM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=CqqXV77N; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="CqqXV77N" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0jon10ihRrAz9X8phGqkkZ5jZ6YAa5eolZeDSdBxkBI=; b=CqqXV77NXE39Sjogy47DkJGgtR urzYy5XTmkN/jtZALd8daiZBoWL4quxcfbZJSLFhOeWZ2GPokkGRURDtWGfscVUDrYk6E1a8xoUei TgyWbjN9URf/s17Bs7RRC5JPbJGlpgn/UvQVjhTryjmmCs1v/hxk2eJvZdMQZjsccDtjvUM0ykVby DL2q1FTbyeaZaRHq0wNFCZNAct3CSwBCdx2qB7LVnAxJt5/+VVNZmpWoW1GlGkD9cMm+n8UpOhige 9zTLrMGr6jOlgCbo+IyO9mZxqnOpMSiP2O3VTHpJtWnyibuCqUb5KQ/3xUOzFrWiiJhXKNXv1cvfY mU4VKMyw==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPQdZ-00000005Ch1-16wV; Wed, 11 Jun 2025 18:57:25 +0000 Date: Wed, 11 Jun 2025 19:57:25 +0100 From: Al Viro To: Amir Goldstein Cc: Christian Brauner , Miklos Szeredi , Jan Kara , Linus Torvalds , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] fs: constify file ptr in backing_file accessor helpers Message-ID: <20250611185725.GQ299672@ZenIV> References: <20250607115304.2521155-1-amir73il@gmail.com> <20250607115304.2521155-2-amir73il@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250607115304.2521155-2-amir73il@gmail.com> Sender: Al Viro On Sat, Jun 07, 2025 at 01:53:03PM +0200, Amir Goldstein wrote: > -struct path *backing_file_user_path(struct file *f) > +struct path *backing_file_user_path(const struct file *f) > { > return &backing_file(f)->user_path; > } > EXPORT_SYMBOL_GPL(backing_file_user_path); const struct path *, hopefully? With separate backing_file_set_user_path() you shouldn't need to modify that struct path via that functions...