From: Al Viro <viro@zeniv.linux.org.uk>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Eric Biggers <ebiggers@google.com>,
linux-fsdevel@vger.kernel.org, LTP List <ltp@lists.linux.it>,
Petr Vorel <pvorel@suse.cz>
Subject: Re: interesting breakage in ltp fanotify10
Date: Mon, 23 Jun 2025 15:45:15 +0100 [thread overview]
Message-ID: <20250623144515.GB1880847@ZenIV> (raw)
In-Reply-To: <CAOQ4uxioVpa3u3MKwFBibs2X0TWiqwY=uGTZnjDoPSB01kk=yQ@mail.gmail.com>
On Mon, Jun 23, 2025 at 09:24:22AM +0200, Amir Goldstein wrote:
> On Sun, Jun 22, 2025 at 11:51 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > LTP 6763a3650734 "syscalls/fanotify10: Add test cases for evictable
> > ignore mark" has an interesting effect on boxen where FANOTIFY is not
> > enabled. The thing is, tst_brk() ends up calling ->cleanup(). See the
> > problem?
> > SAFE_FILE_PRINTF(CACHE_PRESSURE_FILE, "%d", old_cache_pressure);
> > is executed, even though
> > SAFE_FILE_SCANF(CACHE_PRESSURE_FILE, "%d", &old_cache_pressure);
> > /* Set high priority for evicting inodes */
> > SAFE_FILE_PRINTF(CACHE_PRESSURE_FILE, "500");
> > hadn't been.
> >
> > Result: fanotify10 on such kernel configs ends up zeroing
> > /proc/sys/vm/vfs_cache_pressure.
>
> oops.
> strange enough, I cannot reproduce it as something is preventing
> zeroing vfs_cache_pressure:
>
> fanotify23.c:232: TCONF: fanotify not configured in kernel
> fanotify23.c:249: TWARN: Failed to close FILE
> '/proc/sys/vm/vfs_cache_pressure': EINVAL (22)
How old is your ltp tree? Mine was from late May (81d460ba6737 "overcommit_memory:
Disable optimization for malloc to prevent false positives") and I'm definitely
seeing that behaviour with fanotify23 as well. No TWARN, though -
cmdline="fanotify23"
contacts=""
analysis=exit
<<<test_output>>>
tst_tmpdir.c:316: TINFO: Using /tmp/ltp-sIG1rbZMcQ/LTP_fan7Qw3GC as tmpdir (ext2/ext3/ext4 filesystem)
tst_device.c:98: TINFO: Found free device 0 '/dev/loop0'
tst_test.c:1216: TINFO: Formatting /dev/loop0 with ext2 opts='' extra opts=''
mke2fs 1.47.2 (1-Jan-2025)
tst_test.c:1228: TINFO: Mounting /dev/loop0 to /tmp/ltp-sIG1rbZMcQ/LTP_fan7Qw3GC/fs_mnt fstyp=ext2 flags=0
tst_test.c:1952: TINFO: LTP version: 20250130-274-g81d460ba6
tst_test.c:1955: TINFO: Tested kernel: 6.16.0-rc3+ #32 SMP PREEMPT_DYNAMIC Sun Jun 22 19:06:57 EDT 2025 x86_64
tst_kconfig.c:88: TINFO: Parsing kernel config '/boot/config-6.16.0-rc3+'
tst_test.c:1773: TINFO: Overall timeout per run is 0h 00m 30s
fanotify.h:175: TCONF: fanotify not configured in kernel
Summary:
passed 0
failed 0
broken 0
skipped 1
warnings 0
incrementing stop
<<<execution_status>>>
initiation_status="ok"
duration=1 termination_type=exited termination_id=32 corefile=no
cutime=0 cstime=1
<<<test_end>>>
next prev parent reply other threads:[~2025-06-23 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-22 21:51 interesting breakage in ltp fanotify10 Al Viro
2025-06-23 7:24 ` Amir Goldstein
2025-06-23 14:45 ` Al Viro [this message]
2025-06-23 15:19 ` Amir Goldstein
2025-06-23 15:38 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250623144515.GB1880847@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=ebiggers@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).