From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 557202FE310 for ; Fri, 4 Jul 2025 10:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751624813; cv=none; b=Hkd/6i6XyGp05Qn3PcfJItbjRC5f//w1RWhGMfXQv/UL7t1pW3XGAWjLsa/TUkZBHXX+7zAHAV7t+mNrV7F6yfLVUu4UGePFCRxKaQq2C/FjwHUy3hBovJHLqsxIOZgwSXs33fkPXPw2vNcs2cE1SZhkb0i/Vo6PSdmILsAJhWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751624813; c=relaxed/simple; bh=9t4RJIUzQtVpC+ufH2qeXROpTaW+ImBuVkRcsBTUgQk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aT0FKjN5xiT2mQMuRqyDxe8PMIbEN3CnFRp44qArqDUlFdoZ8sBAr4GeF+H+sIA2totK6s51qxyaaAR09DofbmZvQAUKk5L5aN133Jj3OLyq/x10gtFjC9kF2lilkWYj+pRpUqsV/BEc41X4frYOcJ3fs5/uZt92RG4JPa3EOMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=esL/z+PL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="esL/z+PL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751624810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mQ0XfChfbxm2lnvJaf8puphZG2XMtd7Fe0eRXg0ZpMo=; b=esL/z+PLls6K2fyxFk0u3ZVkF6qmNw7CaXXHTlLxQifRt4sPsATBRwhw4Nxg07yg0u8rGC x7nj6lOsIsFzlcF7IB3XO05P3YdeoCdslyHBlN1y1ix2pxoLnKP0IB9wU42hdWm0/rf7W7 rJ1+VaDkjmQukxeCGROb6yu1OZEPAYQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-QH23PCR6PVmy_uoPd9tPyg-1; Fri, 04 Jul 2025 06:26:49 -0400 X-MC-Unique: QH23PCR6PVmy_uoPd9tPyg-1 X-Mimecast-MFC-AGG-ID: QH23PCR6PVmy_uoPd9tPyg_1751624808 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43e9b0fd00cso4603165e9.0 for ; Fri, 04 Jul 2025 03:26:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624808; x=1752229608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mQ0XfChfbxm2lnvJaf8puphZG2XMtd7Fe0eRXg0ZpMo=; b=HuqwzaSIAXuy5AKNdotJ3Kb0rPg8Mv8BdVbdXSS+cEocJScKoeDOWC4jrK8DS8gStN /unpLXeGhU+kkpQouPptKYGIae8G0vubjhaXXz5uIlYd5JhirrcjX/8weE31Q/HEwZRK T2eAfxNPoDDpFDJ9onQURsDMcuU1pmSBJq2xECR+COiNCiTgkZaYNfuWTByNa157bh7J OBcCmwnAfwWpdXIkMt+aJJ4aH4dGnJS7WtGqzEcqVnxgo8d3KhoazT3n6a/jZTWNtXuP 8hjoYVg8lw7ZNzT5igfl7SIezL7gQTTNctutZq+PP7qAsDgBAGpdKq/CE15JlF+LesIs vSXQ== X-Forwarded-Encrypted: i=1; AJvYcCWfeTC/tc/xjtxNUmYWPgFMhsnDXFQsR2zk0wEEkKhkLOiXXM2zi6V1ZtHkapVJJ+vxcZ6jDc/EC83iCThW@vger.kernel.org X-Gm-Message-State: AOJu0YwNzafDjD2lycy8lfsDIJyaPuvitSHkVSI13EKIqYdxVH9hNa+v vFRIxQx7z5IQ4E46uq7W2f/dpX/k2fZTRUYntSf6mTUvpQDup3ejm76AEwEjPxCKSAUjAwyGm53 ABBQ5uFFpKisM10XeeDWkhVCpBfSUyu4PfBSlWLekXbU7VmWcwGSpG+ASEtREB7P7xek= X-Gm-Gg: ASbGnct8iDELxqPOTQsBd81H+3q+Es/sl7PrTRcMLMosz1FNNkNSYUydvVVg3SByW5J l6jVrjXPZYxDFvWMWhZJyrkIuKTImBWtHNKmkacoploKZ/kqZNqd5T/kus+5dMEKQIK+rvCRpWv X/hD4ByrWuJqvBKW3s9Rvwbvv1MElGiZE+RftTlPAHE1CXOge6V1KbBshB/4RyXy/pDWRGtgVCw Xg31r6yvOGaSHTYGqS5x0TAQ7cXkNMBcUPA8v0ruhkcteiyj9yA3BoNGIFIvtPWS79vlItulKdQ uV3kmhKVRoF2TT6g6xPCLaT26g4C1HjU5PiASznJ0PkjDSbiQCt07FNXU+9IM1xt4RT81YjqSjO ve8NCrg== X-Received: by 2002:a05:600c:8219:b0:442:f4a3:a2c0 with SMTP id 5b1f17b1804b1-454b30c46ecmr22270055e9.13.1751624807904; Fri, 04 Jul 2025 03:26:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDbvyyEAOAh2zTRSLUq2RLyWuJqmjCfdM4cRksQAqvl8abasokMK1aTRkGvgAfFTh32vAJjQ== X-Received: by 2002:a05:600c:8219:b0:442:f4a3:a2c0 with SMTP id 5b1f17b1804b1-454b30c46ecmr22269355e9.13.1751624807380; Fri, 04 Jul 2025 03:26:47 -0700 (PDT) Received: from localhost (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b471b9671asm2135708f8f.53.2025.07.04.03.26.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 03:26:46 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v2 28/29] mm/balloon_compaction: "movable_ops" doc updates Date: Fri, 4 Jul 2025 12:25:22 +0200 Message-ID: <20250704102524.326966-29-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704102524.326966-1-david@redhat.com> References: <20250704102524.326966-1-david@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Let's bring the docs up-to-date. Setting PG_movable_ops + page->private very likely still requires to be performed under documented locks: it's complicated. We will rework this in the future, as we will try avoiding using the page lock. Reviewed-by: Lorenzo Stoakes Signed-off-by: David Hildenbrand --- include/linux/balloon_compaction.h | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h index b222b0737c466..2fecfead91d26 100644 --- a/include/linux/balloon_compaction.h +++ b/include/linux/balloon_compaction.h @@ -4,12 +4,13 @@ * * Common interface definitions for making balloon pages movable by compaction. * - * Balloon page migration makes use of the general non-lru movable page + * Balloon page migration makes use of the general "movable_ops page migration" * feature. * * page->private is used to reference the responsible balloon device. - * page->mapping is used in context of non-lru page migration to reference - * the address space operations for page isolation/migration/compaction. + * That these pages have movable_ops, and which movable_ops apply, + * is derived from the page type (PageOffline()) combined with the + * PG_movable_ops flag (PageMovableOps()). * * As the page isolation scanning step a compaction thread does is a lockless * procedure (from a page standpoint), it might bring some racy situations while @@ -17,12 +18,10 @@ * and safely perform balloon's page compaction and migration we must, always, * ensure following these simple rules: * - * i. when updating a balloon's page ->mapping element, strictly do it under - * the following lock order, independently of the far superior - * locking scheme (lru_lock, balloon_lock): + * i. Setting the PG_movable_ops flag and page->private with the following + * lock order * +-page_lock(page); * +--spin_lock_irq(&b_dev_info->pages_lock); - * ... page->mapping updates here ... * * ii. isolation or dequeueing procedure must remove the page from balloon * device page list under b_dev_info->pages_lock. -- 2.49.0