Re: [PATCHES] assorted debugfs stuff

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Jul 02, 2025 at 10:13:05PM +0100, Al Viro wrote:
> 	A bit more of debugfs work; that stuff sits in
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git #work.debugfs
> Individual patches in followups.  Please, review.
> 
> Several removals of pointless debugfs_file_{get,put}():
>       zynqmp: don't bother with debugfs_file_{get,put}() in proxied fops
>       hfi1: get rid of redundant debugfs_file_{get,put}()
>       regmap: get rid of redundant debugfs_file_{get,put}()
>       resctrl: get rid of pointless debugfs_file_{get,put}()
> Getting rid of the last remnants of debugfs_real_fops():
>       vmscan: don't bother with debugfs_real_fops()
>       netronome: don't bother with debugfs_real_fops()
>       debugfs: split short and full proxy wrappers, kill debugfs_real_fops()
> 
> Bogosities in drivers/thermal/testing:
>       fix tt_command_write():
> 1) unbalanced debugfs_file_get().  Not needed in the first place -
> file_operations are accessed only via debugfs_create_file(), so
> debugfs wrappers will take care of that itself.
> 2) kmalloc() for a buffer used only for duration of a function is not
> a problem, but for a buffer no longer than 16 bytes?
> 3) strstr() is for finding substrings; for finding a character there's
> strchr().
> 
> debugfs_get_aux() stuff:
>       debugfs_get_aux(): allow storing non-const void *
>       blk-mq-debugfs: use debugfs_aux_data()
>       lpfc: don't use file->f_path.dentry for comparisons
> If you want a home-grown switch, at least use enum for selector...

All now queued up for testing, thanks.

greg k-h