public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: Bernd Schubert <bernd@bsbernd.com>,
	leo.lilong@huaweicloud.com,  miklos@szeredi.hu,
	leo.lilong@huawei.com, linux-fsdevel@vger.kernel.org,
	 yi.zhang@huawei.com, yangerkun@huawei.com, lonuxli.64@gmail.com
Subject: Re: [PATCH] fuse: show io_uring mount option in /proc/mounts
Date: Thu, 10 Jul 2025 13:27:20 +0200	[thread overview]
Message-ID: <20250710-prompt-erging-5771fc6c61bf@brauner> (raw)
In-Reply-To: <CAJnrk1a+a37BEj_RUASLok7dHyu4nBt7x=bFWA7M3XpCqtUxNA@mail.gmail.com>

On Wed, Jul 09, 2025 at 10:55:31AM -0700, Joanne Koong wrote:
> On Wed, Jul 9, 2025 at 4:24 AM Bernd Schubert <bernd@bsbernd.com> wrote:
> >
> > On 7/9/25 04:02, leo.lilong@huaweicloud.com wrote:
> > > From: Long Li <leo.lilong@huawei.com>
> > >
> > > When mounting a FUSE filesystem with io_uring option and using io_uring
> > > for communication, this option was not shown in /proc/mounts or mount
> > > command output. This made it difficult for users to verify whether
> > > io_uring was being used for communication in their FUSE mounts.
> > >
> > > Add io_uring to the list of mount options displayed in fuse_show_options()
> > > when the fuse-over-io_uring feature is enabled and being used.
> > >
> > > Signed-off-by: Long Li <leo.lilong@huawei.com>
> > > ---
> > >  fs/fuse/inode.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
> > > index ecb869e895ab..a6a8cd84fdde 100644
> > > --- a/fs/fuse/inode.c
> > > +++ b/fs/fuse/inode.c
> > > @@ -913,6 +913,8 @@ static int fuse_show_options(struct seq_file *m, struct dentry *root)
> > >                       seq_puts(m, ",default_permissions");
> > >               if (fc->allow_other)
> > >                       seq_puts(m, ",allow_other");
> > > +             if (fc->io_uring)
> > > +                     seq_puts(m, ",io_uring");
> > >               if (fc->max_read != ~0)
> > >                       seq_printf(m, ",max_read=%u", fc->max_read);
> > >               if (sb->s_bdev && sb->s_blocksize != FUSE_DEFAULT_BLKSIZE)
> >
> > I agree with you that is impossible to see, but issue is that io_uring
> > is not a mount option. Maybe we should add a sysfs file?
> >
> 
> Libfuse knows so what about just relaying that information from libfuse?

Yeah, if it's not a mount option we shouldn't actually display it in
mountinfo...

  reply	other threads:[~2025-07-10 11:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09  2:02 [PATCH] fuse: show io_uring mount option in /proc/mounts leo.lilong
2025-07-09 11:00 ` Bernd Schubert
2025-07-09 17:55   ` Joanne Koong
2025-07-10 11:27     ` Christian Brauner [this message]
2025-07-12  1:02   ` Long Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250710-prompt-erging-5771fc6c61bf@brauner \
    --to=brauner@kernel.org \
    --cc=bernd@bsbernd.com \
    --cc=joannelkoong@gmail.com \
    --cc=leo.lilong@huawei.com \
    --cc=leo.lilong@huaweicloud.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=lonuxli.64@gmail.com \
    --cc=miklos@szeredi.hu \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox