linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fuse: show io_uring mount option in /proc/mounts
@ 2025-07-09  2:02 leo.lilong
  2025-07-09 11:00 ` Bernd Schubert
  0 siblings, 1 reply; 5+ messages in thread
From: leo.lilong @ 2025-07-09  2:02 UTC (permalink / raw)
  To: miklos; +Cc: leo.lilong, linux-fsdevel, yi.zhang, yangerkun, lonuxli.64

From: Long Li <leo.lilong@huawei.com>

When mounting a FUSE filesystem with io_uring option and using io_uring
for communication, this option was not shown in /proc/mounts or mount
command output. This made it difficult for users to verify whether
io_uring was being used for communication in their FUSE mounts.

Add io_uring to the list of mount options displayed in fuse_show_options()
when the fuse-over-io_uring feature is enabled and being used.

Signed-off-by: Long Li <leo.lilong@huawei.com>
---
 fs/fuse/inode.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index ecb869e895ab..a6a8cd84fdde 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -913,6 +913,8 @@ static int fuse_show_options(struct seq_file *m, struct dentry *root)
 			seq_puts(m, ",default_permissions");
 		if (fc->allow_other)
 			seq_puts(m, ",allow_other");
+		if (fc->io_uring)
+			seq_puts(m, ",io_uring");
 		if (fc->max_read != ~0)
 			seq_printf(m, ",max_read=%u", fc->max_read);
 		if (sb->s_bdev && sb->s_blocksize != FUSE_DEFAULT_BLKSIZE)
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] fuse: show io_uring mount option in /proc/mounts
  2025-07-09  2:02 [PATCH] fuse: show io_uring mount option in /proc/mounts leo.lilong
@ 2025-07-09 11:00 ` Bernd Schubert
  2025-07-09 17:55   ` Joanne Koong
  2025-07-12  1:02   ` Long Li
  0 siblings, 2 replies; 5+ messages in thread
From: Bernd Schubert @ 2025-07-09 11:00 UTC (permalink / raw)
  To: leo.lilong, miklos
  Cc: leo.lilong, linux-fsdevel, yi.zhang, yangerkun, lonuxli.64



On 7/9/25 04:02, leo.lilong@huaweicloud.com wrote:
> From: Long Li <leo.lilong@huawei.com>
> 
> When mounting a FUSE filesystem with io_uring option and using io_uring
> for communication, this option was not shown in /proc/mounts or mount
> command output. This made it difficult for users to verify whether
> io_uring was being used for communication in their FUSE mounts.
> 
> Add io_uring to the list of mount options displayed in fuse_show_options()
> when the fuse-over-io_uring feature is enabled and being used.
> 
> Signed-off-by: Long Li <leo.lilong@huawei.com>
> ---
>  fs/fuse/inode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
> index ecb869e895ab..a6a8cd84fdde 100644
> --- a/fs/fuse/inode.c
> +++ b/fs/fuse/inode.c
> @@ -913,6 +913,8 @@ static int fuse_show_options(struct seq_file *m, struct dentry *root)
>  			seq_puts(m, ",default_permissions");
>  		if (fc->allow_other)
>  			seq_puts(m, ",allow_other");
> +		if (fc->io_uring)
> +			seq_puts(m, ",io_uring");
>  		if (fc->max_read != ~0)
>  			seq_printf(m, ",max_read=%u", fc->max_read);
>  		if (sb->s_bdev && sb->s_blocksize != FUSE_DEFAULT_BLKSIZE)

I agree with you that is impossible to see, but issue is that io_uring
is not a mount option. Maybe we should add a sysfs file?

Thanks,
Bernd

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fuse: show io_uring mount option in /proc/mounts
  2025-07-09 11:00 ` Bernd Schubert
@ 2025-07-09 17:55   ` Joanne Koong
  2025-07-10 11:27     ` Christian Brauner
  2025-07-12  1:02   ` Long Li
  1 sibling, 1 reply; 5+ messages in thread
From: Joanne Koong @ 2025-07-09 17:55 UTC (permalink / raw)
  To: Bernd Schubert
  Cc: leo.lilong, miklos, leo.lilong, linux-fsdevel, yi.zhang,
	yangerkun, lonuxli.64

On Wed, Jul 9, 2025 at 4:24 AM Bernd Schubert <bernd@bsbernd.com> wrote:
>
> On 7/9/25 04:02, leo.lilong@huaweicloud.com wrote:
> > From: Long Li <leo.lilong@huawei.com>
> >
> > When mounting a FUSE filesystem with io_uring option and using io_uring
> > for communication, this option was not shown in /proc/mounts or mount
> > command output. This made it difficult for users to verify whether
> > io_uring was being used for communication in their FUSE mounts.
> >
> > Add io_uring to the list of mount options displayed in fuse_show_options()
> > when the fuse-over-io_uring feature is enabled and being used.
> >
> > Signed-off-by: Long Li <leo.lilong@huawei.com>
> > ---
> >  fs/fuse/inode.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
> > index ecb869e895ab..a6a8cd84fdde 100644
> > --- a/fs/fuse/inode.c
> > +++ b/fs/fuse/inode.c
> > @@ -913,6 +913,8 @@ static int fuse_show_options(struct seq_file *m, struct dentry *root)
> >                       seq_puts(m, ",default_permissions");
> >               if (fc->allow_other)
> >                       seq_puts(m, ",allow_other");
> > +             if (fc->io_uring)
> > +                     seq_puts(m, ",io_uring");
> >               if (fc->max_read != ~0)
> >                       seq_printf(m, ",max_read=%u", fc->max_read);
> >               if (sb->s_bdev && sb->s_blocksize != FUSE_DEFAULT_BLKSIZE)
>
> I agree with you that is impossible to see, but issue is that io_uring
> is not a mount option. Maybe we should add a sysfs file?
>

Libfuse knows so what about just relaying that information from libfuse?


Thanks,
Joanne

> Thanks,
> Bernd
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fuse: show io_uring mount option in /proc/mounts
  2025-07-09 17:55   ` Joanne Koong
@ 2025-07-10 11:27     ` Christian Brauner
  0 siblings, 0 replies; 5+ messages in thread
From: Christian Brauner @ 2025-07-10 11:27 UTC (permalink / raw)
  To: Joanne Koong
  Cc: Bernd Schubert, leo.lilong, miklos, leo.lilong, linux-fsdevel,
	yi.zhang, yangerkun, lonuxli.64

On Wed, Jul 09, 2025 at 10:55:31AM -0700, Joanne Koong wrote:
> On Wed, Jul 9, 2025 at 4:24 AM Bernd Schubert <bernd@bsbernd.com> wrote:
> >
> > On 7/9/25 04:02, leo.lilong@huaweicloud.com wrote:
> > > From: Long Li <leo.lilong@huawei.com>
> > >
> > > When mounting a FUSE filesystem with io_uring option and using io_uring
> > > for communication, this option was not shown in /proc/mounts or mount
> > > command output. This made it difficult for users to verify whether
> > > io_uring was being used for communication in their FUSE mounts.
> > >
> > > Add io_uring to the list of mount options displayed in fuse_show_options()
> > > when the fuse-over-io_uring feature is enabled and being used.
> > >
> > > Signed-off-by: Long Li <leo.lilong@huawei.com>
> > > ---
> > >  fs/fuse/inode.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
> > > index ecb869e895ab..a6a8cd84fdde 100644
> > > --- a/fs/fuse/inode.c
> > > +++ b/fs/fuse/inode.c
> > > @@ -913,6 +913,8 @@ static int fuse_show_options(struct seq_file *m, struct dentry *root)
> > >                       seq_puts(m, ",default_permissions");
> > >               if (fc->allow_other)
> > >                       seq_puts(m, ",allow_other");
> > > +             if (fc->io_uring)
> > > +                     seq_puts(m, ",io_uring");
> > >               if (fc->max_read != ~0)
> > >                       seq_printf(m, ",max_read=%u", fc->max_read);
> > >               if (sb->s_bdev && sb->s_blocksize != FUSE_DEFAULT_BLKSIZE)
> >
> > I agree with you that is impossible to see, but issue is that io_uring
> > is not a mount option. Maybe we should add a sysfs file?
> >
> 
> Libfuse knows so what about just relaying that information from libfuse?

Yeah, if it's not a mount option we shouldn't actually display it in
mountinfo...

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fuse: show io_uring mount option in /proc/mounts
  2025-07-09 11:00 ` Bernd Schubert
  2025-07-09 17:55   ` Joanne Koong
@ 2025-07-12  1:02   ` Long Li
  1 sibling, 0 replies; 5+ messages in thread
From: Long Li @ 2025-07-12  1:02 UTC (permalink / raw)
  To: Bernd Schubert, leo.lilong, miklos
  Cc: linux-fsdevel, yi.zhang, yangerkun, lonuxli.64

On Wed, Jul 09, 2025 at 01:00:05PM +0200, Bernd Schubert wrote:
> 
> 
> On 7/9/25 04:02, leo.lilong@huaweicloud.com wrote:
> > From: Long Li <leo.lilong@huawei.com>
> > 
> > When mounting a FUSE filesystem with io_uring option and using io_uring
> > for communication, this option was not shown in /proc/mounts or mount
> > command output. This made it difficult for users to verify whether
> > io_uring was being used for communication in their FUSE mounts.
> > 
> > Add io_uring to the list of mount options displayed in fuse_show_options()
> > when the fuse-over-io_uring feature is enabled and being used.
> > 
> > Signed-off-by: Long Li <leo.lilong@huawei.com>
> > ---
> >  fs/fuse/inode.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
> > index ecb869e895ab..a6a8cd84fdde 100644
> > --- a/fs/fuse/inode.c
> > +++ b/fs/fuse/inode.c
> > @@ -913,6 +913,8 @@ static int fuse_show_options(struct seq_file *m, struct dentry *root)
> >  			seq_puts(m, ",default_permissions");
> >  		if (fc->allow_other)
> >  			seq_puts(m, ",allow_other");
> > +		if (fc->io_uring)
> > +			seq_puts(m, ",io_uring");
> >  		if (fc->max_read != ~0)
> >  			seq_printf(m, ",max_read=%u", fc->max_read);
> >  		if (sb->s_bdev && sb->s_blocksize != FUSE_DEFAULT_BLKSIZE)
> 
> I agree with you that is impossible to see, but issue is that io_uring
> is not a mount option. Maybe we should add a sysfs file?
> 

Yes, this is not a mount option. Thank you for your suggestion.

Thanks,
Long Li

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-07-12  1:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-09  2:02 [PATCH] fuse: show io_uring mount option in /proc/mounts leo.lilong
2025-07-09 11:00 ` Bernd Schubert
2025-07-09 17:55   ` Joanne Koong
2025-07-10 11:27     ` Christian Brauner
2025-07-12  1:02   ` Long Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).