From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Joanne Koong <joannelkoong@gmail.com>,
linux-fsdevel@vger.kernel.org, hch@lst.de, miklos@szeredi.hu,
brauner@kernel.org, anuj20.g@samsung.com, kernel-team@meta.com
Subject: Re: [PATCH v4 1/5] fuse: use iomap for buffered writes
Date: Mon, 14 Jul 2025 13:40:30 +0200 [thread overview]
Message-ID: <20250714114030.GA1847@lst.de> (raw)
In-Reply-To: <20250712044611.GI2672029@frogsfrogsfrogs>
On Fri, Jul 11, 2025 at 09:46:11PM -0700, Darrick J. Wong wrote:
[fullquote deleted. Any chance you could only quote the actually relevant
parts as per usual email ettiquette?]
> > @@ -1419,6 +1449,15 @@ static ssize_t fuse_cache_write_iter(struct kiocb *iocb, struct iov_iter *from)
> > goto out;
> > written = direct_write_fallback(iocb, from, written,
> > fuse_perform_write(iocb, from));
>
> Random unrelatd question: does anyone know why fuse handles IOCB_DIRECT
> in its fuse_cache_{read,write}_iter functions and /also/ sets
> ->direct_IO? I thought filesystems only did one or the other, not both.
Nothing really should be setting ->direct_IO these days except for
legacy reasons. It's another one of those method that aren't methods
but just callbacks that require file system specific context.
next prev parent reply other threads:[~2025-07-14 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 22:10 [PATCH v4 0/5] fuse: use iomap for buffered writes + writeback Joanne Koong
2025-07-09 22:10 ` [PATCH v4 1/5] fuse: use iomap for buffered writes Joanne Koong
2025-07-12 4:46 ` Darrick J. Wong
2025-07-12 6:13 ` Amir Goldstein
2025-07-14 11:40 ` Christoph Hellwig [this message]
2025-07-09 22:10 ` [PATCH v4 2/5] fuse: use iomap for writeback Joanne Koong
2025-07-12 4:41 ` Darrick J. Wong
2025-07-14 21:43 ` Joanne Koong
2025-07-09 22:10 ` [PATCH v4 3/5] fuse: use iomap for folio laundering Joanne Koong
2025-07-09 22:10 ` [PATCH v4 4/5] fuse: hook into iomap for invalidating and checking partial uptodateness Joanne Koong
2025-07-09 22:10 ` [PATCH v4 5/5] fuse: refactor writeback to use iomap_writepage_ctx inode Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250714114030.GA1847@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).