linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
	Matthew Wilcox <willy@infradead.org>,
	Jeff Layton <jlayton@kernel.org>, Jan Kara <jack@suse.com>,
	Jens Axboe <axboe@kernel.dk>, Josef Bacik <josef@toxicpanda.com>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC DRAFT DOESNOTBUILD] inode: free up more space
Date: Thu, 17 Jul 2025 13:43:17 +0200	[thread overview]
Message-ID: <20250717114317.GA18449@lst.de> (raw)
In-Reply-To: <20250717-klammheimlich-rosen-1868e233883a@brauner>

On Thu, Jul 17, 2025 at 01:40:15PM +0200, Christian Brauner wrote:
> The benefit will still be there for any filesystem that doesn't care
> about any of it which is most of them. One could also just split this up
> into topics: fsverity & fscrypt, quota likely separately, and then other
> stuff. But we can also just do that later and start with splitting it
> individually.

Having these arbitrary groups feels worse than just embedded structures
with the offset in the inode ops.  Because with more such semi-generic
fields there will be combinatoric explosion.

In general the even better option would of course be to either eliminate
the fields (which I think is doable for quotas), or restructure their
users to be proper library code so the file systems directly pass the
expected structures.  But both of these are a lot more work and I'm not
sure we'll get them done for all these.

  reply	other threads:[~2025-07-17 11:43 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15 14:35 [PATCH RFC DRAFT DOESNOTBUILD] inode: free up more space Christian Brauner
2025-07-15 14:52 ` Jeff Layton
2025-07-15 16:09 ` Matthew Wilcox
2025-07-16 12:53   ` Christian Brauner
2025-07-16 13:02   ` Christoph Hellwig
2025-07-17  7:48     ` Christian Brauner
2025-07-17  7:51       ` Christoph Hellwig
2025-07-17 15:55         ` Darrick J. Wong
2025-07-16  9:15 ` Jan Kara
2025-07-16  9:50   ` Christian Brauner
2025-07-16 11:21 ` Christoph Hellwig
2025-07-16 12:19   ` Christian Brauner
2025-07-16 12:38     ` Jeff Layton
2025-07-16 14:08       ` Matthew Wilcox
2025-07-16 14:10         ` Christoph Hellwig
2025-07-17  8:32           ` Christian Brauner
2025-07-17 10:54             ` Jan Kara
2025-07-17 11:40               ` Christian Brauner
2025-07-17 11:43                 ` Christoph Hellwig [this message]
2025-07-17 12:57     ` Jan Kara
2025-07-18  8:24       ` Christian Brauner
2025-07-18  8:32         ` Christoph Hellwig
2025-07-18  8:58           ` Christian Brauner
2025-07-18 16:04 ` Eric Biggers
2025-07-18 17:11   ` Eric Biggers
2025-07-21  6:14   ` Christoph Hellwig
2025-07-21 23:55     ` Eric Biggers
2025-07-22  5:49       ` Christoph Hellwig
2025-07-22  7:52       ` Jan Kara
2025-07-22 12:57         ` [PATCH RFC DRAFT v2 00/13] Move fscrypt and fsverity out of struct inode Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 01/13] fs: add fscrypt offset Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 02/13] fs/crypto: use accessors Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 03/13] ext4: move fscrypt to filesystem inode Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 04/13] ubifs: " Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 05/13] f2fs: " Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 06/13] ceph: " Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 07/13] fs: drop i_crypt_info from struct inode Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 08/13] fs: add fsverity offset Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 09/13] fs/verity: use accessors Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 10/13] btrfs: move fsverity to filesystem inode Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 11/13] ext4: " Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 12/13] f2fs: " Christian Brauner
2025-07-22 12:57           ` [PATCH RFC DRAFT v2 13/13] fs: drop i_verity_info from struct inode Christian Brauner
2025-07-22 13:09           ` [PATCH RFC DRAFT v2 00/13] Move fscrypt and fsverity out of " Christian Brauner
2025-07-22 19:27             ` [PATCH v3 " Christian Brauner
2025-07-22 19:27               ` [PATCH v3 01/13] fs: add fscrypt offset Christian Brauner
2025-07-22 20:02                 ` Eric Biggers
2025-07-23  7:48                   ` Christian Brauner
2025-07-23  3:49                 ` Al Viro
2025-07-22 19:27               ` [PATCH v3 02/13] fs/crypto: use accessors Christian Brauner
2025-07-22 19:27               ` [PATCH v3 03/13] ext4: move fscrypt to filesystem inode Christian Brauner
2025-07-22 20:07                 ` Eric Biggers
2025-07-23  8:59                   ` Christian Brauner
2025-07-22 19:27               ` [PATCH v3 04/13] ubifs: " Christian Brauner
2025-07-22 19:27               ` [PATCH v3 05/13] f2fs: " Christian Brauner
2025-07-22 19:27               ` [PATCH v3 06/13] ceph: " Christian Brauner
2025-07-22 20:14                 ` Eric Biggers
2025-07-23  8:58                   ` Christian Brauner
2025-07-22 19:27               ` [PATCH v3 07/13] fs: drop i_crypt_info from struct inode Christian Brauner
2025-07-22 20:19                 ` Eric Biggers
2025-07-23  8:52                   ` Christian Brauner
2025-07-22 19:27               ` [PATCH v3 08/13] fs: add fsverity offset Christian Brauner
2025-07-23  3:53                 ` Al Viro
2025-07-22 19:27               ` [PATCH v3 09/13] fs/verity: use accessors Christian Brauner
2025-07-22 20:25                 ` Eric Biggers
2025-07-23  8:55                   ` Christian Brauner
2025-07-22 19:27               ` [PATCH v3 10/13] btrfs: move fsverity to filesystem inode Christian Brauner
2025-07-22 19:27               ` [PATCH v3 11/13] ext4: " Christian Brauner
2025-07-22 19:27               ` [PATCH v3 12/13] f2fs: " Christian Brauner
2025-07-22 19:27               ` [PATCH v3 13/13] fs: drop i_verity_info from struct inode Christian Brauner
2025-07-23 10:57               ` [PATCH v4 00/15] Move fscrypt and fsverity out of " Christian Brauner
2025-07-23 10:57                 ` [PATCH v4 01/15] fs: add fscrypt offset Christian Brauner
2025-07-23 10:57                 ` [PATCH v4 02/15] fs/crypto: use accessors Christian Brauner
2025-07-25  0:29                   ` Eric Biggers
2025-07-25  4:01                   ` Eric Biggers
2025-07-23 10:57                 ` [PATCH v4 03/15] ext4: move fscrypt to filesystem inode Christian Brauner
2025-07-25  0:32                   ` Eric Biggers
2025-07-23 10:57                 ` [PATCH v4 04/15] ubifs: " Christian Brauner
2025-07-23 10:57                 ` [PATCH v4 05/15] f2fs: " Christian Brauner
2025-07-23 10:57                 ` [PATCH v4 06/15] ceph: " Christian Brauner
2025-07-25  0:34                   ` Eric Biggers
2025-07-25  8:15                     ` Christian Brauner
2025-07-23 10:57                 ` [PATCH v4 07/15] fs: drop i_crypt_info from struct inode Christian Brauner
2025-07-25  0:38                   ` Eric Biggers
2025-07-23 10:57                 ` [PATCH v4 08/15] fscrypt: rephrase documentation and comments Christian Brauner
2025-07-25  0:35                   ` Eric Biggers
2025-07-23 10:57                 ` [PATCH v4 09/15] fs: add fsverity offset Christian Brauner
2025-07-25  0:45                   ` Eric Biggers
2025-07-23 10:57                 ` [PATCH v4 10/15] fs/verity: use accessors Christian Brauner
2025-07-23 10:57                 ` [PATCH v4 11/15] btrfs: move fsverity to filesystem inode Christian Brauner
2025-07-23 10:57                 ` [PATCH v4 12/15] ext4: " Christian Brauner
2025-07-23 10:57                 ` [PATCH v4 13/15] f2fs: " Christian Brauner
2025-07-23 10:57                 ` [PATCH v4 14/15] fs: drop i_verity_info from struct inode Christian Brauner
2025-07-25  0:43                   ` Eric Biggers
2025-07-23 10:57                 ` [PATCH v4 15/15] fsverity: rephrase documentation and comments Christian Brauner
2025-07-22 13:50           ` [PATCH RFC DRAFT v2 00/13] Move fscrypt and fsverity out of struct inode Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250717114317.GA18449@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).