From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/3] Compression fixes for ntfs3
Date: Fri, 18 Jul 2025 20:53:55 +0100 [thread overview]
Message-ID: <20250718195400.1966070-1-willy@infradead.org> (raw)
Hi Konstantin,
I found three problems with the NTFS (de)compression code. The
first two are simple inefficiencies; there's no need to kmap these
pages. The third looks like a potential data corruption (description
in the patch). I've marked the third one for backport.
I haven't tested any of this; it could be that my analysis is wrong.
Matthew Wilcox (Oracle) (3):
ntfs: Do not kmap pages used for reading from disk
ntfs: Do not kmap page cache pages for compression
ntfs: Do not overwrite uptodate pages
fs/ntfs3/frecord.c | 50 +++++++++++++++++++++++++++-------------------
1 file changed, 29 insertions(+), 21 deletions(-)
--
2.47.2
next reply other threads:[~2025-07-18 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 19:53 Matthew Wilcox (Oracle) [this message]
2025-07-18 19:53 ` [PATCH 1/3] ntfs: Do not kmap pages used for reading from disk Matthew Wilcox (Oracle)
2025-07-18 19:53 ` [PATCH 2/3] ntfs: Do not kmap page cache pages for compression Matthew Wilcox (Oracle)
2025-07-18 19:53 ` [PATCH 3/3] ntfs: Do not overwrite uptodate pages Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718195400.1966070-1-willy@infradead.org \
--to=willy@infradead.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).