Re: [PATCH v4 07/15] fs: drop i_crypt_info from struct inode

Eric Biggers
2025-07-25T00:39:19Z

On Wed, Jul 23, 2025 at 12:57:45PM +0200, Christian Brauner wrote:
> + VFS_WARN_ON_ONCE(!inode->i_sb->s_cop);
> + VFS_WARN_ON_ONCE(!inode->i_sb->s_cop->inode_info_offs);

These warnings seem odd. The first is redundant with the fact that
there would be a NULL dereference anyway. The second should probably be
located in fscrypt_addr() so that it applies everywhere inode_info_offs
is used.

- Eric