Re: [PATCH v3 03/13] ext4: move fscrypt to filesystem inode

Christian Brauner
2025-07-23T08:59:21Z

On Tue, Jul 22, 2025 at 01:07:51PM -0700, Eric Biggers wrote:
> On Tue, Jul 22, 2025 at 09:27:21PM +0200, Christian Brauner wrote:
> > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> > index 18373de980f2..f27d57aea316 100644
> > --- a/fs/ext4/ext4.h
> > +++ b/fs/ext4/ext4.h
> > @@ -1197,6 +1197,10 @@ struct ext4_inode_info {
> > __u32 i_csum_seed;
> >
> > kprojid_t i_projid;
> > +
> > +#ifdef CONFIG_FS_ENCRYPTION
> > + struct fscrypt_inode_info *i_fscrypt_info;
> > +#endif
>
> Did you consider keeping the name as i_crypt_info instead of changing it
> to i_fscrypt_info? The rationale for i_crypt_info in the first place is
> that it's filesystem code, so fs is implied.

Ok.

>
> I see you also had to replace i_crypt_info with i_fscrypt_info in a
> bunch of comments. It might make more sense to rephrase those to not
> refer to the exact field name. E.g. instead of "Set up
> ->i_fscrypt_info", we could write "Set up the inode's fscrypt info".

Ok, I'll do that.