[PATCH v4 10/15] fs/verity: use accessors

Christian Brauner
2025-07-23T10:58:34Z

Use accessor to get and set the verity info from the filesystem.
They can be removed once all filesystems have been converted to make
room for verity info in their own inodes.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
fs/verity/open.c | 19 ++++++++++++++++---
fs/verity/verify.c | 2 +-
include/linux/fsverity.h | 12 +++++++++++-
3 files changed, 28 insertions(+), 5 deletions(-)

diff --git a/fs/verity/open.c b/fs/verity/open.c
index fdeb95eca3af..a4d7388e2f71 100644
--- a/fs/verity/open.c
+++ b/fs/verity/open.c
@@ -250,13 +250,20 @@ struct fsverity_info *fsverity_create_info(const struct inode *inode,

void fsverity_set_info(struct inode *inode, struct fsverity_info *vi)
{
+ void *p;
+
/*
* Multiple tasks may race to set ->i_verity_info, so use
* cmpxchg_release(). This pairs with the smp_load_acquire() in
* fsverity_get_info(). I.e., here we publish ->i_verity_info with a
* RELEASE barrier so that other tasks can ACQUIRE it.
*/
- if (cmpxchg_release(&inode->i_verity_info, NULL, vi) != NULL) {
+
+ if (inode->i_sb->s_vop->inode_info_offs)
+ p = cmpxchg_release(fsverity_addr(inode), NULL, vi);
+ else
+ p = cmpxchg_release(&inode->i_verity_info, NULL, vi);
+ if (p != NULL) {
/* Lost the race, so free the fsverity_info we allocated. */
fsverity_free_info(vi);
/*
@@ -402,8 +409,14 @@ EXPORT_SYMBOL_GPL(__fsverity_prepare_setattr);

void __fsverity_cleanup_inode(struct inode *inode)
{
- fsverity_free_info(inode->i_verity_info);
- inode->i_verity_info = NULL;
+ struct fsverity_info **vi;
+
+ if (inode->i_sb->s_vop->inode_info_offs)
+ vi = fsverity_addr(inode);
+ else
+ vi = &inode->i_verity_info;
+ fsverity_free_info(*vi);
+ *vi = NULL;
}
EXPORT_SYMBOL_GPL(__fsverity_cleanup_inode);

diff --git a/fs/verity/verify.c b/fs/verity/verify.c
index 4fcad0825a12..a9c2f5c86991 100644
--- a/fs/verity/verify.c
+++ b/fs/verity/verify.c
@@ -247,7 +247,7 @@ verify_data_blocks(struct folio *data_folio, size_t len, size_t offset,
unsigned long max_ra_pages)
{
struct inode *inode = data_folio->mapping->host;
- struct fsverity_info *vi = inode->i_verity_info;
+ struct fsverity_info *vi = fsverity_get_info(inode);
const unsigned int block_size = vi->tree_params.block_size;
u64 pos = (u64)data_folio->index << PAGE_SHIFT;

diff --git a/include/linux/fsverity.h b/include/linux/fsverity.h
index 85831f36e2f8..75ff6c9c50ef 100644
--- a/include/linux/fsverity.h
+++ b/include/linux/fsverity.h
@@ -129,14 +129,24 @@ struct fsverity_operations {

#ifdef CONFIG_FS_VERITY

+static inline struct fsverity_info **fsverity_addr(const struct inode *inode)
+{
+ return ((void *)inode + inode->i_sb->s_vop->inode_info_offs);
+}
+
static inline struct fsverity_info *fsverity_get_info(const struct inode *inode)
{
+ if (!inode->i_sb->s_vop)
+ return NULL;
+
/*
* Pairs with the cmpxchg_release() in fsverity_set_info().
* I.e., another task may publish ->i_verity_info concurrently,
* executing a RELEASE barrier. We need to use smp_load_acquire() here
* to safely ACQUIRE the memory the other task published.
*/
+ if (inode->i_sb->s_vop->inode_info_offs)
+ return smp_load_acquire(fsverity_addr(inode));
return smp_load_acquire(&inode->i_verity_info);
}

@@ -165,7 +175,7 @@ void __fsverity_cleanup_inode(struct inode *inode);
*/
static inline void fsverity_cleanup_inode(struct inode *inode)
{
- if (inode->i_verity_info)
+ if (IS_VERITY(inode))
__fsverity_cleanup_inode(inode);
}

--
2.47.2