Re: [PATCH v2 8/9] mm: introduce and use vm_normal_page_pud()

Lorenzo Stoakes
2025-07-18T10:48:10Z

On Thu, Jul 17, 2025 at 10:14:33PM +0200, David Hildenbrand wrote:
> On 17.07.25 22:03, Lorenzo Stoakes wrote:
> > On Thu, Jul 17, 2025 at 01:52:11PM +0200, David Hildenbrand wrote:
> > > Let's introduce vm_normal_page_pud(), which ends up being fairly simple
> > > because of our new common helpers and there not being a PUD-sized zero
> > > folio.
> > >
> > > Use vm_normal_page_pud() in folio_walk_start() to resolve a TODO,
> > > structuring the code like the other (pmd/pte) cases. Defer
> > > introducing vm_normal_folio_pud() until really used.
> >
> > I mean fine :P but does anybody really use this?
>
> This is a unified PFN walker (!hugetlb + hugetlb), so you can easily run
> into hugetlb PUDs, DAX PUDs and huge pfnmap (vfio) PUDs :)

Ahhh ok. I hate hugetlb so very very much.

Oscar is doing the Lord's work improving things but the trauma is still
there... :P

Also yeah DAX ahem.

I'm not familiar with huge pfnmap PUDs, could you give me a hint on this? :>)

>
> --
> Cheers,
>
> David / dhildenb
>