From: Al Viro <viro@zeniv.linux.org.uk>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
David Howells <dhowells@redhat.com>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] vfs: output mount_too_revealing() errors to fscontext
Date: Wed, 6 Aug 2025 06:41:16 +0100 [thread overview]
Message-ID: <20250806054116.GE222315@ZenIV> (raw)
In-Reply-To: <20250806-errorfc-mount-too-revealing-v1-2-536540f51560@cyphar.com>
On Wed, Aug 06, 2025 at 02:48:30PM +1000, Aleksa Sarai wrote:
> error = security_sb_kern_mount(sb);
> - if (!error && mount_too_revealing(sb, &mnt_flags))
> + if (!error && mount_too_revealing(sb, &mnt_flags)) {
> error = -EPERM;
> + errorfcp(fc, "VFS", "Mount too revealing");
> + }
Hmm... For aesthetics sake, I'd probably do logging first; otherwise
fine by me.
next prev parent reply other threads:[~2025-08-06 5:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 4:48 [PATCH 0/2] vfs: output mount_too_revealing() errors to fscontext Aleksa Sarai
2025-08-06 4:48 ` [PATCH 1/2] fscontext: add custom-prefix log helpers Aleksa Sarai
2025-08-06 4:48 ` [PATCH 2/2] vfs: output mount_too_revealing() errors to fscontext Aleksa Sarai
2025-08-06 5:41 ` Al Viro [this message]
2025-08-06 6:06 ` Aleksa Sarai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250806054116.GE222315@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).