From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8780221CC63 for ; Fri, 8 Aug 2025 19:32:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754681541; cv=none; b=jik5lNlxpfU9HEhcRxNADTpoNdJnhIOstrAERNGnA3DL5fkjm/qne7yq591L1d9eq6glSLZ9MAu/lTSu5mx/7t7f6Tt/Fn+9K3sh78H0SOyhS+jKQhJTaPORtwyR3+wclQwugGJfHWT1+MWImVkKl5d5O+Zc3vNOsgIvrtrOVYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754681541; c=relaxed/simple; bh=plaTtuQnRmWgM48fnGmtDOucRd+m6YR/8tSDjJ3yGEc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XRxJS1+AoQiTwm/kH8FnAEG0iO7U7lGhYgHrdyhQS9gKxAy40/EN6FPMqieH6LSIb20Ap4v4BfASaIy2z/KDQtUjYH0ga85XyX6b4soPWh6AxX62kPBHZTvJv8tm02iRiZ2xWpz8exIndRURrqGrmI1uIF4uPlb4W3YyvY5T40Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=do6XhDRT; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="do6XhDRT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754681538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/RAYwUmVRutOytAMApm6QOTB180QV4zbsyVGr1FDRzE=; b=do6XhDRTQNZ3vRLT6D7H6Dx6M/8C05yr3TaASm+HmDDuGsLgzxCV4rPr+51xdFLjqi2Q+b EdRlE+vf3rHyHpJkIIGruaCXv7SxhpMqT11k0XdPO3xRpZD+jaf+4IXL8dq437k0HXqMLv fCr3v6TFdUbQu3Bpg8EWkU5DcyZdV7Y= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-RClKy5ssMbCZAsY2RTjexw-1; Fri, 08 Aug 2025 15:32:17 -0400 X-MC-Unique: RClKy5ssMbCZAsY2RTjexw-1 X-Mimecast-MFC-AGG-ID: RClKy5ssMbCZAsY2RTjexw_1754681536 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-459d7ed90baso17512415e9.2 for ; Fri, 08 Aug 2025 12:32:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754681536; x=1755286336; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/RAYwUmVRutOytAMApm6QOTB180QV4zbsyVGr1FDRzE=; b=VRwjeff2aZsixIuQulaeh1KHNZPOOTtcuER6ioUGCn82u1Dc/KIwzDDwCPQ49TWow/ SyAZLH8GrMYFJa/c7hOYyA9lX3hACyMOOPUDa+if0LQCXVwkKE3+OJd6el9J6jFVQYGE 3u2cOrO0P4VKNMz2tkKBlsnvoYawZGrysWfq6elOgIa5dPpJYgyPrN0/V0yTWTDIBdRj EdKd4isQsL3qtzS+HHiCd4jWf7QiIz6x4owJ2W8QMHcVvt1hWRZi0vp2stkzVNTh0EIE 7ruSi3aL+nkxL09XV3PQkyZQ3llF/zw4FHjrbjiECf9SHJ77VRM9W5oTXCXs1Y+tOfPr 8urg== X-Forwarded-Encrypted: i=1; AJvYcCVCqjYaO0QRGS8U1bxlT73Bjad6zUH11FdI4bbTnayYeeBpkmPvxUFjXLIrCGC5wO7htRFjLOMzZ61b2YSB@vger.kernel.org X-Gm-Message-State: AOJu0YwtL5ovnfES91ijzhWTsAK9prwB2LQZ+3scEWjavUZUPaF/9hJU 3Cp8tmXXjzH72Hk21jYzoSitjxpsv5cAM5Zc8Rpp6flnornGKtl5KDsfBkePfZmcocqBso4Y1JA LVE9bSDgaAstcGlUUiCobE4fJTsUV1a2xK83/tNv/L2eAGBRmeDHvmUjuos7w9reG5g== X-Gm-Gg: ASbGncs0V1T6G3aeedGwYJXbQLGy/rtSxd3CF265OXRgHvCN+hjRk8WpGbAoaPBBkNx R3BYPpHXgQTtF/MEw2AzX+f+cnJrkWfUm/QljXfP6txCRVAJFDp8dz7Rgrr/SJp3D/2wSFPCWcd UHmNrXuy1dWQxa0rhZsJAWLTTmjx6ZYkDeR+bZoQobPq4FYAXVJMxhQTnpIbew1709GhLE8P2CU 3v4kY4prGgwRqIfO4iSv1R7CKIlplxKK2+xSsv6uwazWdoulLFZgkIhxEeo4FY6VBdjyuIZ12u2 JP171X11T6vVGSBZWLutkJFSGfFFqp8pJ3+eCAhZbemstw== X-Received: by 2002:a05:600c:4449:b0:459:df25:b839 with SMTP id 5b1f17b1804b1-459f4f2e2c1mr37916155e9.33.1754681535727; Fri, 08 Aug 2025 12:32:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGuwt870vmGOcNEdEU1nivjuGCazvfx/iqBh+iw0Tbp+KMHhMx1C7ibV5K/scZCbTiJYZp7Ew== X-Received: by 2002:a05:600c:4449:b0:459:df25:b839 with SMTP id 5b1f17b1804b1-459f4f2e2c1mr37915975e9.33.1754681535259; Fri, 08 Aug 2025 12:32:15 -0700 (PDT) Received: from [127.0.0.2] (ip-217-030-074-039.aim-net.cz. [217.30.74.39]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459e5869cccsm164906135e9.17.2025.08.08.12.32.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Aug 2025 12:32:14 -0700 (PDT) From: Andrey Albershteyn X-Google-Original-From: Andrey Albershteyn Date: Fri, 08 Aug 2025 21:31:57 +0200 Subject: [PATCH 2/3] generic: introduce test to test file_getattr/file_setattr syscalls Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250808-xattrat-syscall-v1-2-6a09c4f37f10@kernel.org> References: <20250808-xattrat-syscall-v1-0-6a09c4f37f10@kernel.org> In-Reply-To: <20250808-xattrat-syscall-v1-0-6a09c4f37f10@kernel.org> To: fstests@vger.kernel.org Cc: zlang@redhat.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, Andrey Albershteyn X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=5375; i=aalbersh@kernel.org; h=from:subject:message-id; bh=plaTtuQnRmWgM48fnGmtDOucRd+m6YR/8tSDjJ3yGEc=; b=owJ4nJvAy8zAJea2/JXEGuOHHIyn1ZIYMqYF7HWQWmrzetn18GeXjxtxxUnW2aR/uS5jv7ozj bPgmfVax4kdpSwMYlwMsmKKLOuktaYmFUnlHzGokYeZw8oEMoSBi1MAJpLixMiw2eztMR/htj9m xjbquSfecIb+efH4ZIboe5HKFX17En8XMTLc+epSUz/v5ULer8yhK7kveH8WDp6nycuS3yGaurR uDTcXACHBRi4= X-Developer-Key: i=aalbersh@kernel.org; a=openpgp; fpr=AE1B2A9562721A6FC4307C1F46A7EA18AC33E108 Add a test to test basic functionality of file_getattr() and file_setattr() syscalls. Most of the work is done in file_attr utility. Signed-off-by: Andrey Albershteyn --- tests/generic/2000 | 113 +++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/2000.out | 37 ++++++++++++++++ 2 files changed, 150 insertions(+) diff --git a/tests/generic/2000 b/tests/generic/2000 new file mode 100755 index 000000000000..b4410628c241 --- /dev/null +++ b/tests/generic/2000 @@ -0,0 +1,113 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Red Hat Inc. All Rights Reserved. +# +# FS QA Test No. 2000 +# +# Test file_getattr/file_setattr syscalls +# +. ./common/preamble +_begin_fstest auto + +# Import common functions. +# . ./common/filter + +_wants_kernel_commit xxxxxxxxxxx \ + "fs: introduce file_getattr and file_setattr syscalls" + +# Modify as appropriate. +_require_scratch +_require_test_program "af_unix" +_require_test_program "file_attr" +_require_symlinks +_require_mknod + +_scratch_mkfs >>$seqres.full 2>&1 +_scratch_mount + +file_attr () { + $here/src/file_attr $* +} + +create_af_unix () { + $here/src/af_unix $* || echo af_unix failed +} + +projectdir=$SCRATCH_MNT/prj + +# Create normal files and special files +mkdir $projectdir +mkfifo $projectdir/fifo +mknod $projectdir/chardev c 1 1 +mknod $projectdir/blockdev b 1 1 +create_af_unix $projectdir/socket +touch $projectdir/foo +ln -s $projectdir/foo $projectdir/symlink +touch $projectdir/bar +ln -s $projectdir/bar $projectdir/broken-symlink +rm -f $projectdir/bar + +echo "Error codes" +# wrong AT_ flags +file_attr --get --invalid-at $projectdir ./foo +file_attr --set --invalid-at $projectdir ./foo +# wrong fsxattr size (too big, too small) +file_attr --get --too-big-arg $projectdir ./foo +file_attr --get --too-small-arg $projectdir ./foo +file_attr --set --too-big-arg $projectdir ./foo +file_attr --set --too-small-arg $projectdir ./foo +# out of fsx_xflags mask +file_attr --set --new-fsx-flag $projectdir ./foo + +echo "Initial attributes state" +file_attr --get $projectdir +file_attr --get $projectdir ./fifo +file_attr --get $projectdir ./chardev +file_attr --get $projectdir ./blockdev +file_attr --get $projectdir ./socket +file_attr --get $projectdir ./foo +file_attr --get $projectdir ./symlink + +echo "Set FS_XFLAG_NODUMP (d)" +file_attr --set --set-nodump $projectdir +file_attr --set --set-nodump $projectdir ./fifo +file_attr --set --set-nodump $projectdir ./chardev +file_attr --set --set-nodump $projectdir ./blockdev +file_attr --set --set-nodump $projectdir ./socket +file_attr --set --set-nodump $projectdir ./foo +file_attr --set --set-nodump $projectdir ./symlink + +echo "Read attributes" +file_attr --get $projectdir +file_attr --get $projectdir ./fifo +file_attr --get $projectdir ./chardev +file_attr --get $projectdir ./blockdev +file_attr --get $projectdir ./socket +file_attr --get $projectdir ./foo +file_attr --get $projectdir ./symlink + +echo "Set attribute on broken link with AT_SYMLINK_NOFOLLOW" +file_attr --set --set-nodump $projectdir ./broken-symlink +file_attr --get $projectdir ./broken-symlink + +file_attr --set --no-follow --set-nodump $projectdir ./broken-symlink +file_attr --get --no-follow $projectdir ./broken-symlink + +cd $SCRATCH_MNT +touch ./foo2 +echo "Initial state of foo2" +file_attr --get --at-cwd ./foo2 +echo "Set attribute relative to AT_FDCWD" +file_attr --set --at-cwd --set-nodump ./foo2 +file_attr --get --at-cwd ./foo2 + +echo "Set attribute on AT_FDCWD" +mkdir ./bar +file_attr --get --at-cwd ./bar +cd ./bar +file_attr --set --at-cwd --set-nodump "" +file_attr --get --at-cwd . + +# success, all done +status=0 +exit diff --git a/tests/generic/2000.out b/tests/generic/2000.out new file mode 100644 index 000000000000..51b4d84e2bae --- /dev/null +++ b/tests/generic/2000.out @@ -0,0 +1,37 @@ +QA output created by 2000 +Error codes +Can not get fsxattr on ./foo: Invalid argument +Can not get fsxattr on ./foo: Invalid argument +Can not get fsxattr on ./foo: Argument list too long +Can not get fsxattr on ./foo: Invalid argument +Can not get fsxattr on ./foo: Argument list too long +Can not get fsxattr on ./foo: Invalid argument +Can not set fsxattr on ./foo: Invalid argument +Initial attributes state +----------------- /mnt/scratch/prj +----------------- ./fifo +----------------- ./chardev +----------------- ./blockdev +----------------- ./socket +----------------- ./foo +----------------- ./symlink +Set FS_XFLAG_NODUMP (d) +Read attributes +------d---------- /mnt/scratch/prj +------d---------- ./fifo +------d---------- ./chardev +------d---------- ./blockdev +------d---------- ./socket +------d---------- ./foo +------d---------- ./symlink +Set attribute on broken link with AT_SYMLINK_NOFOLLOW +Can not get fsxattr on ./broken-symlink: No such file or directory +Can not get fsxattr on ./broken-symlink: No such file or directory +------d---------- ./broken-symlink +Initial state of foo2 +----------------- ./foo2 +Set attribute relative to AT_FDCWD +------d---------- ./foo2 +Set attribute on AT_FDCWD +----------------- ./bar +------d---------- . -- 2.49.0