From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C58427FB2A for ; Fri, 8 Aug 2025 14:31:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754663495; cv=none; b=miHR5FFSRcMDRItDyICNn4vhnlHAUw8sgcvZxqKXp8t6uxug501dQ5EJsZ+D9VmimSZHQ7qEnaT5k/jhhvTS9lLS/D4i8rUq0RAqazBDl8fmOQ563gyoRv+WCGjG/mQG99fav46I3vnD+lHddoKpKjQ4L3GyKG1WSfxJinBhBwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754663495; c=relaxed/simple; bh=6h331knxWWLi5xlaD04ppqmYxJqO9T/0v1OIGs3CC2Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nr/uqXrzuqfX38VYO1a52faJpnV7zUHjQaOO7FSYzKLSwGq72WvaE/FpApovo6HGMpDK+bFfVT/7OQHg5BpcYKt7Zw0yb+cGDYukGeAw1EaYhrQq9BH3SR2eNx0wyEOMdlQvMAPgFWUYhzfgxC6smL2ETEhxbKGu5gJ6JNRQ6OY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MJVAMQfF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MJVAMQfF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754663492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pVhHzmrsz3RzEJrixBNs+yxJAkbGyaM42AxRbLiYFUU=; b=MJVAMQfFzpKKxxesbNEmDeK1jm/5K+NNm2oTAkGeBFpQYT3pqOURZztRO+JDHrHaKzTmjB yKXMVLUVnvw9Mz6p111bj7cEqaC+gzSCYuNU+sFZVDf0TmIJDGRPvcMraAFOCYNXPUpuSl 9g96LhwHUxVYMxYygRxtW8tA6H6zuYg= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-DJbDAkNNMHyGQLED60pccg-1; Fri, 08 Aug 2025 10:31:28 -0400 X-MC-Unique: DJbDAkNNMHyGQLED60pccg-1 X-Mimecast-MFC-AGG-ID: DJbDAkNNMHyGQLED60pccg_1754663484 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 07B30180035D; Fri, 8 Aug 2025 14:31:22 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.117]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 1177A1800446; Fri, 8 Aug 2025 14:31:01 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 8 Aug 2025 16:30:10 +0200 (CEST) Date: Fri, 8 Aug 2025 16:29:49 +0200 From: Oleg Nesterov To: Zihuan Zhang Cc: "Rafael J . Wysocki" , Peter Zijlstra , David Hildenbrand , Michal Hocko , Jonathan Corbet , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , len brown , pavel machek , Kees Cook , Andrew Morton , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Catalin Marinas , Nico Pache , xu xin , wangfushuai , Andrii Nakryiko , Christian Brauner , Thomas Gleixner , Jeff Layton , Al Viro , Adrian Ratiu , linux-pm@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v1 6/9] freezer: Set default freeze priority for zombie tasks Message-ID: <20250808142948.GA21685@redhat.com> References: <20250807121418.139765-1-zhangzihuan@kylinos.cn> <20250807121418.139765-7-zhangzihuan@kylinos.cn> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250807121418.139765-7-zhangzihuan@kylinos.cn> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On 08/07, Zihuan Zhang wrote: > > @@ -6980,6 +6981,7 @@ void __noreturn do_task_dead(void) > current->flags |= PF_NOFREEZE; > > __schedule(SM_NONE); > + freeze_set_default_priority(current, FREEZE_PRIORITY_NEVER); > BUG(); But this change has no effect? Firstly, this last __schedule() should not return, note the BUG() we have. Secondly, this zombie is already PF_NOFREEZE, freeze_task() will return false anyway. Oleg.