From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AC5A283146 for ; Fri, 8 Aug 2025 14:55:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754664929; cv=none; b=hHCcBQGTl95+6V2aoIkT2S3P3wFAR7f04ZfH1LwLqnTH0IaUYwlFYnN/YxCUtGq+bIBtpDNWdMmt8V/YNSjKPwyO4smQojXFGEq28oQWoZxVQ78o/BJA0usnON7Ear65EkVReGBrqwtggiOfr8F0gJrfsBuPhwU2sKKomAsfOwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754664929; c=relaxed/simple; bh=Tj7T2vafcrPanx5uGIfgumtfb4o9PLTGmL4k/Y3xDwE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WDrewPAt3Rlj5kZfjRuGOmlWsVfu73jg12WxfVKQ9eSTiq0KXoofVQjOtWoLqfpOMLawqD6ApsRFidmWrGdNrQ1ngLqkbHhIJaKzCld08bBb6cYo9jzB7LB89c9dCALkqWyE9frti1W0LfGMZnBRywXQIbuNMgcZ3PAiNhaRwEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BN7YnwTD; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BN7YnwTD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754664926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gkM3QF49wtdLwhGqe2QpWy/vLyG4tuPu0m+0oSeMzXc=; b=BN7YnwTD/fYIyL5wrO9W6m3WvKcCvGWO5FsMcw9TqN6tPND2w711voETFl813y9A8EeYNj BpgVgbL4Rl64TpE+Yc2JY7UQ+viBXjj/+GgkgCSbOaTp8UyUMtywF5A89C1aXUsbqbmoBK 9ysd3fw+yL1cn+jbIOj10+MrC2wGxOg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-131-M8qeCOvAPA6mb-zvy_eSGw-1; Fri, 08 Aug 2025 10:55:23 -0400 X-MC-Unique: M8qeCOvAPA6mb-zvy_eSGw-1 X-Mimecast-MFC-AGG-ID: M8qeCOvAPA6mb-zvy_eSGw_1754664919 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2EE8D1800280; Fri, 8 Aug 2025 14:55:17 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.117]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 36BCD180047F; Fri, 8 Aug 2025 14:55:02 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 8 Aug 2025 16:54:05 +0200 (CEST) Date: Fri, 8 Aug 2025 16:53:50 +0200 From: Oleg Nesterov To: Zihuan Zhang Cc: "Rafael J . Wysocki" , Peter Zijlstra , David Hildenbrand , Michal Hocko , Jonathan Corbet , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , len brown , pavel machek , Kees Cook , Andrew Morton , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Catalin Marinas , Nico Pache , xu xin , wangfushuai , Andrii Nakryiko , Christian Brauner , Thomas Gleixner , Jeff Layton , Al Viro , Adrian Ratiu , linux-pm@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v1 7/9] freezer: raise freeze priority of tasks failed to freeze last time Message-ID: <20250808145349.GC21685@redhat.com> References: <20250807121418.139765-1-zhangzihuan@kylinos.cn> <20250807121418.139765-8-zhangzihuan@kylinos.cn> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250807121418.139765-8-zhangzihuan@kylinos.cn> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On 08/07, Zihuan Zhang wrote: > > --- a/kernel/power/process.c > +++ b/kernel/power/process.c > @@ -111,8 +111,10 @@ static int try_to_freeze_tasks(bool user_only) > if (!wakeup || pm_debug_messages_on) { > read_lock(&tasklist_lock); > for_each_process_thread(g, p) { > - if (p != current && freezing(p) && !frozen(p)) > + if (p != current && freezing(p) && !frozen(p)) { > + freeze_set_default_priority(p, FREEZE_PRIORITY_HIGH); > sched_show_task(p); > + } IMO, this change should go into 3/9 to make the intent more clear. Other than that, I leave this series to maintainers and other reviewers. Personally, I am skeptical. Oleg.