[PATCH] vfs: fs/namespace.c: remove ms_flags argument from do_remount

[PATCH] vfs: fs/namespace.c: remove ms_flags argument from do_remount

[Askar Safin]

...because it is not used

Signed-off-by: Askar Safin <safinaskar@zohomail.com>
---
 fs/namespace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index ddfd4457d338..dbc773b36d49 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -3279,7 +3279,7 @@ static int do_reconfigure_mnt(struct path *path, unsigned int mnt_flags)
  * If you've mounted a non-root directory somewhere and want to do remount
  * on it - tough luck.
  */
-static int do_remount(struct path *path, int ms_flags, int sb_flags,
+static int do_remount(struct path *path, int sb_flags,
 		      int mnt_flags, void *data)
 {
 	int err;
@@ -4109,7 +4109,7 @@ int path_mount(const char *dev_name, struct path *path,
 	if ((flags & (MS_REMOUNT | MS_BIND)) == (MS_REMOUNT | MS_BIND))
 		return do_reconfigure_mnt(path, mnt_flags);
 	if (flags & MS_REMOUNT)
-		return do_remount(path, flags, sb_flags, mnt_flags, data_page);
+		return do_remount(path, sb_flags, mnt_flags, data_page);
 	if (flags & MS_BIND)
 		return do_loopback(path, dev_name, flags & MS_REC);
 	if (flags & (MS_SHARED | MS_PRIVATE | MS_SLAVE | MS_UNBINDABLE))
-- 
2.47.2

Re: [PATCH] vfs: fs/namespace.c: remove ms_flags argument from do_remount

[Aleksa Sarai]

[-- Attachment #1: Type: text/plain, Size: 1758 bytes --]

On 2025-08-11, Askar Safin <safinaskar@zohomail.com> wrote:
> ...because it is not used

Doing some spelunking, this usage was removed in commit 43f5e655eff7e,
when David split out the (MS_REMOUNT|MS_BIND) handling. As such, maybe
this deserves a

Fixed: 43f5e655eff7 ("vfs: Separate changing mount flags full remount")

...?

And feel free to take my

Reviewed-by: Aleksa Sarai <cyphar@cyphar.com>

Thanks!

> Signed-off-by: Askar Safin <safinaskar@zohomail.com>
> ---
>  fs/namespace.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/namespace.c b/fs/namespace.c
> index ddfd4457d338..dbc773b36d49 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -3279,7 +3279,7 @@ static int do_reconfigure_mnt(struct path *path, unsigned int mnt_flags)
>   * If you've mounted a non-root directory somewhere and want to do remount
>   * on it - tough luck.
>   */
> -static int do_remount(struct path *path, int ms_flags, int sb_flags,
> +static int do_remount(struct path *path, int sb_flags,
>  		      int mnt_flags, void *data)
>  {
>  	int err;
> @@ -4109,7 +4109,7 @@ int path_mount(const char *dev_name, struct path *path,
>  	if ((flags & (MS_REMOUNT | MS_BIND)) == (MS_REMOUNT | MS_BIND))
>  		return do_reconfigure_mnt(path, mnt_flags);
>  	if (flags & MS_REMOUNT)
> -		return do_remount(path, flags, sb_flags, mnt_flags, data_page);
> +		return do_remount(path, sb_flags, mnt_flags, data_page);
>  	if (flags & MS_BIND)
>  		return do_loopback(path, dev_name, flags & MS_REC);
>  	if (flags & (MS_SHARED | MS_PRIVATE | MS_SLAVE | MS_UNBINDABLE))
> -- 
> 2.47.2
> 
> 

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]

Re: [PATCH] vfs: fs/namespace.c: remove ms_flags argument from do_remount

[Christian Brauner]

On Mon, 11 Aug 2025 04:52:23 +0000, Askar Safin wrote:
> ...because it is not used
> 
> 

Applied to the vfs-6.18.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.18.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.18.misc

[1/1] vfs: fs/namespace.c: remove ms_flags argument from do_remount
      https://git.kernel.org/vfs/vfs/c/59f67bb635a8