From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A05472D23B6 for ; Mon, 11 Aug 2025 11:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754911600; cv=none; b=aiVsft6Ll6WotpZhxUrQ/YwvsOEe72h7D6f2ygTz5ExslmtAZPUTVxIQX+24XAzesG01eBgVTXiAoH7RFYS8JdlcK8bSV1794qfkZTBY4xaFHDKmSFh4w5E9xsCpwPZhoghAnkLexX1mVqlndL0iD0j+AFWgcCpss30rbzXOvzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754911600; c=relaxed/simple; bh=r4Efa03mYkk7DOGkh2EZFFjHiYB++ydzXwMc/S5d8gE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=meQp0ayA81yX5V7/sT3JZDh30rWaVUnsTtOY4ZsykSgcUXqlHkGTsHjiknwih9SBvzfALEqT5Agq4LsVA1OS/tzpukmH1YgJV20wzVazyVzbIStcJL4qu0Fdb0dRW43gHk+2m/rafLbYi/oGwPnkXVFByIUkbs48ZXtlVOENMg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bcz/1JSh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bcz/1JSh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754911597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=gjYKWewbFPIH0RV/ky7WxO7hTalH23xVuPMUQKkA/fk=; b=Bcz/1JSh8L3f0dQykKKuvTOn5L/h2FShn9+U9Risq+E524Lsx0ObXZhiMMZWJ+2gc+w7xU MiU7pESJ4+eOeEPmts5+92tzA1D2Nqord1WsG9JzTo5WB/pNpKeiSnDm1BWqpYSKEF7xO9 oOTanNeKlRl5zW41344rrHkPMSRs5Js= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-gvZNwW8gOkuQ73qsJcp0lQ-1; Mon, 11 Aug 2025 07:26:36 -0400 X-MC-Unique: gvZNwW8gOkuQ73qsJcp0lQ-1 X-Mimecast-MFC-AGG-ID: gvZNwW8gOkuQ73qsJcp0lQ_1754911595 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3b780da0ab6so2167115f8f.0 for ; Mon, 11 Aug 2025 04:26:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754911595; x=1755516395; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gjYKWewbFPIH0RV/ky7WxO7hTalH23xVuPMUQKkA/fk=; b=lSXYLvz0ld0rrl7IlPZAwJdI0EryG0iaMGfJz6bg9Mua45Aao6slg3X+bVtE6ZdN5m EpG6RYUbYIQOySz0W4RCOQ+hU78Jn6D5Tk3TuadNpKqoDUyHJf71xdEKJbbbMPMzlS6m bOzwqoGjSFDccNO8TPWh5GfhPTWDMrWSXGZ3qsNqMScW1r466QKV/TjqxYWrckg2V6KL uVJT4ef9eisYO5K5+Bfgms5vUC27MuHHr/szmeOFD7IiXcEX7oXY+q5yEz4u+dWA8i6F F0NM1cpuz3lpMCkR9E8b3OG2qCy8psQk4fSqPCAEGRZb8XV3ovMw3cwiUZ9GEJ45OaNA oLig== X-Forwarded-Encrypted: i=1; AJvYcCXgA4W9nLx9W0lWU3dbOLzC9/Sn3laaEJO2IRaDi0PUETTaJHUuOalw4W9vnxWJ0YU+rcuwJ2jL7mFJkQlw@vger.kernel.org X-Gm-Message-State: AOJu0YyKmaMWNsjOvk05wijrKRlT3Bmf+L6AJiPygiktCGzkjl/drrhf w3DsF+Yx49EiNN+GLuAHOaGKBPqia2wHB8bCw9PXzv9Fak7J2jmW/w2rUyNGDYG2+U1fDlC0jIk FDfPp6ix43RKQvp/V8mjdyE/zzcm4z1fcDKByBAbPwYjirymLnpsKwqW/l7FjPAOV9hU= X-Gm-Gg: ASbGncsYuaAVACPFWO/hy2SmW24gcQ9NCi79IZxcpb5KCtE+zsDsnZuGMHx4APq3BbO LvgNro05BgeEMfHBSyq/jw3xaAKO7Sri3JUT9VpVy8AlnDu4Vxa+H0EFHavTD95Bq50+RsfHdGJ CkUUpI30b2Qe7GXL9m9TiUOI3N559NX1aatzAdg5hmWQZCMGWy85viwAfsaLAq7KJk6Yq4MS8tC eQNZHF6Tc7tkPl4zEHI3HtEYN2jjkFVPrUxm/njDyoxU+p1O/sqxJxXKFiy6zHXMPah2PI/qERs Fl6OkCpTQpbP19ui0r83H6xVLQFagxafesZZZ/oUW6ZIWT5h/84UemPIWUwdvMYxZAcSR2b0d9t DLlz+jES21e1wGA++7Ar/9Yma X-Received: by 2002:a05:6000:2f85:b0:3b7:8d70:e0ad with SMTP id ffacd0b85a97d-3b900b4d8c1mr8490202f8f.32.1754911594924; Mon, 11 Aug 2025 04:26:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdQyxmL2k0hEit4q6ggWaLK63vDyy/XYp/bptTEvLLiDZ4Kssrq6afY7SHtzCWpxX9HX5tXQ== X-Received: by 2002:a05:6000:2f85:b0:3b7:8d70:e0ad with SMTP id ffacd0b85a97d-3b900b4d8c1mr8490151f8f.32.1754911594303; Mon, 11 Aug 2025 04:26:34 -0700 (PDT) Received: from localhost (p200300d82f06a600a397de1d2f8bb66f.dip0.t-ipconnect.de. [2003:d8:2f06:a600:a397:de1d:2f8b:b66f]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b79c3c4beasm39217323f8f.30.2025.08.11.04.26.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Aug 2025 04:26:33 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, David Hildenbrand , Andrew Morton , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , Pedro Falcato , Hugh Dickins , Oscar Salvador , Lance Yang Subject: [PATCH v3 00/11] mm: vm_normal_page*() improvements Date: Mon, 11 Aug 2025 13:26:20 +0200 Message-ID: <20250811112631.759341-1-david@redhat.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Based on mm/mm-new from today. Cleanup and unify vm_normal_page_*() handling, also marking the huge zerofolio as special in the PMD. Add+use vm_normal_page_pud() and cleanup that XEN vm_ops->find_special_page thingy. There are plans of using vm_normal_page_*() more widely soon. Briefly tested on UML (making sure vm_normal_page() still works as expected without pte_special() support) and on x86-64 with a bunch of tests. Cross-compiled for a variety of weird archs. v2 -> v3: * "mm/huge_memory: mark PMD mappings of the huge zero folio special" -> Extend vm_normal_page_pmd() comment + patch description -> Take care of copy_huge_pmd() checking for pmd_special(). * "powerpc/ptdump: rename "struct pgtable_level" to "struct ptdump_pglevel"" -> Added * "mm/rmap: convert "enum rmap_level" to "enum pgtable_level"" -> Added * "mm/memory: convert print_bad_pte() to print_bad_page_map()" -> Consume level so we can keep the level indication through pgtable_level_to_str(). -> Improve locking comments * "mm/memory: factor out common code from vm_normal_page_*()" -> Factor everything out into __vm_normal_page() and let it consume the special bit + pfn (and the value+level for error reporting purposes) -> Improve function docs -> Improve patch description v1 -> v2: * "mm/memory: convert print_bad_pte() to print_bad_page_map()" -> Don't use pgdp_get(), because it's broken on some arm configs -> Extend patch description -> Don't use pmd_val(pmdp_get()), because that doesn't work on some m68k configs * Added RBs RFC -> v1: * Dropped the highest_memmap_pfn removal stuff and instead added "mm/memory: convert print_bad_pte() to print_bad_page_map()" * Dropped "mm: compare pfns only if the entry is present when inserting pfns/pages" for now, will probably clean that up separately. * Dropped "mm: remove "horrible special case to handle copy-on-write behaviour"", and "mm: drop addr parameter from vm_normal_*_pmd()" will require more thought * "mm/huge_memory: support huge zero folio in vmf_insert_folio_pmd()" -> Extend patch description. * "fs/dax: use vmf_insert_folio_pmd() to insert the huge zero folio" -> Extend patch description. * "mm/huge_memory: mark PMD mappings of the huge zero folio special" -> Remove comment from vm_normal_page_pmd(). * "mm/memory: factor out common code from vm_normal_page_*()" -> Adjust to print_bad_page_map()/highest_memmap_pfn changes. -> Add proper kernel doc to all involved functions * "mm: introduce and use vm_normal_page_pud()" -> Adjust to print_bad_page_map() changes. Cc: Andrew Morton Cc: Madhavan Srinivasan Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: Juergen Gross Cc: Stefano Stabellini Cc: Oleksandr Tyshchenko Cc: Dan Williams Cc: Matthew Wilcox Cc: Jan Kara Cc: Alexander Viro Cc: Christian Brauner Cc: Lorenzo Stoakes Cc: "Liam R. Howlett" Cc: Vlastimil Babka Cc: Mike Rapoport Cc: Suren Baghdasaryan Cc: Michal Hocko Cc: Zi Yan Cc: Baolin Wang Cc: Nico Pache Cc: Ryan Roberts Cc: Dev Jain Cc: Barry Song Cc: Jann Horn Cc: Pedro Falcato Cc: Hugh Dickins Cc: Oscar Salvador Cc: Lance Yang David Hildenbrand (11): mm/huge_memory: move more common code into insert_pmd() mm/huge_memory: move more common code into insert_pud() mm/huge_memory: support huge zero folio in vmf_insert_folio_pmd() fs/dax: use vmf_insert_folio_pmd() to insert the huge zero folio mm/huge_memory: mark PMD mappings of the huge zero folio special powerpc/ptdump: rename "struct pgtable_level" to "struct ptdump_pglevel" mm/rmap: convert "enum rmap_level" to "enum pgtable_level" mm/memory: convert print_bad_pte() to print_bad_page_map() mm/memory: factor out common code from vm_normal_page_*() mm: introduce and use vm_normal_page_pud() mm: rename vm_ops->find_special_page() to vm_ops->find_normal_page() arch/powerpc/mm/ptdump/8xx.c | 2 +- arch/powerpc/mm/ptdump/book3s64.c | 2 +- arch/powerpc/mm/ptdump/ptdump.h | 4 +- arch/powerpc/mm/ptdump/shared.c | 2 +- drivers/xen/Kconfig | 1 + drivers/xen/gntdev.c | 5 +- fs/dax.c | 47 +---- include/linux/mm.h | 20 +- include/linux/pgtable.h | 27 +++ include/linux/rmap.h | 60 +++--- mm/Kconfig | 2 + mm/huge_memory.c | 122 +++++------ mm/memory.c | 332 +++++++++++++++++++++--------- mm/pagewalk.c | 20 +- mm/rmap.c | 56 ++--- tools/testing/vma/vma_internal.h | 18 +- 16 files changed, 421 insertions(+), 299 deletions(-) base-commit: 53c448023185717d0ed56b5546dc2be405da92ff -- 2.50.1