From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: kbusch@kernel.org, hch@lst.de, axboe@kernel.dk,
brauner@kernel.org, josef@toxicpanda.com, jack@suse.cz,
jlayton@kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, gost.dev@samsung.com
Subject: Re: [RFC PATCH 4/5] fs: propagate write stream
Date: Tue, 12 Aug 2025 10:24:04 +0200 [thread overview]
Message-ID: <20250812082404.GD22212@lst.de> (raw)
In-Reply-To: <20250729145135.12463-5-joshi.k@samsung.com>
On Tue, Jul 29, 2025 at 08:21:34PM +0530, Kanchan Joshi wrote:
> bio->bi_write_stream is not set by the filesystem code.
> Use inode's write stream value to do that.
Just passing it through is going to create problems. i.e. when
the file system does it's own placement or reserves ids. We'll need
an explicit intercept point between the user write stream and what
does into the bio.
next prev parent reply other threads:[~2025-08-12 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250729145331epcas5p4821f0ddedbbe425b733bf8330878cb3d@epcas5p4.samsung.com>
2025-07-29 14:51 ` [RFC PATCH 0/5] FDP file I/O Kanchan Joshi
[not found] ` <CGME20250729145333epcas5p49b6374fdedaafc54eb265d38978c1b8c@epcas5p4.samsung.com>
2025-07-29 14:51 ` [RFC PATCH 1/5] fs: add a new user_write_streams() callback Kanchan Joshi
2025-08-12 8:21 ` Christoph Hellwig
[not found] ` <CGME20250729145335epcas5p462315e4dae631a1d940b6c3b2b611659@epcas5p4.samsung.com>
2025-07-29 14:51 ` [RFC PATCH 2/5] fs: add the interface to query user write streams Kanchan Joshi
2025-08-12 8:22 ` Christoph Hellwig
[not found] ` <CGME20250729145337epcas5p42503c4faf59756ac1f3d23423821f73b@epcas5p4.samsung.com>
2025-07-29 14:51 ` [RFC PATCH 3/5] fs: add a write stream field to the inode Kanchan Joshi
2025-08-12 8:23 ` Christoph Hellwig
[not found] ` <CGME20250729145338epcas5p4da42906a341577997f39aa8453252ea3@epcas5p4.samsung.com>
2025-07-29 14:51 ` [RFC PATCH 4/5] fs: propagate write stream Kanchan Joshi
2025-08-12 8:24 ` Christoph Hellwig [this message]
[not found] ` <CGME20250729145340epcas5p162878562c0778b1ee7b9c9bd7d7e6615@epcas5p1.samsung.com>
2025-07-29 14:51 ` [RFC PATCH 5/5] fs: add set and query " Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250812082404.GD22212@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=gost.dev@samsung.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).