From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03F2426D4EF; Tue, 19 Aug 2025 09:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755595750; cv=none; b=Eq3f//rZQ1j/JedtPcR/PZ4JJ7ZCMe3X0OwzNuJ/WG0+054wevgrone/H4hFpPSkntXyE73VPsUKc5t/Oya5/vpGAnRaJaCnJzgEGcM2ArF6tu4hLPqpEheITx++XTN4rWKwdPixbJIrelbLKSgW0PsydnPwiq4alHfJEJM0lQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755595750; c=relaxed/simple; bh=tEc4t+AeYeHjeIn8cFoASltWUSVs0rVeGRrPfy1XwyU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aN+FILZ3ct8voTKb1rpTy34krLnJGlXCMllXgBZeXt8CNHPhRXMsrKedWZPRFJwxVC4eAb52/xjvHq1mMPj6YnKuEC3CzufzhPIPTdmMqFCmc/ZKiD3nrWt2XltGzZj/2ZLctHudUj/kmKG1wvK3dnM9BqPxCdyDremIRz0bwtc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jI4zolhT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jI4zolhT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB091C116B1; Tue, 19 Aug 2025 09:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755595749; bh=tEc4t+AeYeHjeIn8cFoASltWUSVs0rVeGRrPfy1XwyU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jI4zolhTDS/Rb/R6P3zrHxmdDr0MIB2PWBfLJzPrr2YfLXjIacW/uKhVZd2VW5jIE 41jvcd8vK3ygv506FVQxTbVZzWD2suFgOM7FdeeR7hS1kXGqd0mVGWLNhZ3WpZxI0A m1iwQLoBBWG3tMQlHXWpMpOXlQYGt+NH5TBnM6WJoIvnffBtJvWJCsI0NsniO/GwJA s7XAXlhKe4UuE0QhZx6FM+lSD9MsxFuebkUxbS6GmiqlN0HqK5OJoQNNErXqvp4KfK tLs5TrF/Tq4Re1QGNYgNPgPfxwjEHjvbd3t7PNOWeNS0SO45pHu2Bo7nSoJxoLgt0q kSwEHB+95dvwg== Date: Tue, 19 Aug 2025 11:29:04 +0200 From: Christian Brauner To: Andrew Morton Cc: Pankaj Raghav , =?utf-8?B?QW5kcsOp?= Almeida , Christoph Hellwig , Stephen Rothwell , "Darrick J . Wong" , "Pankaj Raghav (Samsung)" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH] iomap: use largest_zero_folio() in iomap_dio_zero() Message-ID: <20250819-benachbarten-bahnnetz-a19e10cd40d2@brauner> References: <20250814142137.45469-1-kernel@pankajraghav.com> <20250815-gauner-brokkoli-1855864a9dff@brauner> <4b225908-f788-413b-ba07-57a0d6012145@igalia.com> <43bca78e-fa89-4b0e-94f1-de7385818950@samsung.com> <20250818201403.33f469f169957d46ef061d52@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250818201403.33f469f169957d46ef061d52@linux-foundation.org> On Mon, Aug 18, 2025 at 08:14:03PM -0700, Andrew Morton wrote: > On Mon, 18 Aug 2025 16:35:04 +0200 Pankaj Raghav wrote: > > > >>> Applied to the vfs-6.18.iomap branch of the vfs/vfs.git tree. > > >>> Patches in the vfs-6.18.iomap branch should appear in linux-next soon. > > >> > > >> Hmm, AFAIK largest_zero_folio just showed up in mm.git a few days ago. > > >> Wouldn't it be better to queue up this change there? > > >> > > >> > > > > > > Indeed, compiling vfs/vfs.all as of today fails with: > > > > > > fs/iomap/direct-io.c:281:36: error: implicit declaration of function > > > ‘largest_zero_folio’; did you mean ‘is_zero_folio’? [-Wimplicit- > > > function-declaration] > > > > > > Reverting "iomap: use largest_zero_folio() in iomap_dio_zero()" fixes > > > the compilation. > > > > > > > I also got some reports from Stephen in linux-next. As Christoph > > suggested, maybe we drop the patches from Christian's tree and queue it > > up via Andrew's tree > > Thanks, I added it to mm.git. Please ask before you move stuff around between trees. You've complained to me before about this before too. I haven't agreed to that at all. There's a bunch more iomap work coming and this will most certainly not start going through mm trees. So if there's merge conflicts where we rely on a helper that's in mm-next the good thing would simply to provide a branch for us with that helper that we can base this off of.