From: Eric Biggers <ebiggers@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Prithvi Tambewagh <activprithvi@gmail.com>,
skhan@linuxfoundation.org, brauner@kernel.org, jack@suse.cz,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: Document 'name' parameter in name_contains_dotdot()
Date: Sat, 23 Aug 2025 21:52:24 -0400 [thread overview]
Message-ID: <20250824015224.GA12644@quark> (raw)
In-Reply-To: <20250824010623.GE39973@ZenIV>
On Sun, Aug 24, 2025 at 02:06:23AM +0100, Al Viro wrote:
> On Sat, Aug 23, 2025 at 07:52:08PM +0530, Prithvi Tambewagh wrote:
> > Add documentation for the 'name' parameter in name_contains_dotdot()
> >
> > Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
>
> Out of curiosity, could you describe the process that has lead to
> that patch?
>
> The reason why I'm asking is that there had been a truly ridiculous
> amount of identical patches, all dealing with exact same function.
>
> Odds of random coincedence are very low - there's quite lot of
> similar places, and AFAICS you are the 8th poster choosing the
> same one.
>
> I would expect that kind of response to a "kernel throws scary
> warnings on boot for reasonably common setups", but for a comment
> about a function being slightly wrong this kind of focus is
> strange.
>
> If that's some AI (s)tool responding to prompts along the lines of
> "I want to fix some kernel problem, find some low-hanging fruit
> and gimme a patch", we might be seeing a small-scale preview of
> a future DDoS with the same underlying mechanism...
You do know that kernel-doc warns about this, right?
$ ./scripts/kernel-doc -v -none include/linux/fs.h
[...]
Warning: include/linux/fs.h:3287 function parameter 'name' not described in 'name_contains_dotdot'
It's the only warning in include/linux/fs.h.
- Eric
next prev parent reply other threads:[~2025-08-24 1:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-23 14:22 [PATCH] fs: Document 'name' parameter in name_contains_dotdot() Prithvi Tambewagh
2025-08-24 1:06 ` Al Viro
2025-08-24 1:52 ` Eric Biggers [this message]
2025-08-24 3:10 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2025-08-19 22:10 [PATCH] fs: document " Jaimin Parmar
2025-08-18 18:26 Shrikant Raskar
2025-08-19 17:15 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250824015224.GA12644@quark \
--to=ebiggers@kernel.org \
--cc=activprithvi@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).