From: Al Viro <viro@zeniv.linux.org.uk>
To: ssranevjti@gmail.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
brauner@kernel.org, jack@suse.cz,
syzbot+0cee785b798102696a4b@syzkaller.appspotmail.com,
Shaurya Rane <ssrane_b23@ee.vjti.ac.in>
Subject: Re: [PATCH] fs/namei: fix WARNING in do_mknodat due to invalid inode unlock
Date: Sun, 24 Aug 2025 20:07:14 +0100 [thread overview]
Message-ID: <20250824190714.GG39973@ZenIV> (raw)
In-Reply-To: <20250824185303.18519-1-ssrane_b23@ee.vjti.ac.in>
On Mon, Aug 25, 2025 at 12:23:03AM +0530, ssranevjti@gmail.com wrote:
> From: Shaurya Rane <ssrane_b23@ee.vjti.ac.in>
>
> The done_path_create() function unconditionally calls inode_unlock() on
> path->dentry->d_inode without verifying that the path and inode are valid.
> Under certain error conditions or race scenarios, this can lead to attempting
> to unlock an inode that was never locked or has been corrupted, resulting in
> a WARNING from the rwsem debugging code.
>
> Add defensive checks to ensure both path->dentry and path->dentry->d_inode
> are valid before attempting to unlock. This prevents the rwsem warning while
> maintaining existing behavior for normal cases.
>
> Reported-by: syzbot+0cee785b798102696a4b@syzkaller.appspotmail.com
No. You are papering over some bugs you have not even bothered to describe -
"certain error conditions or race scenarios" is as useless as it gets.
Don't do that. Fixing a bug found by syzbot is useful; papering over
it does no good whatsoever.
NAK.
next prev parent reply other threads:[~2025-08-24 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 18:53 [PATCH] fs/namei: fix WARNING in do_mknodat due to invalid inode unlock ssranevjti
2025-08-24 19:07 ` Al Viro [this message]
2025-08-24 19:19 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250824190714.GG39973@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssrane_b23@ee.vjti.ac.in \
--cc=ssranevjti@gmail.com \
--cc=syzbot+0cee785b798102696a4b@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).