From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C65DD277017 for ; Mon, 25 Aug 2025 04:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756097041; cv=none; b=HKVT+FuXZbhxh0UMTP0VKKs2H9sxYaaSyTlksPPJVFqOsf51BUUVpJjjhTCH+ekuvkIaYdD3grirvXUb3cCSMKtfePwHwaAPMublICFFamvhvSCk5o2eBD4tFcpZx6c23OQlEx6NotLBYvqDFYiAHAXX6HiVihXvUggxL9Gzfgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756097041; c=relaxed/simple; bh=Rz+uV/3zD+bxP5fS3zT4bvYvcAQUNzWJIhDLT98j8EA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jh4jguKsP+45OqCiiZronotJKsDcUMPJmO+oOqKleihdV95F2AJUvQ9U1eF+1CMx3YSgTCmkirKw+peBOhzg3MDMR5nBLI1Ep4HJhyZYgsWo+xFm/91cU8Id2mQmyXMje1u61Gn0szC/JuGZ0gJNe7ngcul8DM7TwQ0gLVUdmfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=nzbc2Fu2; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="nzbc2Fu2" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=5gaeO5nxhyLdPzjnM1urOt6AoExdUe6qc3DxuNiFto4=; b=nzbc2Fu25IqkSfbe21ZsQveLCD luWQmfZdY9wQGZZr1Y9LTlqvHPk9iaoUGFMWDu8AUPnvG9L26XXhdt4ny4ERRvD04RFTgNc3o3Xb7 6jXHebSXA2h2Gq3sPv5jFy/L96Cd54350w1iR698GEiCVFaUxpIfrVcMtyWXLkviqG0kJGAkp6zZI z9r7VL8sG1EecgR9jhR19FSbtTBh3sn0qUsr4oF6nP1icpJTdTMHP5stZmq1jacr/s30M/gBvRcwC Du7I/jwSE4CSo2PXWbb2ocA6dFxr4TXXdrX6TgH6r4DofCiX3vjC+mDhdzYToFY3O2sl80utNSY80 NrDcdwSQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqP3m-00000006TBC-0Kmg; Mon, 25 Aug 2025 04:43:58 +0000 From: Al Viro To: linux-fsdevel@vger.kernel.org Cc: brauner@kernel.org, jack@suse.cz, torvalds@linux-foundation.org Subject: [PATCH 21/52] finish_automount(): simplify the ELOOP check Date: Mon, 25 Aug 2025 05:43:24 +0100 Message-ID: <20250825044355.1541941-21-viro@zeniv.linux.org.uk> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250825044355.1541941-1-viro@zeniv.linux.org.uk> References: <20250825044046.GI39973@ZenIV> <20250825044355.1541941-1-viro@zeniv.linux.org.uk> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Al Viro It's enough to check that dentries match; if path->dentry is equal to m->mnt_root, superblocks will match as well. Signed-off-by: Al Viro --- fs/namespace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 9e04133d81dd..5c4b4f25b5f8 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -3803,8 +3803,7 @@ int finish_automount(struct vfsmount *m, const struct path *path) mnt = real_mount(m); - if (m->mnt_sb == path->mnt->mnt_sb && - m->mnt_root == dentry) { + if (m->mnt_root == path->dentry) { err = -ELOOP; goto discard; } -- 2.47.2