From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
David Howells <dhowells@redhat.com>,
linux-nfs@vger.kernel.org
Subject: [PATCHES] fs_context stuff
Date: Thu, 28 Aug 2025 01:00:01 +0100 [thread overview]
Message-ID: <20250828000001.GY39973@ZenIV> (raw)
That stuff had been discussed last cycle, didn't make it into
-next back then. If nobody objects, I'm throwing that branch into
#for-next.
vfs_parse_fs_string() calling conventions are inconvenient;
it takes string and length, and just about every caller (with only two
exceptions) passes string, strlen(string).
Proposal: introduce vfs_parse_fs_qstr() for those that want
the generic form (and pass &QSTR_LEN(string, length) as its argument)
and lose the length argument of vfs_parse_fs_string().
Callers are happier that way. The first commit in the series does
the calling convention change and converts existing users; the second one
converts a couple of open-coded vfs_parse_fs_string() in do_nfs4_mount()
to that primitive. A lot more readable that way, IMO...
Branch (-rc1-based) lives in
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git #work.fs_context
Individual patches in followups.
Please, review. If there's no objections, into -next it goes...
Shortlog:
Al Viro (2):
change the calling conventions for vfs_parse_fs_string()
do_nfs4_mount(): switch to vfs_parse_fs_string()
Diffstat:
Documentation/filesystems/mount_api.rst | 10 +++++++-
Documentation/filesystems/porting.rst | 10 ++++++++
drivers/gpu/drm/i915/gem/i915_gemfs.c | 9 ++-----
drivers/gpu/drm/v3d/v3d_gemfs.c | 9 ++-----
fs/afs/mntpt.c | 3 ++-
fs/fs_context.c | 17 ++++++-------
fs/namespace.c | 8 +++---
fs/nfs/fs_context.c | 3 +--
fs/nfs/namespace.c | 3 ++-
fs/nfs/nfs4super.c | 44 +++++++++------------------------
fs/smb/client/fs_context.c | 4 +--
include/linux/fs_context.h | 9 +++++--
kernel/trace/trace.c | 3 +--
13 files changed, 58 insertions(+), 74 deletions(-)
next reply other threads:[~2025-08-28 0:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 0:00 Al Viro [this message]
2025-08-28 0:00 ` [PATCH 1/2] change the calling conventions for vfs_parse_fs_string() Al Viro
2025-08-29 7:47 ` Christian Brauner
2025-08-28 0:01 ` [PATCH 2/2] do_nfs4_mount(): switch to vfs_parse_fs_string() Al Viro
2025-08-29 7:47 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250828000001.GY39973@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).