From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77FC932F754 for ; Wed, 3 Sep 2025 20:02:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756929731; cv=none; b=ZxQnYHZHgc8TMdwZwcCD5XzyC9xoi1mY7UMBNJ32ztm0640yUjAgT4efHiFF77uzjeQQ5bAZGYHCHiQlVBH2gXsvoDVGyMCh7EBfnkTxHNz+F9D7xvQDcShTLIpsjTaQQthsO4ovEbvfWi/kWrOTmVN3CHeN3H7VO2a8q8hehV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756929731; c=relaxed/simple; bh=vxIovzy/iAeQqbzPhYJg0AFSyB2BO7DsqIFM+fM972g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JgMg+D0Fseti+WuPDeb0OnXSEvymJ2teEOFiZhT1iFr1F64av6V4MDmGeQI5VN20YFWAof58PiMk6/pZI4n3u7xAq1vZmtY4EiXQaLBnL9WQ2BlIOi/PT0rJ1u0VNCkKdr12T76fy9f4rEFVLtvBTcAz+Skx6ixFLnTRFTE+yqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hlmrm62D; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hlmrm62D" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4C02C4CEE7; Wed, 3 Sep 2025 20:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756929731; bh=vxIovzy/iAeQqbzPhYJg0AFSyB2BO7DsqIFM+fM972g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hlmrm62Dm7Kb10KfPCz2NQ3cJGKSLS6Uw2ZLxVRDQVXNI7T6s1VuqmrHMgDMZDp1C ReSntuXtFj8H5TXg2208lA6XNAVjer5xvJtTVDS8Xae2EaR98CKufAJVPa/2hUOHmX 1pZYnEFsaR+skYOLDghdMCZOggwOnK2VERCuduhLXvn6N6UCx7Ln46H36H8eXO+Vqg k+vHn0YUSyQzyVU/9cnxqx+uHhTIySua5sMcOJLShXabwOEYG99fjun47GaQW+KhqE qy4+DFgvtZDQ4G/4QjaIfWSbEqXQp6jSKdzYqm0ecUVPiIc8mp5UHUItsDRX4wILR9 bR4OVqUgVkclQ== Date: Wed, 3 Sep 2025 13:02:10 -0700 From: "Darrick J. Wong" To: David Hildenbrand Cc: Joanne Koong , linux-mm@kvack.org, brauner@kernel.org, willy@infradead.org, jack@suse.cz, hch@infradead.org, jlayton@kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v2 01/12] mm: pass number of pages to __folio_start_writeback() Message-ID: <20250903200210.GJ1587915@frogsfrogsfrogs> References: <20250829233942.3607248-1-joannelkoong@gmail.com> <20250829233942.3607248-2-joannelkoong@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Sep 03, 2025 at 01:48:41PM +0200, David Hildenbrand wrote: > On 30.08.25 01:39, Joanne Koong wrote: > > Add an additional arg to __folio_start_writeback() that takes in the > > number of pages to write back. > > Usually we pass something like page+nr_pages so we know the actual range. I > assume here this is not required, because we only care about using the > #pages for accounting purposes, right? I think all the "nr_pages" here are actually the number of dirty pages in the folio, right? Or so I gather since later patches have iomap walking bitmaps to find all the set/clear bits. Perhaps that parameter ought to be called nr_dirty(_pages)? --D > -- > Cheers > > David / dhildenb > >