From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1DBA220696 for ; Fri, 5 Sep 2025 15:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757085771; cv=none; b=ovsP2hKSJx7yC7TxqOLkPNec4j1gSU5b7YL00XBFyRw1CWQ1Jp5XQq2DsJWK20J/nJrhv8OXDhNvYSgKCAw2DcvReBr5CUnveCZp6qA4o1lgxWpsyRLPTSrzRCCGHylVwSlg4z03HqP5FHTf8xEAS+HgysQxwl0zYzDTBpLDyNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757085771; c=relaxed/simple; bh=OZ/Lx1Zz2uWk3zIlBnv9jk4uKCzlbtEu5wmvtgpUwrk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZvWxJTyLfoWp4xNiG8Fv2B23TjkjqAQFeSBDdNaySiEUHwALuylnvcQuiZxVtuWvG39kk03XDiuWNSmaepWHBtFTcQhtXFpo9da3NRAY452HLctGD7VmChL4JK/Kfp4Uplsg35noN3WtTEetdQDaWripumyAJm1o8X6KN3xYn2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L+xvrC8h; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L+xvrC8h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4446BC4CEF1; Fri, 5 Sep 2025 15:22:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757085771; bh=OZ/Lx1Zz2uWk3zIlBnv9jk4uKCzlbtEu5wmvtgpUwrk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L+xvrC8h/4E42eRYdHpUrFLDAtT7lqukS2N+ggvqcK1v6OIQL/ahytVS/RDSyITK/ B09QcqBCKgnnRwGpAgHppsSqM5rVnzG5GLjeJOsZv+hZhPehPQxIyoFmDrkZcwQb6D TPBn3vQjJP5n2ChS8gEoRLujXcC4N9HGW6aCRAkhFh78F2MJeIVoZEZQDBMC/xJAy5 e/wmY9xwIweoFbBCl/Lb9mdhZGtfLoEdc1JqI5fWMGwFDLkOqL0mpNA4ya4B8kbuah hVndpGhOeAQ7q6w+9ZmJMCicoY2qtflNpDbzEHtMGfUkPiH+TiL2KIdgEhukMA8PBr Vv1W1irU9Ne9Q== Date: Fri, 5 Sep 2025 08:22:50 -0700 From: "Darrick J. Wong" To: Miklos Szeredi Cc: bernd@bsbernd.com, neal@gompa.dev, John@groves.net, linux-fsdevel@vger.kernel.org, joannelkoong@gmail.com Subject: Re: [PATCH 4/7] fuse: implement file attributes mask for statx Message-ID: <20250905152250.GF1587915@frogsfrogsfrogs> References: <175573708630.15537.1057407663556817922.stgit@frogsfrogsfrogs> <20250829153938.GA8088@frogsfrogsfrogs> <20250902205736.GB1587915@frogsfrogsfrogs> <20250903154955.GD1587915@frogsfrogsfrogs> <20250905012854.GA1587915@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Sep 05, 2025 at 09:02:05AM +0200, Miklos Szeredi wrote: > On Fri, 5 Sept 2025 at 03:28, Darrick J. Wong wrote: > > > > On Thu, Sep 04, 2025 at 01:26:36PM +0200, Miklos Szeredi wrote: > > > On Wed, 3 Sept 2025 at 17:49, Darrick J. Wong wrote: > > > > > > > > On Wed, Sep 03, 2025 at 11:55:25AM +0200, Miklos Szeredi wrote: > > > > > > > > Agree? > > > > > > > > I think we do, except maybe the difficult first point. :) > > > > > > Let's then defer the LOOKUPX thing ;) I'm fine with adding IMMUTABLE > > > and APPEND to fuse_attr::flags. > > > > OK. Should I hide that behind the fuse mount having iomap turned on? > > Or fc->is_local_fs == true? Or let any server set those bits? > > > > One thing occurred to me -- for a plain old fuse server that is the > > client for some network filesystem, the other end might have its own > > immutable/append bits, in which case we actually *do* want to let those > > bits through from the FUSE_STATX replies. > > Right, as I said this might have worked without VFS help, but having > it consistently in the VFS as well would be nicer. > > In that spirit, putting those bits in the inode is safe only in the > local fs case, so I guess that's what we should do. And for > consistency, in the local fs case inode->flags should be the > authoritative source and all the userspace API's should be looking at > that, instead of what the server sent in the IOCTL or STATX replies. Ok, I'll meld that all together today. --D > Thanks, > Miklos >