From: Al Viro <viro@zeniv.linux.org.uk>
To: NeilBrown <neilb@ownmail.net>
Cc: Christian Brauner <brauner@kernel.org>,
Amir Goldstein <amir73il@gmail.com>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/6] fs/proc: Don't look root inode when creating "self" and "thread-self"
Date: Sat, 6 Sep 2025 06:52:40 +0100 [thread overview]
Message-ID: <20250906055240.GT39973@ZenIV> (raw)
In-Reply-To: <20250906055005.GS39973@ZenIV>
On Sat, Sep 06, 2025 at 06:50:05AM +0100, Al Viro wrote:
> On Sat, Sep 06, 2025 at 02:57:05PM +1000, NeilBrown wrote:
> > From: NeilBrown <neil@brown.name>
> >
> > proc_setup_self() and proc_setup_thread_self() are only called from
> > proc_fill_super() which is before the filesystem is "live". So there is
> > no need to lock the root directory when adding "self" and "thread-self".
> >
> > The locking rules are expected to change, so this locking will become
> > anachronistic if we don't remove it.
>
> Please, leave that one alone. FWIW, in tree-in-dcache branch (will push
> tomorrow or on Sunday, once I sort the fucking #work.f_path out) there's
> this:
PS: you do realize that we have similar things in devpts, binder, functionfs,
etc., right? What's special about procfs?
next prev parent reply other threads:[~2025-09-06 5:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 4:57 [PATCH 0/6] VFS: more prep for change to directory locking NeilBrown
2025-09-06 4:57 ` [PATCH 1/6] fs/proc: Don't look root inode when creating "self" and "thread-self" NeilBrown
2025-09-06 5:50 ` Al Viro
2025-09-06 5:52 ` Al Viro [this message]
2025-09-06 6:08 ` NeilBrown
2025-09-06 4:57 ` [PATCH 2/6] VFS/ovl: add lookup_one_positive_killable() NeilBrown
2025-09-06 9:44 ` Amir Goldstein
2025-09-08 2:07 ` NeilBrown
2025-09-08 7:09 ` Amir Goldstein
2025-09-09 2:14 ` NeilBrown
2025-09-06 4:57 ` [PATCH 3/6] VFS: discard err2 in filename_create() NeilBrown
2025-09-06 4:57 ` [PATCH 4/6] VFS: unify old_mnt_idmap and new_mnt_idmap in renamedata NeilBrown
2025-09-15 12:10 ` Christian Brauner
2025-09-19 22:54 ` NeilBrown
2025-09-19 23:17 ` Al Viro
2025-09-19 23:44 ` NeilBrown
2025-09-06 4:57 ` [PATCH 5/6] VFS/audit: introduce kern_path_parent() for audit NeilBrown
2025-09-07 2:17 ` kernel test robot
2025-09-06 4:57 ` [PATCH 6/6] VFS: rename kern_path_locked() to kern_path_removing() NeilBrown
2025-09-06 9:09 ` Amir Goldstein
2025-09-06 9:29 ` NeilBrown
2025-09-06 10:35 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250906055240.GT39973@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neilb@ownmail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).