From: Andrey Albershteyn <aalbersh@redhat.com>
To: aalbersh@kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org
Cc: "Darrick J. Wong" <djwong@kernel.org>
Subject: [PATCH v3 v3 4/4] xfs_db: use file_setattr to copy attributes on special files with rdump
Date: Tue, 09 Sep 2025 17:24:39 +0200 [thread overview]
Message-ID: <20250909-xattrat-syscall-v3-4-4407a714817e@kernel.org> (raw)
In-Reply-To: <20250909-xattrat-syscall-v3-0-4407a714817e@kernel.org>
rdump just skipped file attributes on special files as copying wasn't
possible. Let's use new file_getattr/file_setattr syscalls to copy
attributes even for special files.
Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
---
db/rdump.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/db/rdump.c b/db/rdump.c
index 9ff833553ccb..82520e37d713 100644
--- a/db/rdump.c
+++ b/db/rdump.c
@@ -17,6 +17,7 @@
#include "field.h"
#include "inode.h"
#include "listxattr.h"
+#include "libfrog/file_attr.h"
#include <sys/xattr.h>
#include <linux/xattr.h>
@@ -152,6 +153,12 @@ rdump_fileattrs_path(
const struct destdir *destdir,
const struct pathbuf *pbuf)
{
+ struct file_attr fa = {
+ .fa_extsize = ip->i_extsize,
+ .fa_projid = ip->i_projid,
+ .fa_cowextsize = ip->i_cowextsize,
+ .fa_xflags = xfs_ip2xflags(ip),
+ };
int ret;
ret = fchmodat(destdir->fd, pbuf->path, VFS_I(ip)->i_mode & ~S_IFMT,
@@ -181,7 +188,18 @@ rdump_fileattrs_path(
return 1;
}
- /* Cannot copy fsxattrs until setfsxattrat gets merged */
+ ret = xfrog_file_setattr(destdir->fd, pbuf->path, NULL, &fa,
+ AT_SYMLINK_NOFOLLOW);
+ if (ret) {
+ if (errno == EOPNOTSUPP || errno == EPERM || errno == ENOTTY)
+ lost_mask |= LOST_FSXATTR;
+ else
+ dbprintf(_("%s%s%s: xfrog_file_setattr %s\n"),
+ destdir->path, destdir->sep, pbuf->path,
+ strerror(errno));
+ if (strict_errors)
+ return 1;
+ }
return 0;
}
--
2.50.1
next prev parent reply other threads:[~2025-09-09 15:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 15:22 Tests for file_getattr()/file_setattr() and xfsprogs update Andrey Albershteyn
2025-09-09 15:24 ` [PATCH v3 0/4] xfsprogs: utilize file_getattr() and file_setattr() Andrey Albershteyn
2025-09-09 15:24 ` [PATCH v3 v3 1/4] libfrog: add wrappers for file_getattr/file_setattr syscalls Andrey Albershteyn
2025-09-12 23:38 ` Darrick J. Wong
2025-09-09 15:24 ` [PATCH v3 v3 2/4] xfs_quota: utilize file_setattr to set prjid on special files Andrey Albershteyn
2025-09-12 23:38 ` Darrick J. Wong
2025-09-09 15:24 ` [PATCH v3 v3 3/4] xfs_io: make ls/chattr work with " Andrey Albershteyn
2025-09-09 15:24 ` Andrey Albershteyn [this message]
2025-09-09 15:25 ` [PATCH v3 0/3] Test file_getattr and file_setattr syscalls Andrey Albershteyn
2025-09-09 15:25 ` [PATCH v3 1/3] file_attr: introduce program to set/get fsxattr Andrey Albershteyn
2025-09-12 23:39 ` Darrick J. Wong
2025-09-09 15:25 ` [PATCH v3 2/3] generic: introduce test to test file_getattr/file_setattr syscalls Andrey Albershteyn
2025-09-23 16:09 ` Andrey Albershteyn
2025-09-09 15:25 ` [PATCH v3 3/3] xfs: test quota's project ID on special files Andrey Albershteyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909-xattrat-syscall-v3-4-4407a714817e@kernel.org \
--to=aalbersh@redhat.com \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).