From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F194E2D1F64 for ; Mon, 15 Sep 2025 08:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757924096; cv=none; b=N0nxD0d8Zo57isdICnTWQFdQBacwAXuYhCVGl7rwi7A6lsk1cg85itNX3pMpI72H+RkITQz8fdoqIqIIzNl8RUrNFktZ7AZ4NYcumKrPVB3Rv9yBPrkyvH+vaLEueCIhr31Iv2ScU0EGf2WepZmGRC7Xf0EY0bFmDSQdjlGy+lA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757924096; c=relaxed/simple; bh=deJY1b9TWxN7bxAyrceEcgEUmvcwqV8/tbUprds4akI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TjkmkDI4uIG5Lu0JlK48+f/jfsJtzEaYyo13KC9MrWp6I7od+U/8+kMNt5xpBuZsT8mJl4QFrA97e0cwz79lHwG45pp995h5gUYAcFKvdQtU3MJRZp7XW4i8/+Y5skSkbz8hpXx3XHtt6lbbg+yWvFaqL6LqQjM4HkfJZfu69F4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=fLEzUF3S; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=WhForuUw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=fLEzUF3S; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=WhForuUw; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="fLEzUF3S"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="WhForuUw"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="fLEzUF3S"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="WhForuUw" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 332221F821; Mon, 15 Sep 2025 08:14:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1757924093; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YGy0rfdSRjLJPpgGFILAlv/48JaKsrMZ18rxppBWgPo=; b=fLEzUF3SFRbMwOfmLkqeV9pe8sbX3A3lB39Yo3RrSdU8Blv/NV+2QNUXJDhaKXZzKXJ5e5 I5DEzPgwNLBChq1/q/fD86GnecXfmroRe8a6Hmhz6KXbEOafs4WMfXVKB8V328N0Pqh866 VwW/E6rPVWqYo0K/PYcvEquZuLFE0i0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1757924093; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YGy0rfdSRjLJPpgGFILAlv/48JaKsrMZ18rxppBWgPo=; b=WhForuUwl8lPZHxbv1oL3ag44IUcWYWhDOlIy08GdKLHBEswynXn3YI+vkQAis+hwyODat yBEoRnN7bkE3rYCQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1757924093; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YGy0rfdSRjLJPpgGFILAlv/48JaKsrMZ18rxppBWgPo=; b=fLEzUF3SFRbMwOfmLkqeV9pe8sbX3A3lB39Yo3RrSdU8Blv/NV+2QNUXJDhaKXZzKXJ5e5 I5DEzPgwNLBChq1/q/fD86GnecXfmroRe8a6Hmhz6KXbEOafs4WMfXVKB8V328N0Pqh866 VwW/E6rPVWqYo0K/PYcvEquZuLFE0i0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1757924093; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YGy0rfdSRjLJPpgGFILAlv/48JaKsrMZ18rxppBWgPo=; b=WhForuUwl8lPZHxbv1oL3ag44IUcWYWhDOlIy08GdKLHBEswynXn3YI+vkQAis+hwyODat yBEoRnN7bkE3rYCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 06AFA1368D; Mon, 15 Sep 2025 08:14:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BQ+ELPnKx2hKYwAAD6G6ig (envelope-from ); Mon, 15 Sep 2025 08:14:49 +0000 Date: Mon, 15 Sep 2025 18:14:40 +1000 From: David Disseldorp To: Geert Uytterhoeven Cc: Andrew Morton , Martin Wilck , Alexander Viro , Christian Brauner , Jan Kara , Askar Safin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] init: INITRAMFS_PRESERVE_MTIME should depend on BLK_DEV_INITRD Message-ID: <20250915181440.1e52a824.ddiss@suse.de> In-Reply-To: <9a65128514408dc7de64cf4fea75c1a8342263ea.1757920006.git.geert+renesas@glider.be> References: <9a65128514408dc7de64cf4fea75c1a8342263ea.1757920006.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-1.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[renesas]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[linux-foundation.org,suse.com,zeniv.linux.org.uk,kernel.org,suse.cz,gmail.com,vger.kernel.org]; RCPT_COUNT_SEVEN(0.00)[9]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[] X-Spam-Flag: NO X-Spam-Level: X-Spam-Score: -1.80 On Mon, 15 Sep 2025 09:11:05 +0200, Geert Uytterhoeven wrote: > INITRAMFS_PRESERVE_MTIME is only used in init/initramfs.c and > init/initramfs_test.c. Hence add a dependency on BLK_DEV_INITRD, to > prevent asking the user about this feature when configuring a kernel > without initramfs support. > > Fixes: 1274aea127b2e8c9 ("initramfs: add INITRAMFS_PRESERVE_MTIME Kconfig option") > Signed-off-by: Geert Uytterhoeven Makes sense, thanks. Reviewed-by: David Disseldorp