From: Al Viro <viro@zeniv.linux.org.uk>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: slava.dubeyko@ibm.com, xiubli@redhat.com, idryomov@gmail.com,
amarkuze@redhat.com, ceph-devel@vger.kernel.org,
netfs@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Mateusz Guzik <mjguzik@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] ceph: fix deadlock bugs by making iput() calls asynchronous
Date: Wed, 17 Sep 2025 21:20:33 +0100 [thread overview]
Message-ID: <20250917202033.GY39973@ZenIV> (raw)
In-Reply-To: <20250917135907.2218073-1-max.kellermann@ionos.com>
On Wed, Sep 17, 2025 at 03:59:07PM +0200, Max Kellermann wrote:
> After advice from Mateusz Guzik, I decided to do the latter. The
> implementation is simple because it piggybacks on the existing
> work_struct for ceph_queue_inode_work() - ceph_inode_work() calls
> iput() at the end which means we can donate the last reference to it.
>
> This patch adds ceph_iput_async() and converts lots of iput() calls to
> it - at least those that may come through writeback and the messenger.
What would force those delayed calls through at fs shutdown time?
next prev parent reply other threads:[~2025-09-17 20:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 13:59 [PATCH v2] ceph: fix deadlock bugs by making iput() calls asynchronous Max Kellermann
2025-09-17 14:12 ` Mateusz Guzik
2025-09-17 17:55 ` Viacheslav Dubeyko
2025-09-17 19:06 ` Max Kellermann
2025-09-17 19:20 ` Viacheslav Dubeyko
2025-09-17 19:25 ` Max Kellermann
2025-09-17 19:33 ` Viacheslav Dubeyko
2025-09-17 20:20 ` Al Viro [this message]
2025-09-17 20:25 ` Max Kellermann
2025-09-17 20:27 ` Max Kellermann
2025-09-18 4:52 ` Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917202033.GY39973@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=mjguzik@gmail.com \
--cc=netfs@lists.linux.dev \
--cc=slava.dubeyko@ibm.com \
--cc=stable@vger.kernel.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).