From: Al Viro <viro@zeniv.linux.org.uk>
To: NeilBrown <neil@brown.name>
Cc: Christian Brauner <brauner@kernel.org>,
Amir Goldstein <amir73il@gmail.com>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 4/6] VFS: unify old_mnt_idmap and new_mnt_idmap in renamedata
Date: Sat, 20 Sep 2025 00:17:08 +0100 [thread overview]
Message-ID: <20250919231708.GJ39973@ZenIV> (raw)
In-Reply-To: <175832247637.1696783.9988129598384346049@noble.neil.brown.name>
On Sat, Sep 20, 2025 at 08:54:36AM +1000, NeilBrown wrote:
> On Mon, 15 Sep 2025, Christian Brauner wrote:
> > On Sat, Sep 06, 2025 at 02:57:08PM +1000, NeilBrown wrote:
> > > From: NeilBrown <neil@brown.name>
> > >
> > > A rename can only rename within a single mount. Callers of vfs_rename()
> > > must and do ensure this is the case.
> > >
> > > So there is no point in having two mnt_idmaps in renamedata as they are
> > > always the same. Only one of them is passed to ->rename in any case.
> > >
> > > This patch replaces both with a single "mnt_idmap" and changes all
> > > callers.
> > >
> > > Reviewed-by: Jeff Layton <jlayton@kernel.org>
> > > Signed-off-by: NeilBrown <neil@brown.name>
> > > ---
> >
> > Hah, thanks. I'm stealing this now.
> >
>
> I was hoping you would steal the whole series - v3 of it.
>
> https://lore.kernel.org/all/20250915021504.2632889-1-neilb@ownmail.net/
>
> Is there anything preventing that going into vfs.all now?
1/6, perhaps?
next prev parent reply other threads:[~2025-09-19 23:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 4:57 [PATCH 0/6] VFS: more prep for change to directory locking NeilBrown
2025-09-06 4:57 ` [PATCH 1/6] fs/proc: Don't look root inode when creating "self" and "thread-self" NeilBrown
2025-09-06 5:50 ` Al Viro
2025-09-06 5:52 ` Al Viro
2025-09-06 6:08 ` NeilBrown
2025-09-06 4:57 ` [PATCH 2/6] VFS/ovl: add lookup_one_positive_killable() NeilBrown
2025-09-06 9:44 ` Amir Goldstein
2025-09-08 2:07 ` NeilBrown
2025-09-08 7:09 ` Amir Goldstein
2025-09-09 2:14 ` NeilBrown
2025-09-06 4:57 ` [PATCH 3/6] VFS: discard err2 in filename_create() NeilBrown
2025-09-06 4:57 ` [PATCH 4/6] VFS: unify old_mnt_idmap and new_mnt_idmap in renamedata NeilBrown
2025-09-15 12:10 ` Christian Brauner
2025-09-19 22:54 ` NeilBrown
2025-09-19 23:17 ` Al Viro [this message]
2025-09-19 23:44 ` NeilBrown
2025-09-06 4:57 ` [PATCH 5/6] VFS/audit: introduce kern_path_parent() for audit NeilBrown
2025-09-07 2:17 ` kernel test robot
2025-09-06 4:57 ` [PATCH 6/6] VFS: rename kern_path_locked() to kern_path_removing() NeilBrown
2025-09-06 9:09 ` Amir Goldstein
2025-09-06 9:29 ` NeilBrown
2025-09-06 10:35 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919231708.GJ39973@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neil@brown.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).