From: Al Viro <viro@zeniv.linux.org.uk>
To: Paul Moore <paul@paul-moore.com>
Cc: linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org,
brauner@kernel.org, jack@suse.cz, kees@kernel.org,
casey@schaufler-ca.com, linux-security-module@vger.kernel.org,
john.johansen@canonical.com
Subject: Re: [PATCH 31/39] convert selinuxfs
Date: Sun, 21 Sep 2025 22:41:10 +0100 [thread overview]
Message-ID: <20250921214110.GN39973@ZenIV> (raw)
In-Reply-To: <CAHC9VhTRsQtncKx4bkbkSqVXpZyQLHbvKkcaVO-ss21Fq36r+Q@mail.gmail.com>
On Sun, Sep 21, 2025 at 04:44:28PM -0400, Paul Moore wrote:
> > + dput(dentry);
> > + return dentry; // borrowed
> > }
>
> Prefer C style comments on their own line:
>
> dput(dentry);
> /* borrowed dentry */
> return dentry;
Umm... IMO that's more of an annotation along the lines of "fallthru"...
> > @@ -2079,15 +2088,14 @@ static int sel_fill_super(struct super_block *sb, struct fs_context *fc)
> > goto err;
> > }
> >
> > - fsi->policycap_dir = sel_make_dir(sb->s_root, POLICYCAP_DIR_NAME,
> > + dentry = sel_make_dir(sb->s_root, POLICYCAP_DIR_NAME,
> > &fsi->last_ino);
>
> I'd probably keep fsi->policycap_dir in this patch simply to limit the
> scope of this patch to just the DCACHE_PERSISTENT related changes, but
> I'm not going to make a big fuss about that.
Not hard to split that way. Will do...
BTW, an unrelated question: does userland care about selinuxfs /null being
called that (and being on selinuxfs, for that matter)? Same for the
apparmor's securityfs /apparmor/.null...
If nobody cares, I would rather add an internal-only filesystem with
root being a character device (1,3) and whatever markings selinux et.al.
need for it. With open_devnull(creds) provided for selinux,
apparmor and whoever else wants to play with neutering descriptors
on exec...
next prev parent reply other threads:[~2025-09-21 21:41 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 7:41 [PATCHES][RFC] the meat of tree-in-dcache series Al Viro
2025-09-20 7:47 ` [PATCH 01/39] new helper: simple_remove_by_name() Al Viro
2025-09-20 7:47 ` [PATCH 02/39] new helper: simple_done_creating() Al Viro
2025-09-20 7:47 ` [PATCH 03/39] introduce a flag for explicitly marking persistently pinned dentries Al Viro
2025-09-20 7:47 ` [PATCH 04/39] primitives for maintaining persisitency Al Viro
2025-09-20 7:47 ` [PATCH 05/39] convert simple_{link,unlink,rmdir,rename,fill_super}() to new primitives Al Viro
2025-09-20 7:47 ` [PATCH 06/39] convert ramfs and tmpfs Al Viro
2025-09-20 7:47 ` [PATCH 07/39] procfs: make /self and /thread_self dentries persistent Al Viro
2025-09-20 7:47 ` [PATCH 08/39] configfs, securityfs: kill_litter_super() not needed Al Viro
2025-09-24 16:56 ` Joel Becker
2025-09-20 7:47 ` [PATCH 09/39] convert xenfs Al Viro
2025-09-20 7:47 ` [PATCH 10/39] convert smackfs Al Viro
2025-09-22 15:11 ` Casey Schaufler
2025-09-20 7:47 ` [PATCH 11/39] convert hugetlbfs Al Viro
2025-09-20 7:47 ` [PATCH 12/39] convert mqueue Al Viro
2025-09-20 7:47 ` [PATCH 13/39] convert bpf Al Viro
2025-09-20 7:47 ` [PATCH 14/39] convert dlmfs Al Viro
2025-09-20 7:47 ` [PATCH 15/39] convert fuse_ctl Al Viro
2025-09-20 7:47 ` [PATCH 16/39] convert pstore Al Viro
2025-09-20 7:47 ` [PATCH 17/39] convert tracefs Al Viro
2025-09-20 7:47 ` [PATCH 18/39] convert debugfs Al Viro
2025-09-23 8:10 ` Greg KH
2025-09-20 7:47 ` [PATCH 19/39] debugfs: remove duplicate checks in callers of start_creating() Al Viro
2025-09-23 8:10 ` Greg KH
2025-09-20 7:47 ` [PATCH 20/39] convert efivarfs Al Viro
2025-09-20 7:47 ` [PATCH 21/39] convert spufs Al Viro
2025-09-20 7:47 ` [PATCH 22/39] convert ibmasmfs Al Viro
2025-09-20 7:47 ` [PATCH 23/39] ibmasmfs: get rid of ibmasmfs_dir_ops Al Viro
2025-09-20 7:47 ` [PATCH 24/39] convert devpts Al Viro
2025-09-20 7:47 ` [PATCH 25/39] binderfs: use simple_start_creating() Al Viro
2025-09-20 7:47 ` [PATCH 26/39] binderfs_binder_ctl_create(): kill a bogus check Al Viro
2025-09-20 7:47 ` [PATCH 27/39] convert binderfs Al Viro
2025-09-20 7:47 ` [PATCH 28/39] autofs_{rmdir,unlink}: dentry->d_fsdata->dentry == dentry there Al Viro
2025-09-20 7:47 ` [PATCH 29/39] convert autofs Al Viro
2025-09-20 7:47 ` [PATCH 30/39] convert binfmt_misc Al Viro
2025-09-20 7:47 ` [PATCH 31/39] convert selinuxfs Al Viro
2025-09-21 20:44 ` Paul Moore
2025-09-21 21:41 ` Al Viro [this message]
2025-09-22 2:45 ` Paul Moore
2025-09-22 12:34 ` Stephen Smalley
2025-09-22 13:46 ` Al Viro
2025-09-22 21:12 ` John Johansen
2025-09-21 22:26 ` Al Viro
2025-09-22 2:50 ` Paul Moore
2025-09-22 3:52 ` Al Viro
2025-09-20 7:47 ` [PATCH 32/39] functionfs: switch to simple_remove_by_name() Al Viro
2025-09-20 7:47 ` [PATCH 33/39] convert functionfs Al Viro
2025-09-20 7:47 ` [PATCH 34/39] gadgetfs: switch to simple_remove_by_name() Al Viro
2025-09-20 7:47 ` [PATCH 35/39] convert gadgetfs Al Viro
2025-09-20 7:47 ` [PATCH 36/39] hypfs: don't pin dentries twice Al Viro
2025-09-20 7:47 ` [PATCH 37/39] hypfs: switch hypfs_create_str() to returning int Al Viro
2025-09-20 7:47 ` [PATCH 38/39] hypfs: swich hypfs_create_u64() " Al Viro
2025-09-20 7:47 ` [PATCH 39/39] convert hypfs Al Viro
2025-09-20 16:26 ` [PATCHES][RFC] the meat of tree-in-dcache series Linus Torvalds
2025-09-20 18:09 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250921214110.GN39973@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=jack@suse.cz \
--cc=john.johansen@canonical.com \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).