linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: NeilBrown <neil@brown.name>
Cc: Christian Brauner <brauner@kernel.org>,
	Amir Goldstein <amir73il@gmail.com>,
	Jeff Layton <jlayton@kernel.org>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4 5/6] VFS: rename kern_path_locked() and related functions.
Date: Mon, 22 Sep 2025 06:21:00 +0100	[thread overview]
Message-ID: <20250922052100.GQ39973@ZenIV> (raw)
In-Reply-To: <20250922043121.193821-6-neilb@ownmail.net>

On Mon, Sep 22, 2025 at 02:29:52PM +1000, NeilBrown wrote:
> From: NeilBrown <neil@brown.name>
> 
> kern_path_locked() is now only used to prepare for removing an object
> from the filesystem (and that is the only credible reason for wanting a
> positive locked dentry).  Thus it corresponds to kern_path_create() and
> so should have a corresponding name.
> 
> Unfortunately the name "kern_path_create" is somewhat misleading as it
> doesn't actually create anything.  The recently added
> simple_start_creating() provides a better pattern I believe.  The
> "start" can be matched with "end" to bracket the creating or removing.
> 
> So this patch changes names:
> 
>  kern_path_locked -> start_removing_path
>  kern_path_create -> start_creating_path
>  user_path_create -> start_creating_user_path
>  user_path_locked_at -> start_removing_user_path_at
>  done_path_create -> end_creating_path
> 
> and also introduces end_removing_path() which is identical to
> end_creating_path().
> 
> __start_removing_path (which was __kern_path_locked) is enhanced to
> call mnt_want_write() for consistency with the start_creating_path().

Documentation/filesystems/porting.rst, please.  Either in this commit,
or as a followup.

  reply	other threads:[~2025-09-22  5:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22  4:29 NeilBrown
2025-09-22  4:29 ` [PATCH v4 1/6] VFS/ovl: add lookup_one_positive_killable() NeilBrown
2025-09-23 10:39   ` Christian Brauner
2025-09-22  4:29 ` [PATCH v4 2/6] VFS: discard err2 in filename_create() NeilBrown
2025-09-22  4:29 ` [PATCH v4 3/6] VFS: unify old_mnt_idmap and new_mnt_idmap in renamedata NeilBrown
2025-09-22  4:29 ` [PATCH v4 4/6] VFS/audit: introduce kern_path_parent() for audit NeilBrown
2025-09-22  4:29 ` [PATCH v4 5/6] VFS: rename kern_path_locked() and related functions NeilBrown
2025-09-22  5:21   ` Al Viro [this message]
2025-09-22  7:30     ` NeilBrown
2025-09-22 13:32       ` Al Viro
2025-09-23 10:40         ` Christian Brauner
2025-09-22  4:29 ` [PATCH v4 6/6] debugfs: rename start_creating() to debugfs_start_creating() NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250922052100.GQ39973@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=neil@brown.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).