From: "Darrick J. Wong" <djwong@kernel.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Joanne Koong <joannelkoong@gmail.com>,
brauner@kernel.org, hch@infradead.org,
linux-block@vger.kernel.org, gfs2@lists.linux.dev,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-doc@vger.kernel.org, hsiangkao@linux.alibaba.com,
kernel-team@meta.com
Subject: Re: [PATCH v4 13/15] fuse: use iomap for read_folio
Date: Tue, 23 Sep 2025 10:21:28 -0700 [thread overview]
Message-ID: <20250923172128.GD1587915@frogsfrogsfrogs> (raw)
In-Reply-To: <CAJfpegsBRg6hozmZ1-kfYaOTjn3HYcYMJrGVE_z-gtqXWbT_=w@mail.gmail.com>
On Tue, Sep 23, 2025 at 05:39:13PM +0200, Miklos Szeredi wrote:
> On Tue, 23 Sept 2025 at 02:34, Joanne Koong <joannelkoong@gmail.com> wrote:
>
> > static int fuse_read_folio(struct file *file, struct folio *folio)
> > {
> > struct inode *inode = folio->mapping->host;
> > - int err;
> > + struct fuse_fill_read_data data = {
> > + .file = file,
> > + };
> > + struct iomap_read_folio_ctx ctx = {
> > + .cur_folio = folio,
> > + .ops = &fuse_iomap_read_ops,
> > + .read_ctx = &data,
> >
> > - err = -EIO;
> > - if (fuse_is_bad(inode))
> > - goto out;
> > + };
> >
> > - err = fuse_do_readfolio(file, folio, 0, folio_size(folio));
> > - if (!err)
> > - folio_mark_uptodate(folio);
> > + if (fuse_is_bad(inode)) {
> > + folio_unlock(folio);
> > + return -EIO;
> > + }
> >
> > + iomap_read_folio(&fuse_iomap_ops, &ctx);
>
> Why is the return value ignored?
There is no return value:
https://lore.kernel.org/linux-fsdevel/20250923002353.2961514-13-joannelkoong@gmail.com/T/#u
Errors get set on the file/mapping/sb, nobody checks the return value
of ->read_folio.
--D
> Thanks,
> Miklos
>
next prev parent reply other threads:[~2025-09-23 17:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 0:23 [PATCH v4 00/15] fuse: use iomap for buffered reads + readahead Joanne Koong
2025-09-23 0:23 ` [PATCH v4 01/15] iomap: move bio read logic into helper function Joanne Koong
2025-09-23 0:23 ` [PATCH v4 02/15] iomap: move read/readahead bio submission " Joanne Koong
2025-09-23 0:23 ` [PATCH v4 03/15] iomap: store read/readahead bio generically Joanne Koong
2025-09-23 0:23 ` [PATCH v4 04/15] iomap: iterate over folio mapping in iomap_readpage_iter() Joanne Koong
2025-09-23 0:23 ` [PATCH v4 05/15] iomap: rename iomap_readpage_iter() to iomap_read_folio_iter() Joanne Koong
2025-09-23 0:23 ` [PATCH v4 06/15] iomap: rename iomap_readpage_ctx struct to iomap_read_folio_ctx Joanne Koong
2025-09-23 0:23 ` [PATCH v4 07/15] iomap: track read/readahead folio ownership internally Joanne Koong
2025-09-24 0:13 ` Darrick J. Wong
2025-09-23 0:23 ` [PATCH v4 08/15] iomap: add public start/finish folio read helpers Joanne Koong
2025-09-23 0:23 ` [PATCH v4 09/15] iomap: add caller-provided callbacks for read and readahead Joanne Koong
2025-09-24 0:26 ` Darrick J. Wong
2025-09-24 18:18 ` Joanne Koong
2025-09-23 0:23 ` [PATCH v4 10/15] iomap: add bias for async read requests Joanne Koong
2025-09-24 0:28 ` Darrick J. Wong
2025-09-24 18:23 ` Joanne Koong
2025-09-23 0:23 ` [PATCH v4 11/15] iomap: move buffered io bio logic into new file Joanne Koong
2025-09-23 0:23 ` [PATCH v4 12/15] iomap: make iomap_read_folio() a void return Joanne Koong
2025-09-23 0:23 ` [PATCH v4 13/15] fuse: use iomap for read_folio Joanne Koong
2025-09-23 15:39 ` Miklos Szeredi
2025-09-23 17:21 ` Darrick J. Wong [this message]
2025-09-23 0:23 ` [PATCH v4 14/15] fuse: use iomap for readahead Joanne Koong
2025-09-23 0:23 ` [PATCH v4 15/15] fuse: remove fc->blkbits workaround for partial writes Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923172128.GD1587915@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=brauner@kernel.org \
--cc=gfs2@lists.linux.dev \
--cc=hch@infradead.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=joannelkoong@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).