Re: [PATCH 1/1] libfuse: don't put HAVE_STATX in a public header

Darrick J. Wong
2025-09-16T16:16:02Z

On Tue, Sep 16, 2025 at 02:38:07PM +0000, Bernd Schubert wrote:
> On 9/16/25 02:41, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > fuse.h and fuse_lowlevel.h are public headers, don't expose internal
> > build system config variables to downstream clients. This can also lead
> > to function pointer ordering issues if (say) libfuse gets built with
> > HAVE_STATX but the client program doesn't define a HAVE_STATX.
> >
> > Get rid of the conditionals in the public header files to fix this.
>
> Thank you, PR with an updated commit message and removal of HAVE_STATX
> from the public libfuse_config.h created here
> https://github.com/libfuse/libfuse/pull/1333

That looks reasonable, thanks for picking this up. :)

--D