Re: [PATCH 2/2] iomap: error out on file IO when there is no inline_data buffer

Darrick J. Wong
2025-09-16T14:50:56Z

On Tue, Sep 16, 2025 at 06:50:27AM -0700, Christoph Hellwig wrote:
> > + if (WARN_ON_ONCE(iomap->inline_data == NULL))
>
> Shorten this to just !iomap->inline_data instead of checking for NULL?
>
> Same for the other two.
>
> Otherwise this looks good, and I'd prefer to see it go upstream ASAP
> instead of hiding it in your big patch pile if possible.

Ok. Will fix and resend as an independent series.

--D