From: Al Viro <viro@zeniv.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org,
Deepanshu Kartikey <kartikey406@gmail.com>,
syzbot+1d79ebe5383fc016cf07@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH] vfs: Don't leak disconnected dentries on umount
Date: Thu, 2 Oct 2025 17:36:49 +0100 [thread overview]
Message-ID: <20251002163649.GO39973@ZenIV> (raw)
In-Reply-To: <20251002155506.10755-2-jack@suse.cz>
On Thu, Oct 02, 2025 at 05:55:07PM +0200, Jan Kara wrote:
> diff --git a/fs/dcache.c b/fs/dcache.c
> index 65cc11939654..3ec21f9cedba 100644
> --- a/fs/dcache.c
> +++ b/fs/dcache.c
> @@ -2557,6 +2557,8 @@ struct dentry *d_alloc_parallel(struct dentry *parent,
> spin_lock(&parent->d_lock);
> new->d_parent = dget_dlock(parent);
> hlist_add_head(&new->d_sib, &parent->d_children);
> + if (parent->d_flags & DCACHE_DISCONNECTED)
> + new->d_flags |= DCACHE_DISCONNECTED;
> spin_unlock(&parent->d_lock);
Not a good place for that |=, IMO...
next prev parent reply other threads:[~2025-10-02 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 15:55 [PATCH] vfs: Don't leak disconnected dentries on umount Jan Kara
2025-10-02 16:36 ` Al Viro [this message]
2025-10-03 13:33 ` Jan Kara
2025-10-07 11:09 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251002163649.GO39973@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=kartikey406@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+1d79ebe5383fc016cf07@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).