From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 206021E9B0D; Mon, 13 Oct 2025 14:48:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760366917; cv=none; b=IhWeF1L20a7sIYEp4XIyFlbY9LVv0bGFJmi/O9FYHAzLWG3tVK6TX8bUA1U2PDZlpExXbN0v56xfZaYcf7JZKECU/a3vVTrz6YsRnYk4bGs1Rv/K895WBOMUML4aBrJD2Uhn+KyMcwO8TgLpESoF/FhGzbSXb0II46zRPsBERL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760366917; c=relaxed/simple; bh=D4Q1z5eeaVUO9Z+ECTf/6Zqc/vYd4ncdAUbJ5tZDhnY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C7Qj7IUcCmKnQ13uwaRo0CSY88fGuMkp2S8wK6yBEIO412GdZpZ1PIBpQIZ1s/Si3yc7Sg3pvqDGZuSj+JJ6W+wFB/xiV9e9R/+hXek4r00+fdyjikTtmQN36N7qdP6ldggzfYqtCe7/+Mzd7us+BU0Wz33Th7+DE4ItAzvzeQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JfL9FY07; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JfL9FY07" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79124C113D0; Mon, 13 Oct 2025 14:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760366916; bh=D4Q1z5eeaVUO9Z+ECTf/6Zqc/vYd4ncdAUbJ5tZDhnY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JfL9FY07R2Mh4tOb+lcOkKBeKVADGuZNXDO7OXsCYqmmjkCgCjmHloBV7bgJsDPpf CEvNTdN6THsqg7azapM+eqp+l2kUnQbOcTS7T1EH7MqHtRyZA/z+/U8p0ekcnDg+2v iE8n5/TthVtHWVR8TrgmDd3vXpMxnKiDXRXnF/+vYCJQ7HdIR4BldUaEQSiol85gah 2S8AdC0KYn6XLnvpOlxfRo6powC733dFLmj/Kbc03Y4to7RjqbuQ+gNySExv2bW5/I z4PnjfNRNMFheMh7FBBbynukLwz0bhhWivHr1l8nTzGUkTkmhu2cJgL93MtTybX8/4 kNBuelTrEtx7A== From: Jeff Layton Date: Mon, 13 Oct 2025 10:48:04 -0400 Subject: [PATCH 06/13] vfs: break parent dir delegations in open(..., O_CREAT) codepath Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251013-dir-deleg-ro-v1-6-406780a70e5e@kernel.org> References: <20251013-dir-deleg-ro-v1-0-406780a70e5e@kernel.org> In-Reply-To: <20251013-dir-deleg-ro-v1-0-406780a70e5e@kernel.org> To: Miklos Szeredi , Alexander Viro , Christian Brauner , Jan Kara , Chuck Lever , Alexander Aring , Trond Myklebust , Anna Schumaker , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , David Howells , Tyler Hicks , NeilBrown , Olga Kornievskaia , Dai Ngo , Amir Goldstein , Namjae Jeon , Steve French , Sergey Senozhatsky , Carlos Maiolino , Kuniyuki Iwashima , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, netfs@lists.linux.dev, ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, netdev@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2938; i=jlayton@kernel.org; h=from:subject:message-id; bh=D4Q1z5eeaVUO9Z+ECTf/6Zqc/vYd4ncdAUbJ5tZDhnY=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBo7RErwqx3LlOE+U0VGrXGQHDV3voPg/0wc/+aj Jux5LApcN6JAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaO0RKwAKCRAADmhBGVaC FfidD/48/7/CVhQirrZb/jlRR0g9ThXDJbv6PoXlePNXWN/sCyolLMVStN+yxhBVwIkIgLhgvCw OYl2EmAe2KiauHQIkj86+IJvfsBa16kmnzK8gddwBmhh4+To62UaLL8fuJh/Hn9DdFG3uQD0JfO uOETKsvK9pz3P+FiZTsftXNOSsH5xezYTWLHzs2ll+Fg0AyfEfVfXBcZSLtzWzT5P4hVUw74n/6 GuP+N396MaOD1LIrh6WttjNJkdPfVh1WRAQSjk4S5R5trpfmz6Rmq/JsRxIBDczp2CMw2dvUK7t Y2rPjy23LkE7fIlK5AVmKrqNcgtbI2W1KiVUS31Ru8F4e24LHJf2MbcMLTuL25iU1xXj6q94O2C 5Yl+kmpbN16voAZFuPsaH+B1klOVVcXa/cnSdCV84FAlI+1dIo2T0o2Je05Qjy3dmOMLLPziEwG KqtYF1IGJ6kJmcKDnSrUeRAFR6CwdYJOQn/I5wrR0KNKWSC1iWkERpSg518rGo6ovNqNt6w85Cz aMHtwj6omHeGx7iN63vRU5ig3gFBJAerC6rtO1ZYmaFvJesbutE2VqqCqz7QWwDUopm6wcilznr 56bO+rYVEzcEepKersOhqa/i15BGcbpT/2Cg3LdzzP4elhN5BOSSzAN1gR8E7ZfDyONY5SVGKDs xwrmPl0WYjmx1eQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 In order to add directory delegation support, we need to break delegations on the parent whenever there is going to be a change in the directory. Add a delegated_inode parameter to lookup_open and have it break the delegation. Then, open_last_lookups can wait for the delegation break and retry the call to lookup_open once it's done. Signed-off-by: Jeff Layton --- fs/namei.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 4b5a99653c558397e592715d9d4663cd4a63ef86..786f42bd184b5dbf6d754fa1fb6c94c0f75429f2 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3697,7 +3697,7 @@ static struct dentry *atomic_open(struct nameidata *nd, struct dentry *dentry, */ static struct dentry *lookup_open(struct nameidata *nd, struct file *file, const struct open_flags *op, - bool got_write) + bool got_write, struct inode **delegated_inode) { struct mnt_idmap *idmap; struct dentry *dir = nd->path.dentry; @@ -3786,6 +3786,11 @@ static struct dentry *lookup_open(struct nameidata *nd, struct file *file, /* Negative dentry, just create the file */ if (!dentry->d_inode && (open_flag & O_CREAT)) { + /* but break the directory lease first! */ + error = try_break_deleg(dir_inode, delegated_inode); + if (error) + goto out_dput; + file->f_mode |= FMODE_CREATED; audit_inode_child(dir_inode, dentry, AUDIT_TYPE_CHILD_CREATE); if (!dir_inode->i_op->create) { @@ -3849,6 +3854,7 @@ static const char *open_last_lookups(struct nameidata *nd, struct file *file, const struct open_flags *op) { struct dentry *dir = nd->path.dentry; + struct inode *delegated_inode = NULL; int open_flag = op->open_flag; bool got_write = false; struct dentry *dentry; @@ -3879,7 +3885,7 @@ static const char *open_last_lookups(struct nameidata *nd, return ERR_PTR(-ECHILD); } } - +retry: if (open_flag & (O_CREAT | O_TRUNC | O_WRONLY | O_RDWR)) { got_write = !mnt_want_write(nd->path.mnt); /* @@ -3892,7 +3898,7 @@ static const char *open_last_lookups(struct nameidata *nd, inode_lock(dir->d_inode); else inode_lock_shared(dir->d_inode); - dentry = lookup_open(nd, file, op, got_write); + dentry = lookup_open(nd, file, op, got_write, &delegated_inode); if (!IS_ERR(dentry)) { if (file->f_mode & FMODE_CREATED) fsnotify_create(dir->d_inode, dentry); @@ -3907,8 +3913,16 @@ static const char *open_last_lookups(struct nameidata *nd, if (got_write) mnt_drop_write(nd->path.mnt); - if (IS_ERR(dentry)) + if (IS_ERR(dentry)) { + if (delegated_inode) { + int error = break_deleg_wait(&delegated_inode); + + if (!error) + goto retry; + return ERR_PTR(error); + } return ERR_CAST(dentry); + } if (file->f_mode & (FMODE_OPENED | FMODE_CREATED)) { dput(nd->path.dentry); -- 2.51.0