From: hch <hch@lst.de>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: hch <hch@lst.de>, "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Josef Bacik <josef@toxicpanda.com>, Jan Kara <jack@suse.cz>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"v9fs@lists.linux.dev" <v9fs@lists.linux.dev>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"jfs-discussion@lists.sourceforge.net"
<jfs-discussion@lists.sourceforge.net>,
"ocfs2-devel@lists.linux.dev" <ocfs2-devel@lists.linux.dev>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 04/10] btrfs: use the local tmp_inode variable in start_delalloc_inodes
Date: Tue, 14 Oct 2025 06:44:21 +0200 [thread overview]
Message-ID: <20251014044421.GA30920@lst.de> (raw)
In-Reply-To: <aae79ea0-f056-4da7-8a87-4d4fd6aea85f@wdc.com>
On Mon, Oct 13, 2025 at 08:11:35AM +0000, Johannes Thumshirn wrote:
> If you have to repost this for some reason, can you rename tmp_inode to
> vfs_inode or sth like that?
>
> The name is really confusing and the commit introducing it doesn't
> describe it really either.
It is. vfs_inode is kinda weird, too. The problem is that inode
is used for the btrfs_inode. But if there's consensus on a name
I'll happily change it.
next prev parent reply other threads:[~2025-10-14 4:44 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 2:57 filemap_* writeback interface cleanups Christoph Hellwig
2025-10-13 2:57 ` [PATCH 01/10] mm: don't opencode filemap_fdatawrite_range in filemap_invalidate_inode Christoph Hellwig
2025-10-13 7:41 ` Damien Le Moal
2025-10-13 11:32 ` Jan Kara
2025-10-13 12:46 ` David Hildenbrand
2025-10-13 2:57 ` [PATCH 02/10] 9p: don't opencode filemap_fdatawrite_range in v9fs_mmap_vm_close Christoph Hellwig
2025-10-13 7:42 ` Damien Le Moal
2025-10-13 11:33 ` Jan Kara
2025-10-13 2:57 ` [PATCH 03/10] ocfs2: don't opencode filemap_fdatawrite_range in ocfs2_journal_submit_inode_data_buffers Christoph Hellwig
2025-10-13 7:43 ` Damien Le Moal
2025-10-13 8:59 ` Joseph Qi
2025-10-13 11:34 ` Jan Kara
2025-10-13 2:57 ` [PATCH 04/10] btrfs: use the local tmp_inode variable in start_delalloc_inodes Christoph Hellwig
2025-10-13 7:48 ` Damien Le Moal
2025-10-13 8:11 ` Johannes Thumshirn
2025-10-14 4:44 ` hch [this message]
2025-10-14 7:02 ` Johannes Thumshirn
2025-10-14 17:37 ` David Sterba
2025-10-13 2:58 ` [PATCH 05/10] btrfs: push struct writeback_control into start_delalloc_inodes Christoph Hellwig
2025-10-13 7:55 ` Damien Le Moal
2025-10-13 8:15 ` Daniel Vacek
2025-10-13 8:19 ` Damien Le Moal
2025-10-13 2:58 ` [PATCH 06/10] mm,btrfs: add a filemap_fdatawrite_kick_nr helper Christoph Hellwig
2025-10-13 8:01 ` Damien Le Moal
2025-10-13 11:58 ` Jan Kara
2025-10-14 4:47 ` Christoph Hellwig
2025-10-14 9:33 ` Jan Kara
2025-10-14 20:45 ` Dave Chinner
2025-10-13 12:48 ` David Hildenbrand
2025-10-14 4:49 ` Christoph Hellwig
2025-10-14 11:04 ` David Hildenbrand
2025-10-13 2:58 ` [PATCH 07/10] mm: remove __filemap_fdatawrite Christoph Hellwig
2025-10-13 8:02 ` Damien Le Moal
2025-10-14 4:52 ` Christoph Hellwig
2025-10-13 11:59 ` Jan Kara
2025-10-14 4:53 ` Christoph Hellwig
2025-10-14 9:37 ` Jan Kara
2025-10-13 2:58 ` [PATCH 08/10] mm: remove filemap_fdatawrite_wbc Christoph Hellwig
2025-10-13 8:05 ` Damien Le Moal
2025-10-13 12:00 ` Jan Kara
2025-10-13 12:50 ` David Hildenbrand
2025-10-13 2:58 ` [PATCH 09/10] mm: remove __filemap_fdatawrite_range Christoph Hellwig
2025-10-13 8:09 ` Damien Le Moal
2025-10-13 12:03 ` Jan Kara
2025-10-13 2:58 ` [PATCH 10/10] mm: rename filemap_flush to filemap_fdatawrite_kick Christoph Hellwig
2025-10-13 8:14 ` Damien Le Moal
2025-10-13 8:23 ` Damien Le Moal
2025-10-13 8:12 ` filemap_* writeback interface cleanups Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014044421.GA30920@lst.de \
--to=hch@lst.de \
--cc=Johannes.Thumshirn@wdc.com \
--cc=asmadeus@codewreck.org \
--cc=brauner@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=ericvh@kernel.org \
--cc=jack@suse.cz \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlbec@evilplan.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
--cc=v9fs@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).