From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: "Christoph Hellwig" <hch@infradead.org>,
"André Almeida" <andrealmeid@igalia.com>,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-dev@igalia.com, "Miklos Szeredi" <miklos@szeredi.hu>,
"Amir Goldstein" <amir73il@gmail.com>, "Chris Mason" <clm@fb.com>,
"David Sterba" <dsterba@suse.com>,
"Anand Jain" <anand.jain@oracle.com>,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>
Subject: Re: [RFC PATCH 1/1] ovl: Use fsid as unique identifier for trusted origin
Date: Tue, 14 Oct 2025 19:40:32 +0200 [thread overview]
Message-ID: <20251014174032.GC13776@suse.cz> (raw)
In-Reply-To: <fe7201ac-e066-4ac5-8fa1-8c470195248b@suse.com>
On Tue, Oct 14, 2025 at 03:43:54PM +1030, Qu Wenruo wrote:
> 在 2025/10/14 15:09, Christoph Hellwig 写道:
> > On Mon, Oct 13, 2025 at 10:57:07PM -0300, André Almeida wrote:
> >> Some filesystem have non-persistent UUIDs, that can change between
> >> mounting, even if the filesystem is not modified. To prevent
> >> false-positives when mounting overlayfs with index enabled, use the fsid
> >> reported from statfs that is persistent across mounts.
> >
> > Please fix btrfs to not change uuids, as that completely defeats the
> > point of uuids.
> >
>
> That is the temp-fsid feature from Anand, introduced by commit
> a5b8a5f9f835 ("btrfs: support cloned-device mount capability").
>
> I'm not 100% sure if it's really that important to support mounting
> cloned devices in the first place, as LVM will reject activating any LVs
> if there is even conflicting VGs names, not to mention conflicting UUIDs.
>
> If temp-fsid is causing problems with overlayfs, I'm happy to remove it,
> as this really looks like a niche that no one is asking.
What do you mean no one asking? This was specifically asked for by
Steam to do A/B root partition mounts for recovery. It is a niche use
case but it has its users.
next prev parent reply other threads:[~2025-10-14 17:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 1:57 [RFC PATCH 0/1] ovl: brtfs' temp_fsid doesn't work with ovl index=on André Almeida
2025-10-14 1:57 ` [RFC PATCH 1/1] ovl: Use fsid as unique identifier for trusted origin André Almeida
2025-10-14 4:39 ` Christoph Hellwig
2025-10-14 5:13 ` Qu Wenruo
2025-10-14 17:40 ` David Sterba [this message]
2025-10-14 17:55 ` André Almeida
2025-10-14 23:46 ` Anand Jain
2025-10-15 1:22 ` Christoph Hellwig
2025-10-20 21:43 ` Dave Chinner
2025-10-21 1:16 ` Anand Jain
2025-10-15 10:52 ` Amir Goldstein
2025-10-14 5:26 ` [RFC PATCH 0/1] ovl: brtfs' temp_fsid doesn't work with ovl index=on Qu Wenruo
2025-10-14 18:24 ` David Sterba
2025-10-14 21:08 ` Qu Wenruo
2025-10-15 0:05 ` Anand Jain
2025-10-15 4:18 ` Qu Wenruo
2025-10-14 22:04 ` Anand Jain
2025-10-15 11:09 ` Amir Goldstein
2025-10-16 4:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014174032.GC13776@suse.cz \
--to=dsterba@suse.cz \
--cc=amir73il@gmail.com \
--cc=anand.jain@oracle.com \
--cc=andrealmeid@igalia.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=gpiccoli@igalia.com \
--cc=hch@infradead.org \
--cc=kernel-dev@igalia.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).