From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CAA31E500C; Wed, 15 Oct 2025 17:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760550333; cv=none; b=KOnMX+bN2MraJRkKv8ydmpQVKaS/oJn6kHnm4VavEzp4PErSg9JtZMahJQrXYt2U3Zar+e8wlpcBeehPWEYYnNTmzpk+Ti6CkJt0ve9Cr1eBQU5I+9MW4g0aI+jQpF7Gk/zbMeZjJFP5EgJF1T720aaGosJRJU5Syd9s/liELU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760550333; c=relaxed/simple; bh=5VHnaFTpOmXDgy5oJBc19Z3MpdZcEDhISNLaPukOCR8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H5WYckXPehSHCvxcobmHB8v5R6vB5pyoCKGNKxL9unfCxitBROCPBrWr9aAdHEU+8JP6ffYIYsx4KVdfeAtYaUl+8JclZUokeVl43JOw4G1fikwbixLnlIX8puHiiSzhwYY/3vjx7l3thC7OvPZihVwUkF0kztNg4V8jaUYS6zA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N/RcjmU6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N/RcjmU6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED4E7C4CEF9; Wed, 15 Oct 2025 17:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760550333; bh=5VHnaFTpOmXDgy5oJBc19Z3MpdZcEDhISNLaPukOCR8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N/RcjmU6U3xHv5IG9fAqgE5OPWOpFIbVfHky25FpJ8LpZf0sj/n8MBAWJjmY2IA7B H8qTdkyrCxoB5YIWqYSRJVYZ/yNMkLKjYX3B3sjDkmJQJSTxe/j6aYMZWImzVV5yPF A1OjnK88AxE20+Ydhq8DRdmxsSqfVQZ8aSGyhtH3btSKu7vdjbrucVQzn6smzG5NG0 0PsUVhvDy/qIyUZj/ECYPzKHJ4Rg4OGT8I7ocb+WaebWlkw5GEK0c6eVJD1ZvJdkVo 5Op+W7Udwe4joTth8Hm8AjfUk37XsOMON87ZCHNDCL7dkzBfbzrLXsVoXoif9+XJUA Rj8QJij0Ugn0A== Date: Wed, 15 Oct 2025 10:45:32 -0700 From: "Darrick J. Wong" To: "Kirill A. Shutemov" Cc: akpm@linux-foundation.org, linux-mm , linux-fsdevel , xfs , Matthew Wilcox Subject: Re: Regression in generic/749 with 8k fsblock size on 6.18-rc1 Message-ID: <20251015174532.GB6188@frogsfrogsfrogs> References: <20251014175214.GW6188@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Oct 15, 2025 at 08:39:53AM +0100, Kirill A. Shutemov wrote: > On Tue, Oct 14, 2025, at 18:52, Darrick J. Wong wrote: > > Did your testing also demonstrate this regression? > > I have not reproduced the issue yet. > > Could you check if this patch makes a difference: > > https://gist.github.com/kiryl/a2c71057bec332240216cc425aca791a Yes, it does make the test failure go away: FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 alder-mtr00 6.18.0-rc1-xfsx #rc1 SMP PREEMPT_DYNAMIC Wed Oct 15 10:34:11 PDT 2025 MKFS_OPTIONS -- -f -b size=8192, /dev/sdf MOUNT_OPTIONS -- -o uquota,gquota,pquota, /dev/sdf /opt generic/749 9s Ran: generic/749 Passed all 1 tests Is it valid to i_size_read() in the two places you add them? I /think/ the folio is locked in the filemap.c hunk. I'm not as sure about the finish_fault changes. If the EOF folio's locked then I think it's the case that anything trying to change the file size will block until the folio lock drops. Thanks for your help, in any case :) --D > -- > Kiryl Shutsemau / Kirill A. Shutemov >