From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3E72320CCA; Fri, 17 Oct 2025 10:09:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760695763; cv=none; b=qSKLbxuu+clzQcZ00rOBTFhQnlLgk3/LR40j3PGXvDBA2bOhU8oeGGRuiunjyjZhCaB2otnUhffN4Dt2bTwA3fBcSt+vfem5e5fjU6ZTCLZAYGUXhcrpmhVhN7bkjzbdZrT/Uj63o76TrAJLkTHDG9p059LWvGiQL3HzfUOONeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760695763; c=relaxed/simple; bh=JB1wWLqgBD068mwsnwSg83owykU7Yonrry4abca5MAE=; h=Message-ID:From:To:Cc:Subject:References:MIME-Version: Content-Type:Date; b=ontSjJ3myHddHelJVzf1p2JpR1wcqhWfAspnH9gPTgAwwiHPh740JPHuaqarpvTjPTR6yiAe8QmZACUKBgaV0k2dp9vOXiZDDjbFhc4o8Aht9m2SfY+EI9Wt1Iqdss98JtmbDAN6xEeR65zhpVHZltN6oP7irvpJL53zktuF//M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=C9k9phXB; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=NqCfqZvI; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="C9k9phXB"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="NqCfqZvI" Message-ID: <20251017093030.570048808@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1760695759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=pR7+HoSAZ5DPHGbJNIgf4IBT7k17Ap8Nygw2CprMOJk=; b=C9k9phXBv3eSc0l2GIAi2J0FDFvKBMovIjwdFiDy0e0i1kEvIzJQWQtsVykSYWQA3zjanX qK3FqAmeA4xpyNd7UTfXnUV56EjTSIUeQtC9nFHZEArPQ/fbOm6glmVPTvfaVQoaS64AGl c0H5PbeukmuOWNI3zg7uznrWybvjBa9ctDylchNsPz63c2AcGkhbqt2XawHnh2gquvGOiY QZ6/TwVeXt4VR/n2CM0osByZwoQCPo5GbmlRV84rc5i3dXEBh5eUrp9liWqkWxgX8mlObi ABikS60oKdGSbS6eP+JMOOnnRu35rw9ZacukDYaMdGK1k0mW/MewxBrep5VpHQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1760695759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=pR7+HoSAZ5DPHGbJNIgf4IBT7k17Ap8Nygw2CprMOJk=; b=NqCfqZvIshq24z2AZVleQwm35Sz2Df1iT0581FbObZM20gQEQEv4ZdvC1q1Mdnah93RMie jPyBo6i+7usluCDg== From: Thomas Gleixner To: LKML Cc: Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, kernel test robot , Russell King , linux-arm-kernel@lists.infradead.org, Linus Torvalds , x86@kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Heiko Carstens , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org, Mathieu Desnoyers , Andrew Cooper , Julia Lawall , Nicolas Palix , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?q?Andr=C3=A9=20Almeida?= Subject: [patch V3 12/12] select: Convert to scoped masked user access References: <20251017085938.150569636@linutronix.de> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Fri, 17 Oct 2025 12:09:18 +0200 (CEST) From: Thomas Gleixner Replace the open coded implementation with the scoped masked user access guard. No functional change intended. Signed-off-by: Thomas Gleixner Cc: Alexander Viro Cc: Christian Brauner Cc: Jan Kara Cc: linux-fsdevel@vger.kernel.org --- V3: Adopt to scope changes --- fs/select.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) --- --- a/fs/select.c +++ b/fs/select.c @@ -776,17 +776,13 @@ static inline int get_sigset_argpack(str { // the path is hot enough for overhead of copy_from_user() to matter if (from) { - if (can_do_masked_user_access()) - from = masked_user_access_begin(from); - else if (!user_read_access_begin(from, sizeof(*from))) - return -EFAULT; - unsafe_get_user(to->p, &from->p, Efault); - unsafe_get_user(to->size, &from->size, Efault); - user_read_access_end(); + scoped_masked_user_rw_access(from, Efault) { + unsafe_get_user(to->p, &from->p, Efault); + unsafe_get_user(to->size, &from->size, Efault); + } } return 0; Efault: - user_read_access_end(); return -EFAULT; }