From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9CE0286D4E; Sat, 18 Oct 2025 19:17:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760815021; cv=none; b=LFJ944f4CIwthrsi1/b4XlbErMioFQqTzPXqWeiXBgmfLczxPMoymmuj3vNXqvELuqh9NhDvjjCclxtcastbZLctPzUGz8zS8FNBIG9GV6dHVufUg/Vg7DWNKj0ArI6D4CRxCDfbh8dgFpJjwfVCPVILyyzK8A9SNpGlaAaqSQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760815021; c=relaxed/simple; bh=zq8ZZSTx0wtDZS7p9V2Exh4y8hukG/w63T6kuwqnzpg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QggkD7TprsiO6+x3lQ4hVq3m6k3FlNik9ff1r7o9YE2GLY15um1EmJHe9QaKW/q14LZ0y5qkqfA/4354kyOgtSV2mdLklpSXyfrherJEllHuG7bxQRxpsl1vsBWKMltTVDgEE8qpZm+e/ykX1Ok9dud9wHq4aeVwNigcwiBCqnI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sF/dDnzQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sF/dDnzQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D56A0C4CEF9; Sat, 18 Oct 2025 19:16:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760815020; bh=zq8ZZSTx0wtDZS7p9V2Exh4y8hukG/w63T6kuwqnzpg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=sF/dDnzQ1AW/O0adrL/uV/vdvHsxlZ8JyvLE8P88l9AyFnkwySyXL5v7kXg/Ei1bG EEUiBtaVPCxpg8ZWDDMWc8MxlTb+OjuUwEW3kiYwwCfY77CmFI3ou4cfwBoECfNZH8 poMWJK4bzO47uK7d71Ch0GzkvU6AaMCqxRFS9F6K7yGoUUze+nuCZbiZGUORZciLy5 iL9gemKlRo3MaYhBaxBbCsYJuvVqqnosnVYkiKwo+/hjTyuPaTZDnmtGPVdOg9hp5o +/UzrDgTg2Wa6IbzvOxtHwwXYCpyg1JRrxmPDoyiMdtkt36aFXwCqzko3ckRx52Pc1 h3lX2850d+b7A== From: Tamir Duberstein Date: Sat, 18 Oct 2025 15:16:26 -0400 Subject: [RESEND PATCH v18 05/16] rnull: use `kernel::fmt` Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251018-cstr-core-v18-5-9378a54385f8@gmail.com> References: <20251018-cstr-core-v18-0-9378a54385f8@gmail.com> In-Reply-To: <20251018-cstr-core-v18-0-9378a54385f8@gmail.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , =?utf-8?q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Jens Axboe , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Viresh Kumar , Nishanth Menon , Stephen Boyd , Breno Leitao , Liam Girdwood , Mark Brown , Michael Turquette , David Airlie , Simona Vetter , Luis Chamberlain , Russ Weight , Alexander Viro , Jan Kara , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, llvm@lists.linux.dev, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1760814988; l=1568; i=tamird@gmail.com; h=from:subject:message-id; bh=/cgHz1cX/7pqPCiwokdGYY23t2YMKDX7WgaCRbImZEk=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QJ/PmevHPhp8DzRHsrzWbU8v0C6eSwUNwuXLLqBbMrJ4kdfHBVHJwHSm0CqHi8vBvyTw3Nam4DI U+boko+GNOg4= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc From: Tamir Duberstein Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. This backslid in commit d969d504bc13 ("rnull: enable configuration via `configfs`") and commit 34585dc649fb ("rnull: add soft-irq completion support"). Acked-by: Andreas Hindborg Signed-off-by: Tamir Duberstein --- drivers/block/rnull/configfs.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/block/rnull/configfs.rs b/drivers/block/rnull/configfs.rs index 8498e9bae6fd..6713a6d92391 100644 --- a/drivers/block/rnull/configfs.rs +++ b/drivers/block/rnull/configfs.rs @@ -1,12 +1,13 @@ // SPDX-License-Identifier: GPL-2.0 use super::{NullBlkDevice, THIS_MODULE}; -use core::fmt::{Display, Write}; use kernel::{ block::mq::gen_disk::{GenDisk, GenDiskBuilder}, c_str, configfs::{self, AttributeOperations}, - configfs_attrs, new_mutex, + configfs_attrs, + fmt::{self, Write as _}, + new_mutex, page::PAGE_SIZE, prelude::*, str::{kstrtobool_bytes, CString}, @@ -99,8 +100,8 @@ fn try_from(value: u8) -> Result { } } -impl Display for IRQMode { - fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result { +impl fmt::Display for IRQMode { + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { match self { Self::None => f.write_str("0")?, Self::Soft => f.write_str("1")?, -- 2.51.1