From: Christian Brauner <brauner@kernel.org>
To: ecryptfs@vger.kernel.org, linux-crypto@vger.kernel.org,
Eric Biggers <ebiggers@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>,
Tyler Hicks <code@tyhicks.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ecryptfs: Use MD5 library instead of crypto_shash
Date: Tue, 21 Oct 2025 14:59:52 +0200 [thread overview]
Message-ID: <20251021-implosion-ambivalent-bfc95c0b3c5e@brauner> (raw)
In-Reply-To: <20251011200010.193140-1-ebiggers@kernel.org>
On Sat, 11 Oct 2025 13:00:10 -0700, Eric Biggers wrote:
> eCryptfs uses MD5 for a couple unusual purposes: to "mix" the key into
> the IVs for file contents encryption (similar to ESSIV), and to prepend
> some key-dependent bytes to the plaintext when encrypting filenames
> (which is useless since eCryptfs encrypts the filenames with ECB).
>
> Currently, eCryptfs computes these MD5 hashes using the crypto_shash
> API. Update it to instead use the MD5 library API. This is simpler and
> faster: the library doesn't require memory allocations, can't fail, and
> provides direct access to MD5 without overhead such as indirect calls.
>
> [...]
Applied to the vfs-6.19.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.19.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.19.misc
[1/1] ecryptfs: Use MD5 library instead of crypto_shash
https://git.kernel.org/vfs/vfs/c/7f77fe73421f
prev parent reply other threads:[~2025-10-21 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-11 20:00 [PATCH] ecryptfs: Use MD5 library instead of crypto_shash Eric Biggers
2025-10-14 7:57 ` Ard Biesheuvel
2025-10-21 12:26 ` Christian Brauner
2025-10-21 12:27 ` Christian Brauner
2025-10-21 15:09 ` Eric Biggers
2025-10-21 12:59 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021-implosion-ambivalent-bfc95c0b3c5e@brauner \
--to=brauner@kernel.org \
--cc=code@tyhicks.com \
--cc=ebiggers@kernel.org \
--cc=ecryptfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).