From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2793A3126C7; Fri, 24 Oct 2025 10:53:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761303217; cv=none; b=njjRpqmLfwwU1aiMjKdzjOC9LFfehojtn2xCePJYWqz78KuXjqfYW1ad5583pHSvZ14WtFqnDQiD7YF5rM3uTKlpjStN7jCNX3GfXRoLTJ/Oad7K92EY1ZIuZi01d8Nh7Ts56rHUP7RIyjOmwczs8FWwah3nhoK21PtXgt8EQiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761303217; c=relaxed/simple; bh=7aAHCcaecm2VZuosAD5WF6qVRIAZipjG6VYIR7g9o5A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=D0aB8V0HGADbmpG9NZiCbC1CQofxh4+mj62Jt+59+DD5nMl4XQls37GsqyDOlyeTWAjKNm0uIytMNnXgrsKRJ9PajrtNDkN5yTXvfczyK7TWpc8gKi6jSBvEmdP7F3tCCW2DzGLyXcjeYvHEYBWi4LcrVQHcEupCMIKsApKXf6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gIj+Tkmo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gIj+Tkmo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24BBDC4CEF1; Fri, 24 Oct 2025 10:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761303216; bh=7aAHCcaecm2VZuosAD5WF6qVRIAZipjG6VYIR7g9o5A=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=gIj+TkmoGJOiasOs8X1moJXVepkYY2XYsCjSLQivwBOx8EdmXXdVCS9c8kEB2vfKQ unVmGvBiQkqBVHL9srqDcCjuW8Z+WbHwOE986epDXcoKCV1Tt0ScAT16CitnU31LOc EJbYxgNokKHGRFo6aD7Tc2urcoNzBXxvgjT6C1hBB7rNvUhU2mEIBegjZjcQuF3n0g RLDC/shbxTJ9moRENz78H9H3A3saiLzqlz4Hp3/TkHW9S/DAB2dcBQXMQPaz3wu14v FS2QeNGGHeDQqKePMBRcdO+H6G6VDqstp5taiuTc9fxzcwHP/OTubjOooIppJQzv4z 5w1hegZ9gk9tg== From: Christian Brauner Date: Fri, 24 Oct 2025 12:52:36 +0200 Subject: [PATCH v3 07/70] nstree: simplify return Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251024-work-namespace-nstree-listns-v3-7-b6241981b72b@kernel.org> References: <20251024-work-namespace-nstree-listns-v3-0-b6241981b72b@kernel.org> In-Reply-To: <20251024-work-namespace-nstree-listns-v3-0-b6241981b72b@kernel.org> To: linux-fsdevel@vger.kernel.org, Josef Bacik , Jeff Layton Cc: Jann Horn , Mike Yuan , =?utf-8?q?Zbigniew_J=C4=99drzejewski-Szmek?= , Lennart Poettering , Daan De Meyer , Aleksa Sarai , Amir Goldstein , Tejun Heo , Johannes Weiner , Thomas Gleixner , Alexander Viro , Jan Kara , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, bpf@vger.kernel.org, Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, Arnd Bergmann , Christian Brauner X-Mailer: b4 0.15-dev-96507 X-Developer-Signature: v=1; a=openpgp-sha256; l=670; i=brauner@kernel.org; h=from:subject:message-id; bh=7aAHCcaecm2VZuosAD5WF6qVRIAZipjG6VYIR7g9o5A=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWT8jmoxZO2o8/z8INOhRSduc/qa6/sua2m/+L3oSf6pm 8cEPbkDO0pZGMS4GGTFFFkc2k3C5ZbzVGw2ytSAmcPKBDKEgYtTACby/ggjwwGLdQ7HijJf+rPd iN1et2231LqGCYcKg5JY1cV4n8zOfcLIcGNZv/EnqT79+yobF7GWz97ucWrFd5fn98MWmz1gUVv CzwgA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 node_to_ns() checks for NULL and the assert isn't really helpful and will have to be dropped later anyway. Signed-off-by: Christian Brauner --- kernel/nstree.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/kernel/nstree.c b/kernel/nstree.c index b24a320a11a6..369fd1675c6a 100644 --- a/kernel/nstree.c +++ b/kernel/nstree.c @@ -194,11 +194,6 @@ struct ns_common *ns_tree_lookup_rcu(u64 ns_id, int ns_type) break; } while (read_seqretry(&ns_tree->ns_tree_lock, seq)); - if (!node) - return NULL; - - VFS_WARN_ON_ONCE(node_to_ns(node)->ns_type != ns_type); - return node_to_ns(node); } -- 2.47.3