From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: mgurtovoy@nvidia.com, izach@nvidia.com, smalin@nvidia.com,
vgoyal@redhat.com, miklos@szeredi.hu, eperezma@redhat.com,
mst@redhat.com, jasowang@redhat.com,
virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org,
alok.a.tiwarilinux@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-fs: fix incorrect check for fsvq->kobj
Date: Mon, 27 Oct 2025 09:47:31 -0400 [thread overview]
Message-ID: <20251027134731.GA11774@fedora> (raw)
In-Reply-To: <20251027104658.1668537-1-alok.a.tiwari@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Mon, Oct 27, 2025 at 03:46:47AM -0700, Alok Tiwari wrote:
> In virtio_fs_add_queues_sysfs(), the code incorrectly checks fs->mqs_kobj
> after calling kobject_create_and_add(). Change the check to fsvq->kobj
> (fs->mqs_kobj -> fsvq->kobj) to ensure the per-queue kobject is
> successfully created.
>
> Fixes: 87cbdc396a31 ("virtio_fs: add sysfs entries for queue information")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> fs/fuse/virtio_fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-10-27 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 10:46 [PATCH] virtio-fs: fix incorrect check for fsvq->kobj Alok Tiwari
2025-10-27 13:47 ` Stefan Hajnoczi [this message]
2025-10-29 15:50 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027134731.GA11774@fedora \
--to=stefanha@redhat.com \
--cc=alok.a.tiwari@oracle.com \
--cc=alok.a.tiwarilinux@gmail.com \
--cc=eperezma@redhat.com \
--cc=izach@nvidia.com \
--cc=jasowang@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=miklos@szeredi.hu \
--cc=mst@redhat.com \
--cc=smalin@nvidia.com \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).