From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BD3E31062C for ; Mon, 27 Oct 2025 16:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761581512; cv=none; b=YSOeYhzIH0xq5381lATtwKltzAsDZH9JF7z8Hb7DS5hqsE1g5PSqhktjE6zemT4w7aKinIvRvfirOp6YcbJH7jbXSkgdOaXVJY78zDOvBHA74556wLCEn+SWmEj4zc4ExRPz2Dd8LOh+1Auh9galx20+I86Hwg8D4KRmujkQ18c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761581512; c=relaxed/simple; bh=QASK2aUkAxKfkFOMA/cYGhoLhloD9yCkGn3YMzpW+18=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gKUpeVTxiS/XGoWQFlxDtBbMapeVi5fHFx6//4UZF7gJ/82pLHq+3ao2HQtfdrtQfrm7bamAlp82tn/aZ7KyC4x0dAa1llNKQ39DFrlZXeRFjag9NlijlPO/FG6uDRpOBsBjsHNIDEEIWIFcTXEpUSam1Uw/2FKfMIJ2H72p3OY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Ohx/7NO4; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Ohx/7NO4" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-8a3eac7ca30so91836185a.2 for ; Mon, 27 Oct 2025 09:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1761581508; x=1762186308; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YUcoeTWEWXvPiJKMdWmX3nawwIDQdRa9/4C7h6Fu0G0=; b=Ohx/7NO4ciCWHNL73Cns7VAJ1PwwArjUkkOkpZszVRjDT/J1ZHSrYFfu6AeFhiv9hy rfv6DKkzI8zzm/s7UbRRFKdYqrEEHcVxOo+x/By7F5iTQ5J7uGND1htBgXYn/B7WCcfE RFrAJAvyaWQ7jSp5JtYVoOQ2fCyiCPhCT/vT/n8Xymi+ShqmJ43M2EEVpiFEiMQ6/K4y nZIXxOiiIFj/97EJczGs+oUlgG57l8e6hACg3+pJOPl5W9ijwpOHIU6x0FjUXG2R+cow PKCE/wfleDyFf38YFwiBxDNFxNYPEG9IjLiwd26ygh30jWHQZzcZ8eL9mbeLpTpEYd6Q 5BWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761581508; x=1762186308; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YUcoeTWEWXvPiJKMdWmX3nawwIDQdRa9/4C7h6Fu0G0=; b=BZ94k+GTYFbJurnHZyyumu49aM1KU2dWuq0whB8liyZ6rmxVJ4jpVCLBJu7FthPq71 K2CJCfp/B8mKybl0Yb02plS/tmp4ZxeC8DeqosHErNrBvW3MB4Ocx9+kYp0YwbS3IvLP ljjRCqmcKfzucHttykBjOtQZ79HAxF3anQEqYCz63lxNvREoKigwRjYjHasErkywwAoC GkghEAc+ISp24fNSBc1RnTXDIjjpQp4ogwStxcWKd53bwbh+5UWIE1CUO8TkcymnqncG 82veHVSulNUfroSZEgCeZtridXf5jaRxspErINw7KUcIUYR1MpMqxUYWHSLaqr5ykVRK t9Hg== X-Forwarded-Encrypted: i=1; AJvYcCVPPet3gEmc0rQAeLOkXrVsWKQNoM9VRwGi06WKeitHUKPTpqoEB5X/MT4IvxsMy5RaxsZCTO8UDx1DK7bM@vger.kernel.org X-Gm-Message-State: AOJu0YwFzOFkpmxm2/fBUcPjMuPzoyRWtyWsWA1iFjcpiD05md0WA051 jRpZ7jDEqZArGGOgfGK8m75VCrBZ3F8eE0gCrG4VOZMfQtDDuHL5cBQpIylq1tODFoE= X-Gm-Gg: ASbGncsZgpLa5/887O9nxWJcJxfdFyFqXHOdrXrJY70RvXeXYtZSqb/S7M3idZf+pYB 4YR90TE9Oc2ENYr/zuz2HiwtR0Mt/nAjuzBFedxlQ5CKV44VgCAlydRSnCXCYcQogULhQSahhmu 7YZQn8PlmVjKq81yy1hjBwjLtEYTKYYS63bC4QrhvKXPEP64edJ0em+Byams5O+ymp6sQUpSzNm cJJZUp5Vdx0/C+QNZpL74y+eWsqBECIdjqXCGoQMe3z53i3VpXnK+F2diAzvgTaevKf1AN65Bgi olOAM5mom5eq8TxR1Deq+iUTmDSo13XGcyXvMLhctQff/fuwdNhV2Ok7I7VDQXJo1fjJRumKZZp YEoqojnVq5ohVYoeusSviYG/WkrgV/x+aXwKKKo3WWOn8Lr2WeD1iyEuK/qeMW5R0myK5mF4mxO zEjvbLmKOuR1Bkf8e5avy2so+gkpuQpnptoyrFYp11uXNhu5MofG3cUlZl X-Google-Smtp-Source: AGHT+IFJf0BibtsNlfavgV+F1phwUBGZobfoErAK4Dl+j0mvBEo1idyt8ArsRwOA8zB/HM5HTcYQOw== X-Received: by 2002:a05:620a:4627:b0:8a2:2233:c151 with SMTP id af79cd13be357-8a70118c82fmr40354785a.75.1761581507673; Mon, 27 Oct 2025 09:11:47 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f25c8b517sm628453785a.45.2025.10.27.09.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:11:47 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vDPow-00000004HUZ-2jWh; Mon, 27 Oct 2025 13:11:46 -0300 Date: Mon, 27 Oct 2025 13:11:46 -0300 From: Jason Gunthorpe To: Gregory Price Cc: Lorenzo Stoakes , Andrew Morton , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Sven Schnelle , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Kemeng Shi , Kairui Song , Nhat Pham , Baoquan He , Chris Li , Peter Xu , Matthew Wilcox , Leon Romanovsky , Muchun Song , Oscar Salvador , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Pedro Falcato , Pasha Tatashin , Rik van Riel , Harry Yoo , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 05/12] fs/proc/task_mmu: refactor pagemap_pmd_range() Message-ID: <20251027161146.GG760669@ziepe.ca> References: <2ce1da8c64bf2f831938d711b047b2eba0fa9f32.1761288179.git.lorenzo.stoakes@oracle.com> <76348b1f-2626-4010-8269-edd74a936982@lucifer.local> <3f3e5582-d707-41d0-99a7-4e9c25f1224d@lucifer.local> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Oct 24, 2025 at 04:37:18PM -0400, Gregory Price wrote: > On Fri, Oct 24, 2025 at 09:15:59PM +0100, Lorenzo Stoakes wrote: > > On Fri, Oct 24, 2025 at 03:12:08PM -0400, Gregory Price wrote: > > > > So maybe actually that isn't too bad of an idea... > > > > Could also be > > > > nonpresent_or_swap_t but that's kinda icky... > > clearly we need: > > union { > swp_entry_t swap; > nonpresent_entry_t np; > pony_entry_t pony; > plum_emtry_t beer; > } leaf_entry_t; > > with > > leaf_type whats_that_pte(leaf_entry_t); I think if you are going to try to rename swp_entry_t that is a pretty good idea. Maybe swleaf_entry_t to pace emphasis that it is not used by the HW page table walker would be a good compromise to the ugly 'non-present entry' term. Jason