linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: linux-fsdevel@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
	 Jeff Layton <jlayton@kernel.org>
Cc: "Jann Horn" <jannh@google.com>, "Mike Yuan" <me@yhndnzj.com>,
	"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
	"Lennart Poettering" <mzxreary@0pointer.de>,
	"Daan De Meyer" <daan.j.demeyer@gmail.com>,
	"Aleksa Sarai" <cyphar@cyphar.com>,
	"Amir Goldstein" <amir73il@gmail.com>,
	"Tejun Heo" <tj@kernel.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Jan Kara" <jack@suse.cz>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	bpf@vger.kernel.org, "Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	netdev@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
	"Christian Brauner" <brauner@kernel.org>
Subject: [PATCH v4 36/72] selftests/namespaces: fourteenth active reference count tests
Date: Wed, 29 Oct 2025 13:20:49 +0100	[thread overview]
Message-ID: <20251029-work-namespace-nstree-listns-v4-36-2e6f823ebdc0@kernel.org> (raw)
In-Reply-To: <20251029-work-namespace-nstree-listns-v4-0-2e6f823ebdc0@kernel.org>

Test that user namespace as a child also propagates correctly.
Create user_A -> user_B, verify when user_B is active that user_A
is also active. This is different from non-user namespace children.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 .../selftests/namespaces/ns_active_ref_test.c      | 132 +++++++++++++++++++++
 1 file changed, 132 insertions(+)

diff --git a/tools/testing/selftests/namespaces/ns_active_ref_test.c b/tools/testing/selftests/namespaces/ns_active_ref_test.c
index 25f06e623064..430702c041a9 100644
--- a/tools/testing/selftests/namespaces/ns_active_ref_test.c
+++ b/tools/testing/selftests/namespaces/ns_active_ref_test.c
@@ -1817,4 +1817,136 @@ TEST(ns_parent_multiple_children_refcount)
 	ASSERT_LT(p_fd, 0);
 }
 
+/*
+ * Test that user namespace as a child also propagates correctly.
+ * Create user_A -> user_B, verify when user_B is active that user_A
+ * is also active. This is different from non-user namespace children.
+ */
+TEST(ns_userns_child_propagation)
+{
+	struct file_handle *ua_handle, *ub_handle;
+	int ret, pipefd[2];
+	pid_t pid;
+	int status;
+	__u64 ua_id, ub_id;
+	char ua_buf[sizeof(*ua_handle) + MAX_HANDLE_SZ];
+	char ub_buf[sizeof(*ub_handle) + MAX_HANDLE_SZ];
+
+	ASSERT_EQ(pipe(pipefd), 0);
+	pid = fork();
+	ASSERT_GE(pid, 0);
+
+	if (pid == 0) {
+		close(pipefd[0]);
+
+		/* Create user_A */
+		if (setup_userns() < 0) {
+			close(pipefd[1]);
+			exit(1);
+		}
+
+		int ua_fd = open("/proc/self/ns/user", O_RDONLY);
+		if (ua_fd < 0) {
+			close(pipefd[1]);
+			exit(1);
+		}
+		if (ioctl(ua_fd, NS_GET_ID, &ua_id) < 0) {
+			close(ua_fd);
+			close(pipefd[1]);
+			exit(1);
+		}
+		close(ua_fd);
+
+		/* Create user_B (child of user_A) */
+		if (setup_userns() < 0) {
+			close(pipefd[1]);
+			exit(1);
+		}
+
+		int ub_fd = open("/proc/self/ns/user", O_RDONLY);
+		if (ub_fd < 0) {
+			close(pipefd[1]);
+			exit(1);
+		}
+		if (ioctl(ub_fd, NS_GET_ID, &ub_id) < 0) {
+			close(ub_fd);
+			close(pipefd[1]);
+			exit(1);
+		}
+		close(ub_fd);
+
+		/* Send both namespace IDs */
+		write(pipefd[1], &ua_id, sizeof(ua_id));
+		write(pipefd[1], &ub_id, sizeof(ub_id));
+		close(pipefd[1]);
+		exit(0);
+	}
+
+	close(pipefd[1]);
+
+	/* Read both namespace IDs - fixed size, no parsing needed */
+	ret = read(pipefd[0], &ua_id, sizeof(ua_id));
+	if (ret != sizeof(ua_id)) {
+		close(pipefd[0]);
+		waitpid(pid, NULL, 0);
+		SKIP(return, "Failed to read user_A namespace ID");
+	}
+
+	ret = read(pipefd[0], &ub_id, sizeof(ub_id));
+	close(pipefd[0]);
+	if (ret != sizeof(ub_id)) {
+		waitpid(pid, NULL, 0);
+		SKIP(return, "Failed to read user_B namespace ID");
+	}
+
+	/* Construct file handles from namespace IDs */
+	ua_handle = (struct file_handle *)ua_buf;
+	ua_handle->handle_bytes = sizeof(struct nsfs_file_handle);
+	ua_handle->handle_type = FILEID_NSFS;
+	struct nsfs_file_handle *ua_fh = (struct nsfs_file_handle *)ua_handle->f_handle;
+	ua_fh->ns_id = ua_id;
+	ua_fh->ns_type = 0;
+	ua_fh->ns_inum = 0;
+
+	ub_handle = (struct file_handle *)ub_buf;
+	ub_handle->handle_bytes = sizeof(struct nsfs_file_handle);
+	ub_handle->handle_type = FILEID_NSFS;
+	struct nsfs_file_handle *ub_fh = (struct nsfs_file_handle *)ub_handle->f_handle;
+	ub_fh->ns_id = ub_id;
+	ub_fh->ns_type = 0;
+	ub_fh->ns_inum = 0;
+
+	/* Open user_B before child exits */
+	int ub_fd = open_by_handle_at(FD_NSFS_ROOT, ub_handle, O_RDONLY);
+	if (ub_fd < 0) {
+		waitpid(pid, NULL, 0);
+		SKIP(return, "Failed to open user_B");
+	}
+
+	waitpid(pid, &status, 0);
+	ASSERT_TRUE(WIFEXITED(status));
+	ASSERT_EQ(WEXITSTATUS(status), 0);
+
+	/* With user_B active, user_A should also be active */
+	TH_LOG("Testing user_A active when child user_B is active");
+	int ua_fd = open_by_handle_at(FD_NSFS_ROOT, ua_handle, O_RDONLY);
+	ASSERT_GE(ua_fd, 0);
+
+	/* Close user_B */
+	TH_LOG("Closing user_B");
+	close(ub_fd);
+
+	/* user_A should remain active (we hold direct ref) */
+	int ua_fd2 = open_by_handle_at(FD_NSFS_ROOT, ua_handle, O_RDONLY);
+	ASSERT_GE(ua_fd2, 0);
+	close(ua_fd2);
+
+	/* Close user_A - should become inactive */
+	TH_LOG("Closing user_A - should become inactive");
+	close(ua_fd);
+
+	ua_fd = open_by_handle_at(FD_NSFS_ROOT, ua_handle, O_RDONLY);
+	ASSERT_LT(ua_fd, 0);
+}
+
 TEST_HARNESS_MAIN

-- 
2.47.3


  parent reply	other threads:[~2025-10-29 12:23 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 12:20 [PATCH v4 00/72] nstree: listns() Christian Brauner
2025-10-29 12:20 ` [PATCH v4 01/72] libfs: allow to specify s_d_flags Christian Brauner
2025-10-29 12:20 ` [PATCH v4 02/72] nsfs: use inode_just_drop() Christian Brauner
2025-10-29 12:20 ` [PATCH v4 03/72] nsfs: raise DCACHE_DONTCACHE explicitly Christian Brauner
2025-10-29 12:20 ` [PATCH v4 04/72] pidfs: " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 05/72] nsfs: raise SB_I_NODEV and SB_I_NOEXEC Christian Brauner
2025-10-29 12:20 ` [PATCH v4 06/72] cgroup: add cgroup namespace to tree after owner is set Christian Brauner
2025-10-29 12:20 ` [PATCH v4 07/72] nstree: simplify return Christian Brauner
2025-10-29 12:20 ` [PATCH v4 08/72] ns: initialize ns_list_node for initial namespaces Christian Brauner
2025-10-29 12:20 ` [PATCH v4 09/72] ns: add __ns_ref_read() Christian Brauner
2025-10-29 12:20 ` [PATCH v4 10/72] ns: rename to exit_nsproxy_namespaces() Christian Brauner
2025-10-29 12:20 ` [PATCH v4 11/72] ns: add active reference count Christian Brauner
2025-10-29 12:20 ` [PATCH v4 12/72] ns: use anonymous struct to group list member Christian Brauner
2025-10-29 12:20 ` [PATCH v4 13/72] nstree: introduce a unified tree Christian Brauner
2025-10-29 14:44   ` kernel test robot
2025-10-29 14:55   ` kernel test robot
2025-10-29 12:20 ` [PATCH v4 14/72] nstree: allow lookup solely based on inode Christian Brauner
2025-10-29 12:20 ` [PATCH v4 15/72] nstree: assign fixed ids to the initial namespaces Christian Brauner
2025-10-29 12:20 ` [PATCH v4 16/72] nstree: maintain list of owned namespaces Christian Brauner
2025-10-29 12:20 ` [PATCH v4 17/72] nstree: simplify rbtree comparison helpers Christian Brauner
2025-10-30 13:48   ` Jeff Layton
2025-10-29 12:20 ` [PATCH v4 18/72] nstree: add unified namespace list Christian Brauner
2025-11-01 19:20   ` Thomas Gleixner
2025-11-03 11:21     ` Christian Brauner
2025-10-29 12:20 ` [PATCH v4 19/72] nstree: add listns() Christian Brauner
2025-10-29 12:20 ` [PATCH v4 20/72] arch: hookup listns() system call Christian Brauner
2025-10-29 12:20 ` [PATCH v4 21/72] nsfs: update tools header Christian Brauner
2025-10-29 12:20 ` [PATCH v4 22/72] selftests/filesystems: remove CLONE_NEWPIDNS from setup_userns() helper Christian Brauner
2025-10-29 12:20 ` [PATCH v4 23/72] selftests/namespaces: first active reference count tests Christian Brauner
2025-10-29 12:20 ` [PATCH v4 24/72] selftests/namespaces: second " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 25/72] selftests/namespaces: third " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 26/72] selftests/namespaces: fourth " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 27/72] selftests/namespaces: fifth " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 28/72] selftests/namespaces: sixth " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 29/72] selftests/namespaces: seventh " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 30/72] selftests/namespaces: eigth " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 31/72] selftests/namespaces: ninth " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 32/72] selftests/namespaces: tenth " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 33/72] selftests/namespaces: eleventh " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 34/72] selftests/namespaces: twelth " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 35/72] selftests/namespaces: thirteenth " Christian Brauner
2025-10-29 12:20 ` Christian Brauner [this message]
2025-10-29 12:20 ` [PATCH v4 37/72] selftests/namespaces: fifteenth " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 38/72] selftests/namespaces: add listns() wrapper Christian Brauner
2025-10-29 12:20 ` [PATCH v4 39/72] selftests/namespaces: first listns() test Christian Brauner
2025-10-29 12:20 ` [PATCH v4 40/72] selftests/namespaces: second " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 41/72] selftests/namespaces: third " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 42/72] selftests/namespaces: fourth " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 43/72] selftests/namespaces: fifth " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 44/72] selftests/namespaces: sixth " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 45/72] selftests/namespaces: seventh " Christian Brauner
2025-10-29 12:20 ` [PATCH v4 46/72] selftests/namespaces: eigth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 47/72] selftests/namespaces: ninth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 48/72] selftests/namespaces: first listns() permission test Christian Brauner
2025-10-29 12:21 ` [PATCH v4 49/72] selftests/namespaces: second " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 50/72] selftests/namespaces: third " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 51/72] selftests/namespaces: fourth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 52/72] selftests/namespaces: fifth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 53/72] selftests/namespaces: sixth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 54/72] selftests/namespaces: seventh " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 55/72] selftests/namespaces: first inactive namespace resurrection test Christian Brauner
2025-10-29 12:21 ` [PATCH v4 56/72] selftests/namespaces: second " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 57/72] selftests/namespaces: third " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 58/72] selftests/namespaces: fourth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 59/72] selftests/namespaces: fifth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 60/72] selftests/namespaces: sixth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 61/72] selftests/namespaces: seventh " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 62/72] selftests/namespaces: eigth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 63/72] selftests/namespaces: ninth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 64/72] selftests/namespaces: tenth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 65/72] selftests/namespaces: eleventh " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 66/72] selftests/namespaces: twelth " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 67/72] selftests/namespace: first threaded active reference count test Christian Brauner
2025-10-29 12:21 ` [PATCH v4 68/72] selftests/namespace: second " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 69/72] selftests/namespace: third " Christian Brauner
2025-10-29 12:21 ` [PATCH v4 70/72] selftests/namespace: commit_creds() active reference tests Christian Brauner
2025-10-29 12:21 ` [PATCH v4 71/72] selftests/namespace: add stress test Christian Brauner
2025-10-29 12:21 ` [PATCH v4 72/72] selftests/namespace: test listns() pagination Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251029-work-namespace-nstree-listns-v4-36-2e6f823ebdc0@kernel.org \
    --to=brauner@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bpf@vger.kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=cyphar@cyphar.com \
    --cc=daan.j.demeyer@gmail.com \
    --cc=edumazet@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=jannh@google.com \
    --cc=jlayton@kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=kuba@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@yhndnzj.com \
    --cc=mzxreary@0pointer.de \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zbyszek@in.waw.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).