From: Mateusz Guzik <mjguzik@gmail.com>
To: brauner@kernel.org
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, tytso@mit.edu,
torvalds@linux-foundation.org, josef@toxicpanda.com,
linux-btrfs@vger.kernel.org, Mateusz Guzik <mjguzik@gmail.com>
Subject: [PATCH v3 3/3] fs: retire now stale MAY_WRITE predicts in inode_permission()
Date: Fri, 7 Nov 2025 15:21:49 +0100 [thread overview]
Message-ID: <20251107142149.989998-4-mjguzik@gmail.com> (raw)
In-Reply-To: <20251107142149.989998-1-mjguzik@gmail.com>
The primary non-MAY_WRITE consumer now uses lookup_inode_permission_may_exec().
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
fs/namei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index 6b2a5a5478e7..2a112b2c0951 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -546,7 +546,7 @@ static inline int do_inode_permission(struct mnt_idmap *idmap,
*/
static int sb_permission(struct super_block *sb, struct inode *inode, int mask)
{
- if (unlikely(mask & MAY_WRITE)) {
+ if (mask & MAY_WRITE) {
umode_t mode = inode->i_mode;
/* Nobody gets write access to a read-only fs. */
@@ -577,7 +577,7 @@ int inode_permission(struct mnt_idmap *idmap,
if (unlikely(retval))
return retval;
- if (unlikely(mask & MAY_WRITE)) {
+ if (mask & MAY_WRITE) {
/*
* Nobody gets write access to an immutable file.
*/
--
2.48.1
next prev parent reply other threads:[~2025-11-07 14:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 14:21 [PATCH v3 0/3] cheaper MAY_EXEC handling for path lookup Mateusz Guzik
2025-11-07 14:21 ` [PATCH v3 1/3] fs: speed up path lookup with cheaper handling of MAY_EXEC Mateusz Guzik
2025-11-10 9:32 ` Jan Kara
2025-11-10 9:46 ` Mateusz Guzik
2025-11-10 10:13 ` Jan Kara
2025-11-10 12:42 ` Mateusz Guzik
2025-11-11 9:41 ` Christian Brauner
2025-11-11 10:51 ` Mateusz Guzik
2025-11-11 11:47 ` Mateusz Guzik
2025-11-07 14:21 ` [PATCH v3 2/3] btrfs: utilize IOP_FASTPERM_MAY_EXEC Mateusz Guzik
2025-11-10 15:40 ` David Sterba
2025-11-07 14:21 ` Mateusz Guzik [this message]
2025-11-10 10:15 ` [PATCH v3 3/3] fs: retire now stale MAY_WRITE predicts in inode_permission() Jan Kara
2025-11-11 9:42 ` [PATCH v3 0/3] cheaper MAY_EXEC handling for path lookup Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107142149.989998-4-mjguzik@gmail.com \
--to=mjguzik@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).