From: Masaharu Noguchi <nogunix@gmail.com>
To: Jeff Layton <jlayton@kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Cc: Jesper Juhl <jesperjuhl76@gmail.com>,
David Laight <david.laight.linux@gmail.com>,
Alexander Aring <alex.aring@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Masaharu Noguchi <nogunix@gmail.com>
Subject: [PATCH v2 0/2] uapi/samples: guard renameat2 flag macros
Date: Mon, 10 Nov 2025 23:42:30 +0900 [thread overview]
Message-ID: <20251110144232.3765169-1-nogunix@gmail.com> (raw)
Including `<linux/fcntl.h>` after libc headers leaves the renameat2 flag
macros stuck with libc's values, and our sample code in turn redefines
them when it includes the uapi header. This little series makes the
uapi header resilient to prior definitions and ensures the sample drops
any libc remnants before pulling in the kernel constants.
Changes since v1 (based on feedback from David Laight):
- uapi change now checks the macro values and undefines mismatches
- sample code always undefines the macros up front and documents why
Link: https://lore.kernel.org/all/20251109071304.2415982-1-nogunix@gmail.com/
Masaharu Noguchi (2):
uapi: fcntl: guard AT_RENAME_* aliases
samples: vfs: avoid libc AT_RENAME_* redefinitions
include/uapi/linux/fcntl.h | 15 ++++++++++++++-
samples/vfs/test-statx.c | 9 +++++++++
2 files changed, 23 insertions(+), 1 deletion(-)
base-commit: e9a6fb0bcdd7609be6969112f3fbfcce3b1d4a7c
--
2.51.1
next reply other threads:[~2025-11-10 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 14:42 Masaharu Noguchi [this message]
2025-11-10 14:42 ` [PATCH v2 1/2] uapi: fcntl: guard AT_RENAME_* aliases Masaharu Noguchi
2025-11-10 23:11 ` David Laight
2025-11-10 14:42 ` [PATCH v2 2/2] samples: vfs: avoid libc AT_RENAME_* redefinitions Masaharu Noguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110144232.3765169-1-nogunix@gmail.com \
--to=nogunix@gmail.com \
--cc=alex.aring@gmail.com \
--cc=chuck.lever@oracle.com \
--cc=david.laight.linux@gmail.com \
--cc=jesperjuhl76@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).