From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C158319CD05 for ; Mon, 10 Nov 2025 23:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762816323; cv=none; b=bNlnpq1fMRyId8ztYQImIah38mdDtGtbgD9VWJQoAq4Z2jwsyqtalAeUU6o8jmI5QWrAZlRkxpsjYuQoT/8/86IDBZa2gUwSwIBhDHClitzJc9BM6RLTTKvjdldnq7XbBXDEjpPLfzcVMg3Gf0r5v1Yxvt92/VcmuwQfrkjC+Iw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762816323; c=relaxed/simple; bh=NCsEEDLAZ7D0HQmvFIC8vI7abvE/3WSqCFBNjRC9Hw0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UsXlSYUxZyWcsWTx9EMjjNbOFy3bfHOmRLhEqKy03dMR7v04CzteKCPtAxFQglfTB/FHIZe0Q7/y8yg/kKcZyzaTRa69X+ck29wxE7rKYuZ+LtWArlJmTHIejfvQJe7Buq6LFlqO6KVHdR/T7XvODZOKQzulzpoheyrsffBz9ew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XBHfNOW/; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XBHfNOW/" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47777000dadso15559585e9.1 for ; Mon, 10 Nov 2025 15:12:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762816320; x=1763421120; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8ur+jItSBFJa8rWcgkoqU0zfeF/8teVfafx9jMHzM0o=; b=XBHfNOW/CWnAIqqFsRJJzORDacsqrC8yieCkACo6mdc1LXCSB0WEc1KhWSmB7mEzat QVpGTvB5NQ7n6+5n6rI+tkINqmaM1ftAzCt+r2eeGsm4KweMYDibjIpJgX6pvFXMTUbQ LPUGzAoL9jB8sQsNZweqlFOheWP3UjElelK9RiQI/adH4rDSjM3mn0Jp2i7xukq66z7B gOTi6nGViJ7cXbKs1vm9QgsFcDg9OMu7wIc+2XNKNaC83oOHcIvG4Zq/yxlbueZ5Tlev SsrVXaRAJAVxEfGycUv+LrYrVe21VsLD2ytr+l/hB14YXHtOLnCLb0wK7sVMb6DOufGM CEhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762816320; x=1763421120; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8ur+jItSBFJa8rWcgkoqU0zfeF/8teVfafx9jMHzM0o=; b=Wkj85lQVSJwdqMK0QuIbg5gaPpZU8vpIl8Rc8UNHrjBwTQoSLCWgYNQtjLwyBz4/sv BUGyMFLx2kt4SrPHIxE9KSfK1u7sZxqd/QExkYMtK8DjL7/KzycX0KFC9+EfKSKY0nG3 pe2M4lSUbh1osjaE+hWv20czsxFMmb9fG5jIksqHr7R/cPU6rXOZEWo3ePrZnRCayOJW gE+Vy/6zDUHpTd6CqJGBrdMeHhz9H1cbic21asqCu4nTiujJxGA0cnGjraZPa3X+qcp5 l92SR3hxtYgmwcC9fXMqriHAUi+PdqM6KSwbheUTgMOk9R0SnP0YmKqI8L0XpN2gjU+z Cq5Q== X-Forwarded-Encrypted: i=1; AJvYcCXnmcUxcOtvZW6ibljm7RQXZYVfqwC7vp1hxDdyXmAFHm5fpOiPEguwKp3OaRXSwMA4YNAQKK5xkQ6Tlr0z@vger.kernel.org X-Gm-Message-State: AOJu0YyFCdRN6kAje4xaKaGc5Iv0YCEHJAHlEs6t1tFT/opvMGPxnKAi iyC25uyl1WjEUO3cjd6FwgCaRZ8Ks/2mvG0BC2MceSLw55e+hvNwc3O7 X-Gm-Gg: ASbGnctU3r4XbQ0wOJo4mVnv2rXntQx2vGAIVDxisBM7TY31QvS9mgsLsDM/9QY+7HW DxSicUbqNYwVti+oNtumQBnkY/e2BRQVLZFIwkMf/a1yiSguQjfbPfKR+EyzquuxSrTdSBPModo B4p8fiVW4gcj8zw3vgVWkEmVRJYlLdYqvf5SAsYewZ47FT0oeThpMgj12oGea4DbqWVVtYw9M32 IiVYa0/tTL66Afm3GnX6dHmtygqvxSH24RvqzNgacL1h1Irnu79wQvX6zJcpCL2vVs0b4357UwU MUuF3Pex1UYEDkktk4RPmoamDhxAOjUvLFeUmhsRBjv5YEvbZ+YQ7hp6S7GFYPsxOUfah8KhTVF wJPEhHmNgl7adMFiWD0w9cjnKR5gX88Mgaq3kya6Ibwv+qZk25UnHkidVMmV8HMbBNuunMt3NRb sr3xRMwhA6IGHRZ4mHCXQ6M9NnUZl11WutBHqUaXuJw9Fl0+kT6OVLyDzjzvnKemA= X-Google-Smtp-Source: AGHT+IFKFQudGUWC8YZ8n+/dp+UJPFiAfw2pO9ZlY7yngKFOQ04Xr0yonHE+avDNO2qvESuJ3bxTEg== X-Received: by 2002:a05:600c:4448:b0:46e:206a:78cc with SMTP id 5b1f17b1804b1-47773290517mr90700755e9.28.1762816319864; Mon, 10 Nov 2025 15:11:59 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47761c2fe2asm285284515e9.5.2025.11.10.15.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 15:11:59 -0800 (PST) Date: Mon, 10 Nov 2025 23:11:57 +0000 From: David Laight To: Masaharu Noguchi Cc: Jeff Layton , Chuck Lever , Jesper Juhl , Alexander Aring , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] uapi: fcntl: guard AT_RENAME_* aliases Message-ID: <20251110231157.4ab7601b@pumpkin> In-Reply-To: <20251110144232.3765169-2-nogunix@gmail.com> References: <20251110144232.3765169-1-nogunix@gmail.com> <20251110144232.3765169-2-nogunix@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 10 Nov 2025 23:42:31 +0900 Masaharu Noguchi wrote: > Including after libc headers such as stdio.h may leave > the renameat2() flag macros defined to libc's values. That leaks the > wrong numbers into user space even though the kernel header tries to > provide its own aliases. > > Check whether AT_RENAME_* is already defined and whether the value > matches what the uapi header expects. If not, drop the old definition > and replace it with the kernel one so the exported flags stay stable > regardless of include order. > > Signed-off-by: Masaharu Noguchi > --- > include/uapi/linux/fcntl.h | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/fcntl.h b/include/uapi/linux/fcntl.h > index 3741ea1b73d8..8b667550e44a 100644 > --- a/include/uapi/linux/fcntl.h > +++ b/include/uapi/linux/fcntl.h > @@ -156,10 +156,23 @@ > * as possible, so we can use them for generic bits in the future if necessary. > */ > > -/* Flags for renameat2(2) (must match legacy RENAME_* flags). */ > +/* Flags for renameat2(2) (must match legacy RENAME_* flags). > + * stdio.h may define these differently, so check explicitly. > + */ > +#if !defined(AT_RENAME_NOREPLACE) || AT_RENAME_NOREPLACE != 0x0001 > +#undef AT_RENAME_NOREPLACE I deliberately left out the #undef so you'd get a compile-time error if the values of the definitions differ. David > #define AT_RENAME_NOREPLACE 0x0001 > +#endif > + > +#if !defined(AT_RENAME_EXCHANGE) || AT_RENAME_EXCHANGE != 0x0002 > +#undef AT_RENAME_EXCHANGE > #define AT_RENAME_EXCHANGE 0x0002 > +#endif > + > +#if !defined(AT_RENAME_WHITEOUT) || AT_RENAME_WHITEOUT != 0x0004 > +#undef AT_RENAME_WHITEOUT > #define AT_RENAME_WHITEOUT 0x0004 > +#endif > > /* Flag for faccessat(2). */ > #define AT_EACCESS 0x200 /* Test access permitted for