From: Al Viro <viro@zeniv.linux.org.uk>
To: Ian Kent <raven@themaw.net>
Cc: Christian Brauner <brauner@kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
autofs mailing list <autofs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 2/2] autofs: dont trigger mount if it cant succeed
Date: Tue, 11 Nov 2025 09:04:16 +0000 [thread overview]
Message-ID: <20251111090416.GR2441659@ZenIV> (raw)
In-Reply-To: <d8040d10-3e2a-44d9-9df2-f275dc050fcd@themaw.net>
On Tue, Nov 11, 2025 at 04:25:29PM +0800, Ian Kent wrote:
> > Huh? What's to guarantee that superblock won't outlive the namespace?
>
> Not 30 minutes after I posted these I was thinking about the case the daemon
>
> (that mounted this) going away, very loosely similar I think. Setting the
>
> mounting process's namespace when it mounts it is straight forward but what
>
> can I do if the process crashes ...
>
>
> I did think that if the namespace is saved away by the process that mounts
>
> it that the mount namespace would be valid at least until it umounts it but
>
> yes there are a few things that can go wrong ...
Umm...
1) super_block != mount; unshare(CLONE_NEWNS) by anyone in the namespace of
that mount *will* create a clone of that mount, with exact same ->mnt_sb
and yes, in a separate namespace.
2) mount does not pin a namespace. chdir into it, umount -l and there you go...
3) mount(2) can bloody well create more than one struct mount, all with the
same ->mnt_sb.
So I'd say there's more than a few things that can go wrong here.
Said that, this "we need a daemon in that namespace" has been a source of
assorted headaches for decades now; could we do anything about that?
After all, a thread can switch from one namespace to another these
days (setns(2))...
next prev parent reply other threads:[~2025-11-11 9:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 6:04 [PATCH 0/2] autofs: fairly minor fixes Ian Kent
2025-11-11 6:04 ` [PATCH 1/2] autofs: fix per-dentry timeout warning Ian Kent
2025-12-02 23:19 ` Ian Kent
2025-11-11 6:04 ` [PATCH 2/2] autofs: dont trigger mount if it cant succeed Ian Kent
2025-11-11 6:59 ` Al Viro
2025-11-11 8:25 ` Ian Kent
2025-11-11 9:04 ` Al Viro [this message]
2025-11-11 10:13 ` Ian Kent
2025-11-11 10:16 ` Al Viro
2025-11-11 10:19 ` Christian Brauner
2025-11-11 10:24 ` Al Viro
2025-11-11 10:55 ` Christian Brauner
2025-11-11 12:27 ` Ian Kent
2025-11-12 11:01 ` Christian Brauner
2025-11-13 0:14 ` Ian Kent
2025-11-13 13:19 ` Christian Brauner
2025-11-13 23:49 ` Ian Kent
2025-11-14 0:07 ` Ian Kent
2025-11-14 11:44 ` Christian Brauner
2025-11-14 13:42 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251111090416.GR2441659@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=autofs@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).